[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Jonathan Druart changed: What|Removed |Added Attachment #40381|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 40382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40382&action=edit Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in catalogue/search.pl and opac/opac-search to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile->Zebra and Fairfeild->Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Test in both staff and opac search 10 - Ensure there are no unintended consequences/regressions Signed-off-by: Bernardo Gonzalez Kriegel Work as described, staff AND opac No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #40324|0 |1 is obsolete|| --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 40381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40381&action=edit [SIGNED-OFF] Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in catalogue/search.pl and opac/opac-search to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile->Zebra and Fairfeild->Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Test in both staff and opac search 10 - Ensure there are no unintended consequences/regressions Signed-off-by: Bernardo Gonzalez Kriegel Work as described, staff AND opac No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens changed: What|Removed |Added Attachment #40314|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 40324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40324&action=edit Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in catalogue/search.pl and opac/opac-search to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile->Zebra and Fairfeild->Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Test in both staff and opac search 10 - Ensure there are no unintended consequences/regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- This change should also done at the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 --- Comment #4 from Jonathan Druart --- *be* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #40054|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 40314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40314&action=edit [SIGNED-OFF] Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in search.pl to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile->Zebra and Fairfeild->Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Ensure there are no unintended consequences/regressions Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 --- Comment #1 from Nick Clemens --- Created attachment 40054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40054&action=edit Bug 14371 - Facets should be sorted by label (displayed) not title (link value) This patch changes one small line in search.pl to sort facets by: facet_label_value instead of facet_title_value To test: 1 - Perform a search with results in two branches e.g. Centerville (code CPL) and Fairfield (code FPL) 2 - Notice that branch facets appear correctly sorted 3 - Rename the branches Centervile->Zebra and Fairfeild->Aardvark (but don't change codes) 4 - Repeat original search 5 - Note that branch facets are no longer correctly sorted 6 - Apply patch 7 - Repeat search 8 - Facets should be correctly sorted 9 - Ensure there are no unintended consequences/regressions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14371] Facets should be sorted by label (displayed) not title (link value)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14371 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
