[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #38 from vimal kumar  ---
(In reply to Katrin Fischer from comment #37)
> *** Bug 4076 has been marked as a duplicate of this bug. ***

Thank you Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Katrin Fischer  changed:

   What|Removed |Added

 CC||vimal0...@gmail.com

--- Comment #37 from Katrin Fischer  ---
*** Bug 4076 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16390
[Bug 16390] Accounts.t does not need MPL
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42997|0   |1
is obsolete||

--- Comment #35 from Barton Chittenden  ---
Created attachment 44664
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44664=edit
Bug 14402: - QA Followup

Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #36 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Barton!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #32 from Jonathan Druart  
---
Created attachment 42995
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42995=edit
Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #33 from Jonathan Druart  
---
Created attachment 42996
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42996=edit
Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42816|0   |1
is obsolete||
  Attachment #42817|0   |1
is obsolete||
  Attachment #42818|0   |1
is obsolete||
  Attachment #42819|0   |1
is obsolete||
  Attachment #42820|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  
---
Created attachment 42993
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42993=edit
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #31 from Jonathan Druart  
---
Created attachment 42994
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42994=edit
Bug 14402: Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #34 from Jonathan Druart  
---
Created attachment 42997
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42997=edit
Bug 14402: - QA Followup

Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #29 from NancyK.  ---
Can I get a status on Q and A?

Nancy K

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42815|0   |1
is obsolete||

--- Comment #24 from Barton Chittenden  ---
Created attachment 42816
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42816=edit
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #25 from Barton Chittenden  ---
Created attachment 42817
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42817=edit
Bug 14402: Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #27 from Barton Chittenden  ---
Created attachment 42819
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42819=edit
Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #28 from Barton Chittenden  ---
Created attachment 42820
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42820=edit
Bug 14402: - QA Followup

Added notes to usage in misc/cronjobs/cleanup_database.pl that
--fees DAYS requires DAYS to be greater than or equal to 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #26 from Barton Chittenden  ---
Created attachment 42818
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42818=edit
Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42477|0   |1
is obsolete||
  Attachment #42478|0   |1
is obsolete||
  Attachment #42479|0   |1
is obsolete||
  Attachment #42480|0   |1
is obsolete||
  Attachment #42557|0   |1
is obsolete||

--- Comment #23 from Barton Chittenden  ---
Created attachment 42815
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42815=edit
Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #22 from Jonathan Druart  
---
The script does not accept --fees 0, is it expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Jonathan Druart  
---
 FAIL   misc/cronjobs/cleanup_database.pl
   FAIL   valid
Global symbol "$zebraqueue_days" requires explicit package name 
Global symbol "$allDebarments" requires explicit package name 
Global symbol "$verbose" requires explicit package name 
Global symbol "$pDebarments" requires explicit package name 
Global symbol "$pZ3950" requires explicit package name 
Global symbol "$pUnvSelfReg" requires explicit package name 
Global symbol "$fees_days" requires explicit package name 
Global symbol "$sess_days" requires explicit package name 
$help"
Global symbol "$pExpSelfReg" requires explicit package name 
Global symbol "$pListShareInvites" requires explicit package
name 
Global symbol "$purge_merged" requires explicit package name 
Global symbol "$sessions" requires explicit package name 
Global symbol "$help" requires explicit package name 
syntax error 
Scalar found where operator expected 
Global symbol "$pLogs" requires explicit package name 
Global symbol "$pSearchhistory" requires explicit package name 
(Missing operator before $help?)
Global symbol "$mail" requires explicit package name 
misc/cronjobs/cleanup_database.pl had compilation errors.
Global symbol "$pImport" requires explicit package name 

 FAIL   t/db_dependent/Accounts.t
   FAIL   spelling
 postive  ==> positive
   FAIL   valid
Global symbol "$sth" requires explicit package name 
t/db_dependent/Accounts.t had compilation errors.
Global symbol "$borrower" requires explicit package name 

And add the "Bug X" in the commit messages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #20 from Kyle M Hall  ---
Created attachment 42556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42556=edit
Bug 14402 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42556|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 42557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42557=edit
Bug 14402 - QA Followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42243|0   |1
is obsolete||

--- Comment #14 from Barton Chittenden  ---
Created attachment 42477
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42477=edit
Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42246|0   |1
is obsolete||

--- Comment #17 from Barton Chittenden  ---
Created attachment 42480
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42480=edit
[SIGNED-OFF] bug 14402: Make purge_zero_balance_fees() delete fees with NULL
balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42245|0   |1
is obsolete||

--- Comment #16 from Barton Chittenden  ---
Created attachment 42479
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42479=edit
Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42244|0   |1
is obsolete||

--- Comment #15 from Barton Chittenden  ---
Created attachment 42478
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42478=edit
Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #18 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #13)
> CONFLICT (content): Merge conflict in t/db_dependent/Account

Fixed conflicts. Please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #13 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in t/db_dependent/Accounts.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #7 from Barton Chittenden  ---
(In reply to Kyle M Hall from comment #3)
> (In reply to Katrin Fischer from comment #1)
> > Hm, this would need good testing. I think you also need to make sure there
> > is no problem with the way credits work. But it would be good to have!
> 
> Credits have a negative amount and amountoutstanding, so the query would
> definitely not affect credits.

Payments and credits have a negative amount and a *0* amountoutstanding.

As I understand accountlines, the account balance is calculated by summing the
amountoutstanding... so removing the records for credits and payments won't
affect the balance, but I'm concerned about partial payments: consider the case
of partial payments:

+-++---+---+++
| accountlines_id | borrowernumber | amount| amountoutstanding | date  
| description|
+-++---+---+++
|  10 |  1 |  6.00 |  3.00 | 2015-08-03
| test 5 |
|  11 |  1 |  3.00 |  0.00 | 2015-08-03
|  partial payment   |
+-++---+---+++

If we run cleanup_database.pl with a --fees 20, accountlines_id 11 will be
removed (0.00 amountoutstanding, date < 2015-08-13). but accountlines_id 10
won't be removed, because 3.00 amountoutstanding > 0. The borrower's
balance will remain at 3.00, (rather than the original 6.00), but the payment
record won't be there.

There's no way around this -- accountlines doesn't provide a way to determine
what a credit or debit was applied to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #12 from Barton Chittenden  ---
Created attachment 42246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42246=edit
[SIGNED-OFF] Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #10 from Barton Chittenden  ---
Created attachment 42244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42244=edit
[SIGNED-OFF] Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #11 from Barton Chittenden  ---
Created attachment 42245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42245=edit
[SIGNED-OFF] Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #41086|0   |1
is obsolete||
  Attachment #41087|0   |1
is obsolete||
  Attachment #41088|0   |1
is obsolete||
  Attachment #42242|0   |1
is obsolete||

--- Comment #9 from Barton Chittenden  ---
Created attachment 42243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42243=edit
[SIGNED-OFF] Add function purge_zero_balance_fees to C4/Accounts.pm

http://bugs.koha-community.org/show_bug.cgi?id=14402

Signed-off-by: Nancy Keener 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #8 from Barton Chittenden  ---
Created attachment 42242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42242=edit
Make purge_zero_balance_fees() delete fees with NULL balance.

Also, add notes to perldocs and usage that payments and
credits are not linked to fines and may be deleted
independently of the associated fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden  changed:

   What|Removed |Added

 CC||nkee...@washoecounty.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #6 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 41088
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41088action=edit
Add option --fees to /misc/cronjobs/cleanup_database.pl

This will call C4::Accounts::purge_zero_balance_fees to remove all rows
from accountlines which have 0 balance, and are more than DAYS old.

Test plan:

  Run: t/db_dependent/Accounts.t

If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl
should act as documented, because it is a straight pass-through to
C4::Accounts::purge_zero_balance_fees().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #5 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 41087
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41087action=edit
Add unit tests for purge_zero_balance_fees()

The function C4::Accounts::purge_zero_balance_fees() should delete rows
in accountlines where amountoutstanding is 0 and accountlines.date is
less than the current date minus '$days', i.e a number of days passed
to the function. Tests were added to prove the following:

* accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE.
  The accountlines row should not be deleted. This is merely a sanity check,
  because difference between today's date and the fee date cannot be
  greater than $days.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0
* accountlines.amountoutstanding is 0, and date is set to $days - 1
  days ago. The accountlines row should not be deleted.
* accountlines.amountoutstanding is 0, and date is set to $days
  days ago.  the accountlines row should not be deleted, because
  the difference must be *greater* than $days.
* accountlines.amountoutstanding is 0, and date is set to $days + 1
  days ago. The accountlines row *will* be deleted in this case.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding  0.
  (3 tests). The accountlines row will never be deleted, because
  amountoutstanding is not 0.
* 'Before', 'On' and 'After' tests for accountlines.amountoutstanding  0.
  (3 testes) This tests credits. Again, the accountlines row will never
  be deleted, because amountoutstanding is not 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #41043|0   |1
is obsolete||

--- Comment #4 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 41086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41086action=edit
Add function purge_zero_balance_fees to C4/Accounts.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Katrin Fischer from comment #1)
 Hm, this would need good testing. I think you also need to make sure there
 is no problem with the way credits work. But it would be good to have!

Credits have a negative amount and amountoutstanding, so the query would
definitely not affect credits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

--- Comment #2 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 41043
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41043action=edit
Add --fees option to cleanup_database.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, this would need good testing. I think you also need to make sure there is
no problem with the way credits work. But it would be good to have!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |bar...@bywatersolutions.com
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/