[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #41633|0   |1
is obsolete||
  Attachment #43018|0   |1
is obsolete||
  Attachment #43019|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 43157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43157=edit
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as
ISBN

Test plan (requires Baker and Taylor cover images to be set up and enabled):
  1. Create a record with an ISBN that does not have a cover and a UPC
 that does. 141985934X/085391174929 is one set that works well.
  2. Verify that the record shows up as "No image available" in the
 following OPAC locations: shelf browser, reviews, lists, search and
 reading record. This will require adding reviews/checkouts/etc. for
 the record in question.
  3. Apply patch.
  4. Check the locations again, and verify that the record now has a
 valid cover image.

Signed-off-by: Alexis Rodegerdts 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #11 from Jonathan Druart  
---
Created attachment 43158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43158=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc

Signed-off-by: Alexis Rodegerdts 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #12 from Jonathan Druart  
---
Created attachment 43159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43159=edit
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to
GetNormalizedUPC

Signed-off-by: Alexis Rodegerdts 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #42253|0   |1
is obsolete||

--- Comment #8 from Jesse Weaver  ---
Created attachment 43018
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43018=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc

Signed-off-by: Alexis Rodegerdts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

   What|Removed |Added

  Attachment #42547|0   |1
is obsolete||

--- Comment #9 from Jesse Weaver  ---
Created attachment 43019
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43019=edit
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to
GetNormalizedUPC

Signed-off-by: Alexis Rodegerdts 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #7 from Jonathan Druart  
---
Jesse, since I cannot test the patch, I would like to get a signoff on the 2
last patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #6 from Jesse Weaver  ---
Created attachment 42547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42547=edit
Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to
GetNormalizedUPC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #5 from Jonathan Druart  
---
Jesse,
I cannot test this patch, I don't have a B account.
But looking at the code I am wondering if there is not another occurrence to
update:

opac-user.tt l.414
https://[% BakerTaylorBookstoreURL |html %][% OVERDUE.normalized_isbn
%]">

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #4 from Jesse Weaver  ---
Created attachment 42253
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42253=edit
Bug 14607: (QA followup) Fix typo in shelfbrowser.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #3 from Jonathan Druart  
---
Comment on attachment 41633
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633
Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as
ISBN

Review of attachment 41633:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14607=41633)
-

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/shelfbrowser.inc
@@ +58,4 @@
> class="[% coce_id %]" id="coce-thumbnail-preview-[% coce_id %]">
>  [% END %]
>  [% IF ( BakerTaylorEnabled ) %]
> +[% bt_id = ( item.browser_normalized_upc 
> || item.browser_normalized_upc ) %]

This does not make any sense :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver jwea...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver jwea...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #41393|0   |1
is obsolete||

--- Comment #2 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 41633
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633action=edit
Bug 14607: Baker  Taylor cover images should be accessible by UPC as well as
ISBN

Test plan (requires Baker and Taylor cover images to be set up and enabled):
  1. Create a record with an ISBN that does not have a cover and a UPC
 that does. 141985934X/085391174929 is one set that works well.
  2. Verify that the record shows up as No image available in the
 following OPAC locations: shelf browser, reviews, lists, search and
 reading record. This will require adding reviews/checkouts/etc. for
 the record in question.
  3. Apply patch.
  4. Check the locations again, and verify that the record now has a
 valid cover image.

Signed-off-by: Alexis Rodegerdts arodeger...@wallawallawa.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

--- Comment #1 from Jesse Weaver jwea...@bywatersolutions.com ---
Created attachment 41393
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41393action=edit
Bug 14607: Baker  Taylor cover images should be accessible by UPC as well as
ISBN

Test plan (requires Baker and Taylor cover images to be set up and enabled):
  1. Create a record with an ISBN that does not have a cover and a UPC
 that does. 141985934X/085391174929 is one set that works well.
  2. Verify that the record shows up as No image available in the
 following OPAC locations: shelf browser, reviews, lists, search and
 reading record. This will require adding reviews/checkouts/etc. for
 the record in question.
  3. Apply patch.
  4. Check the locations again, and verify that the record now has a
 valid cover image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14607] Baker Taylor cover images should be accessible by UPC as well as ISBN

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607

Jesse Weaver jwea...@bywatersolutions.com changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/