[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #56 from Liz Rea  ---
Pushed to 3.18.13, and released.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

 CC||moli...@mubs.ac.ug

--- Comment #55 from Nick Clemens  ---
*** Bug 15393 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #54 from Barton Chittenden  ---
I'm wondering if this can get pushed into 3.18?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15224


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15224
[Bug 15224] Typo: Leave empty to add via item search (itemnunber).
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43107|0   |1
is obsolete||
  Attachment #43108|0   |1
is obsolete||
  Attachment #43109|0   |1
is obsolete||

--- Comment #53 from Nick Clemens  ---
Created attachment 44663
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44663=edit
[3.18.x rewrite] Bug 14739 - Add several patrons to a new batch will create a
new batch per patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

Signed-off-by: Barton Chittenden 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Liz Rea  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #52 from Liz Rea  ---
This change might require documentation updates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #51 from Liz Rea  ---
Hi,

If you feel like it, a version of this for 3.18 would be pretty nice, as this
one doesn't apply cleanly.

(Maybe I'll have a look, but don't count on it!)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #50 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #49 from Jonathan Druart  
---
Created attachment 43109
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43109=edit
Bug 14739: Adapt wording in breadcrumbs if a new batch is created

Don't display "Manage batch number 0" but "Create new batch"

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #48 from Jonathan Druart  
---
Created attachment 43108
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43108=edit
Bug 14739: Fix plack compatibility

perlcritic raised "Declare variables outside of the condition"

Works as expected
Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43062|0   |1
is obsolete||
  Attachment #43063|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart  
---
Created attachment 43107
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43107=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

Signed-off-by: Barton Chittenden 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43040|0   |1
is obsolete||

--- Comment #40 from Josef Moravec  ---
Created attachment 43060
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43060=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

Signed-off-by: Barton Chittenden 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43061|0   |1
is obsolete||

--- Comment #45 from Josef Moravec  ---
Created attachment 43063
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43063=edit
Bug 14739: Fix plack compatibility

perlcritic raised "Declare variables outside of the condition"

Works as expected
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #46 from Josef Moravec  ---
Is that better? I am sorry for this inconvenience...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #37 from Jonathan Druart  
---
There is something wrong in the first patch
 59 my @item_numbers; #= $cgi->param('item_number') if
$cgi->param('item_number');

Could someone re-upload a valid patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #43 from Jonathan Druart  
---
>From the first patch:
-my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef;
+my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0;

>From the second patch:
-my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0;
+my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef;

Initially my patch (the second one) didn't modify this line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43052|0   |1
is obsolete||

--- Comment #41 from Josef Moravec  ---
Created attachment 43061
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43061=edit
Bug 14739: Fix plack compatibility

perlcritic raised "Declare variables outside of the condition"

Works as expected
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #42 from Josef Moravec  ---
I rebased the patches in my local branch, could you please check if it's OK?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43060|0   |1
is obsolete||

--- Comment #44 from Josef Moravec  ---
Created attachment 43062
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43062=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

Signed-off-by: Barton Chittenden 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43040|0   |1
is obsolete||

--- Comment #35 from Josef Moravec  ---
Created attachment 43052
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43052=edit
[SIGNED-OFF] Bug 14739: Fix plack compatibility

perlcritic raised "Declare variables outside of the condition"

Works as expected
Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #36 from Josef Moravec  ---
It works like a charm ;) 

Thank you Jonathan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #42474|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43050|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #38 from Josef Moravec  ---
Sorry, I did a mistake with obsoleting patches, now it should be OK, could you
try it again please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #43040|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

  Attachment #42474|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #33 from Jonathan Druart  
---
Created attachment 43050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43050=edit
Bug 14739: Fix plack compatibility

perlcritic raised "Declare variables outside of the condition"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #34 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #32)
> Now I now where is the difference. It's plack!
> 
> When I stop using plack, everything works as expected.

hehe, thanks Josef!
Here is a patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #39 from Jonathan Druart  
---
The second patch does not apply anymore, but maybe it was not based on the good
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #25 from Josef Moravec  ---
I tried it on non-empty table, but have the same issue... I am not able to
figure out where is the problem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #22 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #21)
> I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try
> it on another machine with MySQL tomorow...

Using MariaDB I don't get the issue you have described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #23 from Josef Moravec  ---
Hm, on another machine everything works perfect... So probably some problem
with my specific data, or something on that one VM. So please, ignore me ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #24 from Jonathan Druart  
---
Josef, if you are still able to reproduce the issue, with the last patches
against master, I think we should try to understand what is the problem :)
Could you confirm you got the issue even with a non-empty creator_batches
table? I have not tried with en empty table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #26 from Barton Chittenden  ---
Getting

Software error:

Can't call method "get_attr" without a package or object reference at
/home/barton/kohaclone/patroncards/edit-batch.pl line 125.

To re-create:

1/ go to Home › Tools › Patron card creator › Manage card Batches
(cgi-bin/koha/patroncards/manage.pl?card_element=batch)
2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new)
3/ click 'Add items' (opens new window --
cgi-bin/koha/patroncards/add_user_search.pl)
4/ click 'Search' to show all patrons (I don't have that many)
5/ click 'Add' on first patron -> Software error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #27 from Barton Chittenden  ---
(In reply to Barton Chittenden from comment #26)
> Getting
> 
> Software error:
> 
> Can't call method "get_attr" without a package or object reference at
> /home/barton/kohaclone/patroncards/edit-batch.pl line 125.
> 
> To re-create:
> 
> 1/ go to Home › Tools › Patron card creator › Manage card Batches
> (cgi-bin/koha/patroncards/manage.pl?card_element=batch)
> 2/ click 'New Bath' (cgi-bin/koha/patroncards/edit-batch.pl?op=new)
> 3/ click 'Add items' (opens new window --
> cgi-bin/koha/patroncards/add_user_search.pl)
> 4/ click 'Search' to show all patrons (I don't have that many)
> 5/ click 'Add' on first patron -> Software error.

This was user error on my part.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #42965|0   |1
is obsolete||

--- Comment #28 from Nick Clemens  ---
Created attachment 43034
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43034=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43034|0   |1
is obsolete||

--- Comment #29 from Nick Clemens  ---
Created attachment 43038
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43038=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #43038|0   |1
is obsolete||

--- Comment #30 from Barton Chittenden  ---
Created attachment 43040
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43040=edit
[SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a new
batch per patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

Signed-off-by: Barton Chittenden 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #31 from Barton Chittenden  ---
(In reply to Barton Chittenden from comment #30)
> Created attachment 43040 [details] [review]
> [SIGNED-OFF] Bug 14739 - Add several patrons to a new batch will create a
> new batch per patron added
> 
> This patch changes the functionality of adding patrons to patroncard
> batches.  Instead of using only the patron search, there is now a textarea
> which can either be manually populated with borrowernumbers, or can be
> populated using the patron-search
> 
> To test:
> 1 - Create a new patron batch
> 2 - Click the add items button, if there is no data in the borrowrnumber
> form you should get a popup
> 3 - Add items to batch using the popup, borrowernumbers should populate to
> the form
> 4 - Click add items again and items should be added to a new batch
> 5 - Create a new batch
> 6 - Manually enter invalid borrowernumbers to the form
> 7 - Click add items, batch should return empty
> 8 - Manually enter valid borrowernumber
> 9 - Click add items, batch should be updated
> 10 - Edit an existing batch and confirm add items works as above
> 11 - Create a new label batch
> 12 - Click add items with no data, popup item search should appear
> 13 - Adding items by checking boxes or using 'Add' button - they should
> populate the text box on the edit batch page
> 14 - When adding using form the 'Enter by itemnumber' button should be
> marked automatically
> 15 - Submit items and confirm they are added to batch
> 16 - Create a new batch, enter by barcode manually and check 'Enter by
> itemnumber"
> 17 - Click add items, no items should be added
> 18 - Repopulate form with barcodes, check 'Enter by barcode'
> 19 - Click add items, items should be added correctly
> 20 - Test various combinations of radio buttons and numbers and using form
> or not
> 
> Signed-off-by: Barton Chittenden 

I've tested without error, and I'm signing off, but I know that Jonathan wants
to see if we can replicate the errors that Josef Moravec was seeing, so I'm not
going to set the status of the bug as a whole to 'Signed Off'. This is simply
saying 'the patch works for me'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #32 from Josef Moravec  ---
Now I now where is the difference. It's plack!

When I stop using plack, everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #21 from Josef Moravec  ---
I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try it
on another machine with MySQL tomorow...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #20 from Nick Clemens  ---
(In reply to Josef Moravec from comment #19)
> I'm sorry but I still have problems 
> 

I tested again in my VM and on a sandbox and cannot recreate.  What environment
are you testing in?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #19 from Josef Moravec  ---
I'm sorry but I still have problems 

Try this:

1. Go to patron label creator -> manage batches
2. Remove all batches (just to be sure we have the same environment)
3. Click on "new batch"
4. Click on "add items" and pick 5 patrons
5. Close the patron picker window and click on "add items" again, the batch is
created as expected
6. Go back to manage batches
7. Click on "new batch"
8. insert one right borrowernumber and one wrong borrowernumber
9. click on "add items"
10. the one right is added, but the five patrons from previous batch is added
too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #42623|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 42965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42965=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron search, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popup
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items should be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #18 from Nick Clemens  ---
(In reply to Josef Moravec from comment #16)
> I have problem on numbers 6-7 of test plan, 

I couldn't recreate, but I added a safeguard against there being items saved in
batch 0 which could have caused the error.  Can you retest and let me know if
it happens again?

I also cleaned up some debug code I found left behind.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #16 from Josef Moravec  ---
I have problem on numbers 6-7 of test plan, when I entered invalid
borrowernumbers, the new batch was created, but it wasn't empty, but there are
exactly the same borrowers as in previous batch... they were somehow copied
from the first batch to second one...

Then I tried to delete four items of this batch, with success, then I tried to
add valid number and it was added ok, but again all items from first batch was
added too...

on label batches this works correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #42474|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 42623
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42623=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron searhc, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popupo
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items hsoul;d be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above
11 - Create a new label batch
12 - Click add items with no data, popup item search should appear
13 - Adding items by checking boxes or using 'Add' button - they should
populate the text box on the edit batch page
14 - When adding using form the 'Enter by itemnumber' button should be marked
automatically
15 - Submit items and confirm they are added to batch
16 - Create a new batch, enter by barcode manually and check 'Enter by
itemnumber"
17 - Click add items, no items should be added
18 - Repopulate form with barcodes, check 'Enter by barcode'
19 - Click add items, items should be added correctly
20 - Test various combinations of radio buttons and numbers and using form or
not

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #14 from Jonathan Druart  
---
Why do you use "barcode" when manipulating "borrowernumber"?

Did you note that the same issue appears for labels?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

 CC||heinrich.ha...@email.de

--- Comment #10 from Nick Clemens  ---
*** Bug 14800 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

  Attachment #42421|0   |1
is obsolete||

--- Comment #9 from Nick Clemens  ---
Created attachment 42473
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42473=edit
Bug 14739 - Add several patrons to a new batch will create a new batch per
patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron searhc, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popupo
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items hsoul;d be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #11 from Marc Véron  ---
Created attachment 42474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42474=edit
[Signed-off] Bug 14739 - Add several patrons to a new batch will create a new
batch per patron added

This patch changes the functionality of adding patrons to patroncard batches. 
Instead of using only the patron searhc, there is now a textarea which can
either be manually populated with borrowernumbers, or can be populated using
the patron-search

To test:
1 - Create a new patron batch
2 - Click the add items button, if there is no data in the borrowrnumber form
you should get a popupo
3 - Add items to batch using the popup, borrowernumbers should populate to the
form
4 - Click add items again and items hsoul;d be added to a new batch
5 - Create a new batch
6 - Manually enter invalid borrowernumbers to the form
7 - Click add items, batch should return empty
8 - Manually enter valid borrowernumber
9 - Click add items, batch should be updated
10 - Edit an existing batch and confirm add items works as above

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42473|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12911
   Priority|P5 - low|P3
 Depends on|12911   |
Version|unspecified |master


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911
[Bug 12911] batch_id for new label batches can be assigned to several batches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14131

--- Comment #12 from Marc Véron  ---
BTW: A couple of months ago, I implemented a possibility to print patron cards
from patronlists. Patron lists are easier to create and to handle.

See Bug 14131 (Needs sign-off)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #13 from Marc Véron  ---
*** Bug 14123 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #8 from bondiurbano  ---
Created attachment 42445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42445=edit
Selection links are missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

bondiurbano  changed:

   What|Removed |Added

 CC||cost...@gmail.com

--- Comment #7 from bondiurbano  ---
Also "Select", "Select all", "Select none" checkbox and links are missing. See
attached image.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #6 from Nick Clemens  ---
Created attachment 42421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42421=edit
Obsoleted patch copied from bug 12911

I tried my best to find a workaround on top of my patches, but couldn't make
anything work.  Requiring items to be added before assigning a batch number
meant I would have needed to create a placeholder item to get an id.  Thomas'
patches on 12911 did just that.  You can push up the batch number by creating a
new batch and never adding to it, but that seems okay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #4 from Nick Clemens n...@quecheelibrary.org ---
I tried an easy fix (update batch_id after adding an item), but if a user
clicks on several patrons to add without waiting for background page to reload
the batch_id doesn't have time to update.

Barton said he is taking a look today and I will touch base with him when I get
in this afternoon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

--- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
I think the easier and cleaner way to do would be to create (and so get an id)
the batch when the Add items button is clicked.

It's not perfect, but I don't see another way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Heather Braum hbr...@nekls.org changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Depends on||12911

--- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Introduced by

commit 2dd97f26c1e72bc35e29b1afd1fc38d301c48e9e
Bug 12911: batch_id for new labels batches can be asssigned to several
batches


exists since 3.18.7.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911
[Bug 12911] batch_id for new label batches can be assigned to several batches
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |n...@quecheelibrary.org
   |ommunity.org|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

Summary|Regression on adding|Add several patrons to a
   |several patrons to a new|new batch will create a new
   |batch   |batch per patron added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Nick Clemens n...@quecheelibrary.org ---
*** Bug 14700 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/