https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Martin Renvoize changed:
What|Removed |Added
Blocks|15276 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Martin Renvoize changed:
What|Removed |Added
Blocks||34472
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||26663
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Katrin Fischer changed:
What|Removed |Added
Blocks||17976
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Indranil Das Gupta changed:
What|Removed |Added
CC||indr...@l2c2.co.in
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Lisa changed:
What|Removed |Added
CC||l...@hchlibrary.org
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||17960
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||17246
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #61 from Jonathan Druart
---
(In reply to Petter Goksøyr Åsen from comment #59)
> I seem to get a lot of failures after this patch.
>
> I can't get HOLD_SLIP to render without error:
> SQL::Abstract::puke(): [SQL::Abstr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #60 from Petter Goksøyr Åsen ---
I managed to fix it by changing the config hash in _get_tt_params:
> git diff
diff --git a/C4/Letters.pm b/C4/Letters.pm
index 737c8cd..c1ef404 100644
--- a/C4/Letters.pm
+++ b/C4/Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Petter Goksøyr Åsen changed:
What|Removed |Added
CC||boutrosboutrosboutros@
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Katrin Fischer changed:
What|Removed |Added
Blocks||16985
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #58 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #57)
> Kyle, bug 16929 has been introduced by these patches.
> Actually it seems that the changes made to Koha::Patron::Modification[s]
> were not inte
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #57 from Jonathan Druart
---
Kyle, bug 16929 has been introduced by these patches.
Actually it seems that the changes made to Koha::Patron::Modification[s] were
not intended. Could you confirm?
--
You are receiving thi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||16960
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||16942
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #56 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #55)
> Pushed to master for 16.11!
>
> (In reply to Jonathan Druart from comment #54)
> > Kyle, I have marked this patchset as Passed QA but we still ne
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||16883
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #54 from Jonathan Druart
---
Kyle, I have marked this patchset as Passed QA but we still need a patch to
take into account the 3 following tables: aqorders, aqbooksellers, biblioitems.
I think this could be done on anoth
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #50 from Jonathan Druart
---
Created attachment 52925
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52925&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
Signed-off-by: Sean McGarvey
Signed-of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #52 from Jonathan Druart
---
Created attachment 52927
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52927&action=edit
Bug 14757 [QA Followup] - Don't overload new for Modifications
Signed-off-by: Jon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #51 from Jonathan Druart
---
Created attachment 52926
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52926&action=edit
Bug 14757: Add tests for new modules
Signed-off-by: Jonathan Druart
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #53 from Jonathan Druart
---
Created attachment 52928
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52928&action=edit
Bug 14757: Remove obsolete occurrence of is_tt
Signed-off-by: Jonathan Druart
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Attachment #52805|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #48 from Kyle M Hall ---
Created attachment 52895
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52895&action=edit
Bug 14757 [QA Followup] - Don't overload new for Modifications
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #47 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #46 from Jonathan Druart
---
Kyle,
I have squashed some patches (they failed qa tools: FAIL
Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added
and deleted in the same patchset) and added tests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #44 from Jonathan Druart
---
Created attachment 52806
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52806&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
Signed-off-by: Sean McGarvey
--
You a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #45 from Jonathan Druart
---
Created attachment 52807
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52807&action=edit
Bug 14757: Add tests for new modules
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Attachment #52758|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Katrin Fischer changed:
What|Removed |Added
Version|unspecified |master
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #40 from Kyle M Hall ---
Created attachment 52759
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52759&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
Signed-off-by: Sean McGarvey
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #41 from Kyle M Hall ---
Created attachment 52760
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52760&action=edit
Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects
Signed-off-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #42 from Kyle M Hall ---
Created attachment 52761
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52761&action=edit
Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron
Sign
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #48806|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment #
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #37 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #36)
> I don't need anything else (for bug 15705) apart from the patches from this
> bug report. But I think it would be good to agree on the next steps.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #36 from Jonathan Druart
---
I don't need anything else (for bug 15705) apart from the patches from this bug
report. But I think it would be good to agree on the next steps.
For instance, my note on comment 31 is still v
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #35 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #31)
> Kyle,
> Could you detail the plan for the dependent bugs please?
> You are adding a new pref and a new DB column (letter.is_tt) in this patch
> but
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #34 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #33)
> Is the status here correct? Should it be failed QA?
More or less the same, we need a new patch.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #33 from Katrin Fischer ---
Is the status here correct? Should it be failed QA?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Marc Véron changed:
What|Removed |Added
CC||ve...@veron.ch
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |ASSIGNED
--- Comment #32
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #31 from Jonathan Druart
---
Kyle,
Could you detail the plan for the dependent bugs please?
You are adding a new pref and a new DB column (letter.is_tt) in this patch but
they are not used in other patches.
We cannot upd
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Attachment #48620|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Attachment #48622|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Attachment #48805|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Attachment #48619|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Attachment #48621|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #25 from Kyle M Hall ---
Created attachment 48805
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48805&action=edit
Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||15969
Referenced Bugs:
http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #48498|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #23 from Kyle M Hall ---
Created attachment 48621
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48621&action=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a sy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #22 from Kyle M Hall ---
Created attachment 48620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48620&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #24 from Kyle M Hall ---
Created attachment 48622
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48622&action=edit
Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks|14758 |
Referenced Bugs:
https://b
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #20 from Kyle M Hall ---
Created attachment 48500
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48500&action=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a sy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #19 from Kyle M Hall ---
Created attachment 48499
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48499&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #47176|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #16 from Kyle M Hall ---
Created attachment 47865
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47865&action=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a sy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #47865|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #14 from Bob Birchall ---
(In reply to Kyle M Hall from comment #13)
> The current plan is to make this work with minimal or no changes! You can
> check out the mailing list thread for the on-going discussion.
For me, t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Nicole C. Engard changed:
What|Removed |Added
Blocks||10708
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #13 from Kyle M Hall ---
(In reply to Bob Birchall from comment #12)
> (In reply to Kyle M Hall from comment #0)
> > We should enable TT syntax for slips and notices. This could work side by
> > side with the existing syn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #12 from Bob Birchall ---
(In reply to Kyle M Hall from comment #0)
> We should enable TT syntax for slips and notices. This could work side by
> side with the existing syntax parser for a release or two before we
> offic
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Bob Birchall changed:
What|Removed |Added
CC||b...@calyx.net.au
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Blocks||15705
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #10 from Jonathan Druart
---
Comment on attachment 47176
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices
Review of attac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #9 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #0)
> We should enable TT syntax for slips and notices. This could work side by
> side with the existing syntax parser for a release or two before we
> of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||15280
Referenced Bugs:
http
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #8 from Kyle M Hall ---
Created attachment 47177
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47177&action=edit
Bug 14757 [QA Followup] - Add Unit Tests
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #47131|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receivi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #47123|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Attachment #45884|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #4 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #45325|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Component|Architecture, internals,|Notices
|and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
--- Comment #2 from Kyle M Hall ---
Created attachment 45325
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45325&action=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices
This bug is th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||15278
Referenced Bugs:
http:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||15277
Referenced Bugs:
http:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||15276
Referenced Bugs:
http:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Blocks||14758
Referenced Bugs:
http:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
Kyle M Hall changed:
What|Removed |Added
Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com
--
You
100 matches
Mail list logo
