[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #11 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #10)
> etc. is added correctly (or nothing would work). I can't think of any other
> fields right now that the import would change in the record.

Not change, but add. But I will look into the code soon.. and then we can be
sure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #9 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #7)
> 005 is a timestamp of the last change and the first positions of the leader
> that change are the record length - this change being caused by the other
> changes. 
> So I think Koha's current behaviour is correct and nothing needs to be
> changed on import. I think what we could do is catch an invalid itemtype
> code better, so it's easier to locate the problem.

What about the missing subfields/something? I don't know how much they will
have effect on how things work but I'll try to look into the code of the Edit
record feature and see if we should add those kind of things to this import
tool, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #10 from Katrin Fischer  ---
Which missing subfields? 999 information with bilbionumber/biblioitemnumber
etc. is added correctly (or nothing would work). I can't think of any other
fields right now that the import would change in the record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #12 from Joonas Kylmälä  ---
(In reply to Joonas Kylmälä from comment #11)
> (In reply to Katrin Fischer from comment #10)
> > etc. is added correctly (or nothing would work). I can't think of any other
> > fields right now that the import would change in the record.
> 
> Not change, but add. But I will look into the code soon.. and then we can be
> sure.

Ok. authorities.pl and addbiblio.pl does the missing subfield adding as I
understood by reading the code quickly. The code starts at line 590 in
addbiblio.pl. Katrin, do you know by that info if that is something we need?
(if not, why do we have it in addbiblio.pl and authorities.pl?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #15 from Tomás Cohen Arazi  ---
(In reply to Joonas Kylmälä from comment #2)
> So the above info adding doesn't happen in the stage-marc-import.pl script
> and it is wasted time to go each and one thousand records by hand and just
> click save on them

Just for yupi to notice, Joonas, that's what touch_all_biblios.pl is for ☺

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #14 from Joonas Kylmälä  ---
Looks like this is then resolved. I'll open a new report for the invalid item
type thingie.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #13 from Katrin Fischer  ---
To me the code looks to be mostly about building the cataloguing form correctly
- I can't spot any elements being added. I feel a bit like we are hunting
'ghosts' here, as there is no known problem to work from and reading all the
code will always turn up some/lots of question marks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #5 from Katrin Fischer  ---
Hm, this looks to me like the bug is not so much in the staged import, but in
the data - it looks like you might be importing with an itemtype code that is
not defined in your database (942$c). Once you open and save the record again,
the itemtype will probably be set to the first in the pull down of available
codes... and that's why the checkout works after. Could this be possible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #7 from Katrin Fischer  ---
005 is a timestamp of the last change and the first positions of the leader
that change are the record length - this change being caused by the other
changes. 
So I think Koha's current behaviour is correct and nothing needs to be changed
on import. I think what we could do is catch an invalid itemtype code better,
so it's easier to locate the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #4 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #3)
> Joonas, this is rather confusing me :) We use the staged imports a lot and
> have never run into problems like you describe. Could you show which
> elements were missing in your record?

Output from diff of MARCXML files:

...

-  00977cam a22003374a 4500
+  00961cam a22003374a 4500

...

-  20150831135648.0
+  20150831142850.0

...

-KI
-2013-08-26 00:00:00
+BK
+ddc

After those changes were made the bug 14755 didn't show up anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #6 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #5)
> Hm, this looks to me like the bug is not so much in the staged import, but
> in the data - it looks like you might be importing with an itemtype code
> that is not defined in your database (942$c). Once you open and save the
> record again, the itemtype will probably be set to the first in the pull
> down of available codes... and that's why the checkout works after. Could
> this be possible?

Adding an item type entry in Koha for code KI solved the problem indeed.

But I think the feature Edit biblio adds still some other data. So why not do
that already in import stage, because some data might be vital(?).

-  00977cam a22003374a 4500
+  00961cam a22003374a 4500

For example, should the line above be like that or is it enough that there is
the old line / is this some info which we really don't need but we just happen
to have?

And I got the picture from that Edit record feature, by quickly looking at the
code, that it also adds some missing subfields. So what if these imported
records don't have those subfields and it will cause some problems... (and then
the only fix would be go one by one through the imported records or fixing the
data some how)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

paxed  changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #8 from paxed  ---
(In reply to Joonas Kylmälä from comment #6)
> 
> -  00977cam a22003374a 4500
> +  00961cam a22003374a 4500
> 
> For example, should the line above be like that or is it enough that there
> is the old line / is this some info which we really don't need but we just
> happen to have?
> 

vink vink, Kansalliskirjastolta löytyy MARC21 suomeksi:
http://www.kansalliskirjasto.fi/extra/marc21/bib/000.htm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Can you describe the problem a bit more? What should be added/is missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Joonas Kylmälä  changed:

   What|Removed |Added

 Blocks||14755


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14755
[Bug 14755] Checking in gives error 500
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

--- Comment #3 from Katrin Fischer  ---
Joonas, this is rather confusing me :) We use the staged imports a lot and have
never run into problems like you describe. Could you show which elements were
missing in your record?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14762] Importing records doesn't add missing subelements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14762

Joonas Kylmälä  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14755

--- Comment #2 from Joonas Kylmälä  ---
Steps to reproduce the problem:

1. Have an imported biblio record (from maybe some other version of koha / with
some other library's details) which you haven't edited yet but only created a
new item for it.
2. Go to the biblio records detail view
3. Save the record by clicking Save->MARCXML
4. Click Edit->Record
5. Click Save
6. Save the record by clicking Save->MARCXML
7. Compare the output of the two files, for example with diff -u .
8. Notice that the latter file has changed its info / there is more info.

So the above info adding doesn't happen in the stage-marc-import.pl script and
it is wasted time to go each and one thousand records by hand and just click
save on them (you need to add this info or otherwise the bug 14755 appears).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/