[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED
   Assignee|jonathan.druart+koha@gmail. |koha-b...@lists.koha-commun
   |com |ity.org

--- Comment #11 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #10)
> In discussion from 2016? Did pass QA at the time. Stopped because we were
> going to merge borrowers and deletedborrowers..
> 
> Nice.

At the time it was in my priority list. It made sense to delay and think about
it. Feel free to resurrect this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #10 from Marcel de Rooy  ---
In discussion from 2016? Did pass QA at the time. Stopped because we were going
to merge borrowers and deletedborrowers..

Nice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #5 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Need to think about it (merge deletedborrowers with borrowers table).

You have been thinking for some time now :)
Separate from what we will do with deletedborrowers, I think this could be
pushed in the meantime.
Can we switch the status back ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #6 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > Need to think about it (merge deletedborrowers with borrowers table).
> 
> You have been thinking for some time now :)
> Separate from what we will do with deletedborrowers, I think this could be
> pushed in the meantime.
> Can we switch the status back ?

Not really: we have not discussed this topic during the last 2 dev meetings.
The choice we will make can have an impact:
If we decide not to care about the "history" (who did what [when]), we can move
forward with this patch.
Otherwise (deleted and active patrons in the same table, with an active/deleted
flag) we can keep this information. In this case, if this patch is pushed, we
will loose the info we want to keep (uploaded_files.owner will have been set to
NULL, no way to retrieve it).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #8 from Jonathan Druart  
---
This patch will set it to NULL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #9 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #8)
> This patch will set it to NULL

See what you mean now. The period between pushing both patch sets.
Note that we will probably already loose information in some tables now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #7 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)

> If we decide not to care about the "history" (who did what [when]), we can
> move forward with this patch.
> Otherwise (deleted and active patrons in the same table, with an
> active/deleted flag) we can keep this information. In this case, if this
> patch is pushed, we will loose the info we want to keep
> (uploaded_files.owner will have been set to NULL, no way to retrieve it).

Not sure if I understand what you mean.
If you have all patrons in the same table, this means that you do not delete
the patron but just set a flag. In that case the FK constraint does nothing.
So, why do you say that it is set to NULL?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #4 from Jonathan Druart  
---
Need to think about it (merge deletedborrowers with borrowers table).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #46759|0   |1
is obsolete||

--- Comment #3 from Marcel de Rooy  ---
Created attachment 47157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47157=edit
Bug 14849: Add foreign key on uploaded_files.owner

uploaded_files.owner refers to a borrowernumber, the DB structure should
reflect this constraint.

Test plan:
0/ Do not execute the update DB entry
1/ Add a new patron
2/ Use this patron to upload a new file
3/ In the uploaded_files you should see that the owner value is the
borrowernumber of the newly created patron
4/ Execute the DB entry
5/ The uploaded_files.owner value should have been set to NULL
6/ Repeat 1, 2 and 3
7/ Delete the patron
5/ The uploaded_files.owner value should have been set to NULL

Signed-off-by: Chris Cormack 

Signed-off-by: Marcel de Rooy 
The test plan seems to miss one step: 3b Delete the patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Chris Cormack  changed:

   What|Removed |Added

  Attachment #46589|0   |1
is obsolete||

--- Comment #2 from Chris Cormack  ---
Created attachment 46759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46759=edit
Bug 14849: Add foreign key on uploaded_files.owner

uploaded_files.owner refers to a borrowernumber, the DB structure should
reflect this constraint.

Test plan:
0/ Do not execute the update DB entry
1/ Add a new patron
2/ Use this patron to upload a new file
3/ In the uploaded_files you should see that the owner value is the
borrowernumber of the newly created patron
4/ Execute the DB entry
5/ The uploaded_files.owner value should have been set to NULL
6/ Repeat 1, 2 and 3
7/ Delete the patron
5/ The uploaded_files.owner value should have been set to NULL

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||5334


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334
[Bug 5334] add explicit foreign key constraints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

--- Comment #1 from Jonathan Druart  
---
Created attachment 46589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46589=edit
Bug 14849: Add foreign key on uploaded_files.owner

uploaded_files.owner refers to a borrowernumber, the DB structure should
reflect this constraint.

Test plan:
0/ Do not execute the update DB entry
1/ Add a new patron
2/ Use this patron to upload a new file
3/ In the uploaded_files you should see that the owner value is the
borrowernumber of the newly created patron
4/ Execute the DB entry
5/ The uploaded_files.owner value should have been set to NULL
6/ Repeat 1, 2 and 3
7/ Delete the patron
5/ The uploaded_files.owner value should have been set to NULL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14294

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14849] Owner should be FK in uploaded_files

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14849

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14321

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/