[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #36 from Lucas Gass  ---
enhancement will not be backported to 20.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #35 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #34 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #33)
> Yes, but we insert the rule during the update process.
> 
> If we create the rule with the value in the syspref I think we could remove
> the it. Is it worth it?

Hm ist could work, but I haven't fully worked out the structure yet, but I
think there is a functional difference with your suggestion and the current
implementation:

The * * * rule shoudl only be applied if there is no rule that is more
specific.

So, when you have:

itemtype a - patroncategory b ... high holds value left empty.

Current suggestion:
- the pref value will be used as a fallback.

Your suggestion:
- I am not sure. I believe that it won't fall back but use the "empty" and that
it will need to have some meaning, like "0" or "inactive"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #33 from Jonathan Druart  
---
Yes, but we insert the rule during the update process.

If we create the rule with the value in the syspref I think we could remove the
it. Is it worth it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #32 from Katrin Fischer  ---
It's a fallback when no other value is set in the circulation conditions:

+if ( defined($rule) && $rule->rule_value ne '' ){
+# overrides decreaseLoanHighHoldsDuration syspref
...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #31 from Jonathan Druart  
---
As we are inserting the value into the default circulation rule, why do we keep
the syspref?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #30 from Jonathan Druart  
---
Created attachment 112936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112936=edit
Bug 14866: Trivial code simplification

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15523


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523
[Bug 15523] Move a number of sysprefs to circulation rules (Omnibus)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #29 from Jonathan Druart  
---
Please don't forget to describe what the new enhancement is supposed to add
when you write the commit message. The title and test plan are, most of the
time, not enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #28 from Katrin Fischer  ---
Created attachment 112226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112226=edit
Bug 14866: (QA follow-up) Add hint to system preferences

Adds a hint about the new configuration option to the existing
system preference sectoin.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #111938|0   |1
is obsolete||

--- Comment #27 from Katrin Fischer  ---
Created attachment 112225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112225=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 
Signed-off-by: Henry Bolshaw 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Henry Bolshaw  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #26 from Henry Bolshaw  ---
Thanks for clarifying Aleisha. I've tested and signed this off now. Apologies
for the duplicate sign offs, I was trying to sign off using git bz but couldn't
work out how to do it properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #111937|0   |1
is obsolete||

--- Comment #25 from Henry Bolshaw  ---
Created attachment 111938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111938=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 
Signed-off-by: Henry Bolshaw 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Henry Bolshaw  changed:

   What|Removed |Added

 Attachment #110441|0   |1
is obsolete||

--- Comment #24 from Henry Bolshaw  ---
Created attachment 111937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111937=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 
Signed-off-by: Henry Bolshaw 


Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #23 from Aleisha Amohia  ---
(In reply to Henry Bolshaw from comment #22)
> Hi Aleisha and Katrin, I'm a bit confused by the last two comments. Does
> this need to be signed off again? If so, can we test and sign off the
> current patch or should we wait for a new one?

Sorry for the confusion, I amended the patch to include the cosmetic changes
that Katrin asked for so there is no new patch coming. Since I didn't include
it as a follow-up like I should've this will need to be tested and signed off
again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Henry Bolshaw  changed:

   What|Removed |Added

 CC||bolsh...@parliament.uk

--- Comment #22 from Henry Bolshaw  ---
Hi Aleisha and Katrin, I'm a bit confused by the last two comments. Does this
need to be signed off again? If so, can we test and sign off the current patch
or should we wait for a new one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #21 from Aleisha Amohia  ---
Oops sorry I should've thought about that! Understand if this needs to get
signed off again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #20 from Katrin Fischer  ---
Hi Aleisha, as the requested changes were only "cosmetic" I'd be ok with
keeping this signed off, but was hoping for a separate patch as a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110224|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia  ---
Created attachment 110441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110441=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|ei...@sysmystic.com |alei...@catalyst.net.nz
 Status|Signed Off  |Failed QA

--- Comment #18 from Katrin Fischer  ---
The new rule is named "Decrease loan holds (day)" in the circulation rules. I
have some difficulty translating this in my head, even tho I know what is
meant. Could we improve the phrasing maybe?

Decreased loan period for high holds (day) ?

And instead of placing it last, we could place it after the "hard due date" so
it's closer to the other loan period parameters.

What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #17 from Lisette Scheer  ---
Worked great! Once again, I wasn't able to confirm tests because I was testing
on a sandbox. 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #110149|0   |1
is obsolete||

--- Comment #16 from ByWater Sandboxes  ---
Created attachment 110224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110224=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103427|0   |1
is obsolete||

--- Comment #15 from Aleisha Amohia  ---
Created attachment 110149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110149=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #14 from Lisette Scheer  ---
I've been informed that the <<< HEAD === >>> Bug 14866: Make high
holds work with different item types  is a sign that the patch doesn't cleanly
apply, so I'm changing the status to patch doesn't apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #13 from Lisette Scheer  ---
It works, but at the top of smart-rules.pl between the library selector and the
table there is a bunch of this: 
<<< HEAD === >>> Bug 14866: Make high holds work with different
item types <<< HEAD === >>> Bug 14866: Make high holds work with
different item types <<< HEAD === >>> Bug 14866: Make high holds
work with different item types <<< HEAD === >>> Bug 14866: Make
high holds work with different item types <<< HEAD === >>> Bug
14866: Make high holds work with different item types <<< HEAD ===
>>> Bug 14866: Make high holds work with different item types <<< HEAD
=== >>> Bug 14866: Make high holds work with different item types
<<< HEAD === >>> Bug 14866: Make high holds work with different
item types <<< HEAD === >>> Bug 14866: Make high holds work with
different item types <<< HEAD === >>> Bug 14866: Make high holds
work with different item types <<< HEAD === >>> Bug 14866: Make
high holds work with different item types <<< HEAD === >>> Bug
14866: Make high holds work with different item types <<< HEAD ===
>>> Bug 14866: Make high holds work with different item types <<< HEAD
=== >>> Bug 14866: Make high holds work with different item types
<<< HEAD === >>>


I also wasn't able to confirm tests because I was testing on a sandbox. 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103323|0   |1
is obsolete||

--- Comment #12 from Aleisha Amohia  ---
Created attachment 103427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103427=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

  Text to go in the||This patch adds a new
  release notes||circulation rule -
   ||decreaseloanholds - which
   ||will override the value set
   ||in the
   ||decreaseLoanHighHoldsDurati
   ||on system preference for
   ||specific item types, or
   ||patron categories, or
   ||branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #75861|0   |1
is obsolete||
  Attachment #75863|0   |1
is obsolete||

--- Comment #11 from Aleisha Amohia  ---
Created attachment 103323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103323=edit
Bug 14866: Make high holds work with different item types

To test:
1) Apply patch, update database, restart services
2) Enable decreaseLoanHighHolds sysprefs if not already active
3) Go to circulation rules and set a value under 'Decrease loan holds
(day)' that is DIFFERENT from decreaseLoanHighHoldsDuration
4) Check out an item with holds and confirm that the value from the rule
is used instead of the system preference
5) Confirm tests pass before and after the patch
t/db_dependent/DecreaseLoanHighHolds.t

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 CC||alei...@catalyst.net.nz
 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Maryse Simard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||maryse.sim...@inlibro.com

--- Comment #10 from Maryse Simard  ---
Patch doesn't apply

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14866: Make high holds work with different item types
.git/rebase-apply/patch:88: space before tab in indent.

.git/rebase-apply/patch:89: space before tab in indent.
[% END %]
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
M   admin/smart-rules.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
.git/rebase-apply/patch:88: space before tab in indent.

.git/rebase-apply/patch:89: space before tab in indent.
[% END %]
warning: 2 lines add whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Auto-merging admin/smart-rules.pl
CONFLICT (content): Merge conflict in admin/smart-rules.pl
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14866: Make high holds work with different item types

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #75862|0   |1
is obsolete||

--- Comment #9 from Aleisha Amohia  ---
Created attachment 75863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75863=edit
Bug 14866: [FOLLOW-UP]  Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #58324|0   |1
is obsolete||

--- Comment #8 from Aleisha Amohia  ---
Created attachment 75862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75862=edit
Bug 14866: Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #42751|0   |1
is obsolete||

--- Comment #7 from Aleisha Amohia  ---
Created attachment 75861
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75861=edit
Bug 14866: Make high holds work with different item types

This patch adds the possibility to set decreased loan periods for
high holds items in issuingrules via smart-rules.pl.

If a rule exist with a value set for a high holds item and the
decreaseLoanHighHolds syspref is active then the value of the rule
will be used instead of the syspref value.

To test:

1. Create testbranch, dump mysql as needed..

2. Apply patch

3. Update database
perl installer/data/mysql/updatedatabase.pl
misc/devel/update_dbix_class_files.pl --db_name=koha_instance
--db_user=koha_instance --db_passwd=thepassword

4. Enable decreaseLoanHighHolds sysprefs if not already active

5. Create rule for library/item in
http://your_staff_client/cgi-bin/koha/admin/smart-rules.pl
Set Decrease loan holds to your wanted value.

6. Check out an item with holds and see that the value from the rule is used
instead of the syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Patch no longer applies, can you please rebase?
It also seems to be missing tests?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14866: Make high holds work with different item types
.git/rebase-apply/patch:80: trailing whitespace.
[% rule.decreaseloanholds %]   
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
M   admin/smart-rules.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
.git/rebase-apply/patch:80: trailing whitespace.
[% rule.decreaseloanholds %]   
warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
Auto-merging admin/smart-rules.pl
CONFLICT (content): Merge conflict in admin/smart-rules.pl
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14866: Make high holds work with different item types
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-14866-Make-high-holds-work-with-different-item-RnFis7.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #5 from Aleisha Amohia  ---
Created attachment 58324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58324=edit
[FOLLOW-UP] Bug 14866: Make high holds work with different item types

This patch fixes merge conflicts, fixes the indentation of the table in
smart-rules.tt and uses Koha::IssuingRules->get_effective_issuing_rule.

Keep in mind - I am sure that when the original patch for this was
written (before get_effective_issuing_rule was used), it all worked
fine. I had to add an extra line of code in my patch to get this method
to work because it was fetching the WRONG circulation rule - one that
did not have decreaseloanholds defined. I don't know if it was my patch
that is broken or the get_effective_issuing_rule method that is not
fetching the 'most specific/relevant' rule.

Sponsored-by: Region Halland

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #4 from Marc Véron  ---
(In reply to Eivin Giske Skaaren from comment #3)
> Yes I guess it was ready back in 2015..
> I have not looked into what needs to be done now but I will contact Halland
> county library about if they want a rebase/rewrite now.
> 
> Are you interested in signing-off for this patch if it is fixed?

Yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #3 from Eivin Giske Skaaren  ---
Yes I guess it was ready back in 2015..
I have not looked into what needs to be done now but I will contact Halland
county library about if they want a rebase/rewrite now.

Are you interested in signing-off for this patch if it is fixed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
- Was this patch ready for signing off?

- It does no longer apply on current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Eivin Giske Skaaren  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ei...@sysmystic.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

Eivin Giske Skaaren  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14866] Make high holds work with different item types and number of open days

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14866

--- Comment #1 from Eivin Giske Skaaren  ---
Created attachment 42751
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42751=edit
Bug 14866: Make high holds work with different item types

This patch adds the possibility to set decreased loan periods for
high holds items in issuingrules via smart-rules.pl.

If a rule exist with a value set for a high holds item and the
decreaseLoanHighHolds syspref is active then the value of the rule
will be used instead of the syspref value.

To test:

1. Create testbranch, dump mysql as needed..

2. Apply patch

3. Update database
perl installer/data/mysql/updatedatabase.pl
misc/devel/update_dbix_class_files.pl --db_name=koha_instance
--db_user=koha_instance --db_passwd=thepassword

4. Enable decreaseLoanHighHolds sysprefs if not already active

5. Create rule for library/item in
http://your_staff_client/cgi-bin/koha/admin/smart-rules.pl
Set Decrease loan holds to your wanted value.

6. Check out an item with holds and see that the value from the rule is used
instead of the syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/