[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42964|0   |1
is obsolete||
  Attachment #43217|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 43220
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43220=edit
Bug 14924 - Remove C4::Dates from members/memberentry.pl

This patch removes C4::Dates from members/memberentry.pl

To test:
- Apply patch
- Add and edit patrons with and without birthdate as
  mandatory field (syspref BorrowerMandatoryField)
- Verify that dates (birtdate, registration, expiration)
  display and are stored correctly

Signed-off-by: Hector Castro 
Works as advertised. Tested with syspref BorrowerMandatoryField and
table borrowers.dateofbirth

Bug 14924 - (follow-up) Add date validation using eval

This patch adds a date validation (see comment #3).

To test:

- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as -00-00 or 32/01/1970. You can can
  copy/paste such strings to the date field, ignore the warning
  message and submit. Verify that after submit you get a message
  "Date of birth is invalid"
- Try the same with enrollement /expiry dates

Signed-off-by: Hector Castro 
Works as advertised. Tested with invalid dates.

Signed-off-by: Jonathan Druart 
Amended patch: I have splitted them to make them much more readable
(some lines were removed then added).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #12 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #11)
> Amended patch: I have splitted them to make them much more readable
> (some lines were removed then added).

s/splitted/squashed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #43065|0   |1
is obsolete||

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 43217
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43217=edit
[SIGNED-OFF]Bug 14924 - (follow-up) Add date validation using eval

This patch adds a date validation (see comment #3).

To test:

- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as -00-00 or 32/01/1970. You can can
  copy/paste such strings to the date field, ignore the warning
  message and submit. Verify that after submit you get a message
  "Date of birth is invalid"
- Try the same with enrollement /expiry dates

Signed-off-by: Hector Castro 
Works as advertised. Tested with invalid dates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Marc Véron  changed:

   What|Removed |Added

  Attachment #43028|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Marc Véron  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff
 Depends on|14936   |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
[Bug 14936] Add validation for date strings to Koha::DateUtils
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #9 from Marc Véron  ---
Created attachment 43065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43065=edit
Bug 14924 - (follow-up) Add date validation using eval

This patch adds a date validation (see comment #3).

To test:

- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as -00-00 or 32/01/1970. You can can
  copy/paste such strings to the date field, ignore the warning
  message and submit. Verify that after submit you get a message
  "Date of birth is invalid"
- Try the same with enrollement /expiry dates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #6 from Marc Véron  ---
Ok, I can make it explode if I enter -00-00 for date of birth:

---
Can't locate object method "ymd" via package "dateformat" (perhaps you forgot
to load "dateformat"?) at /usr/share/kohaclone/Koha/DateUtils.pm line 206.
---

I think we need a generic function in Koha::DateUtils to test a date string
against the 'dateformat' syspref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #7 from Jonathan Druart  
---
You can try with: 32/01/1970

Actually it will explode if the date is not correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Marc Véron  changed:

   What|Removed |Added

 Depends on||14936


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936
[Bug 14936] Add validation for date strings to Koha::DateUtils
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #8 from Marc Véron  ---
Created attachment 43028
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43028=edit
Bug 14924 - (follow-up) Add date validation

This patch adds a date validation (see comment #3).

To test:

- Make sure that you test on top of
  Bug 14936 (Add validation for date strings to Koha::DateUtils
- Apply patch
- Create a new user or edit an existing user
- Try valid dates for date of birth
- Try invalid dates as -00-00 or 32/01/1970. You can can
  copy/paste such strings to the date field, ignore the warning
  message and submit. Verify that after submit you get a message
  "Date of birth is invalid"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #5 from Jonathan Druart  
---
(In reply to Marc Véron from comment #4)
> Hi Jonathan,
> 
> I tried to enter an invalid date, but we have the date picker for this date
> - it seems no longer to be possible to enter invalid dates for the due date.
> 
> Or do I miss a way to enter an invalid date?

I have tried with the date of birth on creating/updating a patron.
You get a JS alert box but are able to submit the form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #3 from Jonathan Druart  
---
Comment on attachment 42964
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42964
[SIGNED-OFF]Bug 14924 - Remove C4::Dates from members/memberentry.pl

Review of attachment 42964:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14924=42964)
-

::: members/memberentry.pl
@@ +170,5 @@
>  foreach (qw(dateenrolled dateexpiry dateofbirth)) {
>  next unless exists $newdata{$_};
>  my $userdate = $newdata{$_} or next;
> +if ( $userdate ) {
> +$newdata{$_} = output_pref({ dt => dt_from_string( $userdate ), 
> dateformat => 'iso', dateonly => 1 });

You have to care of bad formatted dates, otherwise the user will get a software
error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #4 from Marc Véron  ---
Hi Jonathan,

I tried to enter an invalid date, but we have the date picker for this date -
it seems no longer to be possible to enter invalid dates for the due date.

Or do I miss a way to enter an invalid date?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Marc Véron  changed:

   What|Removed |Added

 Blocks||14870
   Assignee|gmcha...@gmail.com  |ve...@veron.ch
 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

--- Comment #1 from Marc Véron  ---
Created attachment 42953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42953=edit
Bug 14924 - Remove C4::Dates from members/memberentry.pl

This patch removes C4::Dates from members/memberentry.pl

To test:
- Apply patch
- Add and edit patrons with and without birthdate as
  mandatory field (syspref BorrowerMandatoryField)
- Verify that dates (birtdate, registration, expiration)
  display and are stored correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #42953|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 42964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42964=edit
[SIGNED-OFF]Bug 14924 - Remove C4::Dates from members/memberentry.pl

This patch removes C4::Dates from members/memberentry.pl

To test:
- Apply patch
- Add and edit patrons with and without birthdate as
  mandatory field (syspref BorrowerMandatoryField)
- Verify that dates (birtdate, registration, expiration)
  display and are stored correctly

Signed-off-by: Hector Castro 
Works as advertised. Tested with syspref BorrowerMandatoryField and
table borrowers.dateofbirth

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/