[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature adds a
  release notes||warning to the suggestions
   ||process to alert the user
   ||to the presence of an
   ||apparent holding that
   ||already satisfies the
   ||suggestion they are about
   ||to submit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|rel_20_05_target|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #61 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96261|0   |1
is obsolete||

--- Comment #60 from Nick Clemens  ---
Created attachment 96331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96331=edit
Bug 14973: Fix edit a suggestion and dup found

The find duplicate call must only be done when the suggestion is new. It
does not make sense to search for a duplicate when the suggestion
already exists.

This patch also fixes a side-effect:
- Create a suggestion using an existing biblio title
- Ignore the warning and save
- Edit again and save
=> BOOM on date

Template process failed: undef error - The given date (18/11/2019) does
not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm
line 168

The dates are not processed and so badly formatted when sent to the
template.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96260|0   |1
is obsolete||

--- Comment #59 from Nick Clemens  ---
Created attachment 96330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96330=edit
Bug 14973: Add missing filters in templates

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96258|0   |1
is obsolete||

--- Comment #57 from Nick Clemens  ---
Created attachment 96328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96328=edit
Bug 14973: Remove double textarea for notes

Certainly a bad merge conflict resolution (I am certainly the one to
blame).
However I do not understand where this "note" variable come from.

Signed-off-by: Lisette Scheer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96257|0   |1
is obsolete||

--- Comment #56 from Nick Clemens  ---
Created attachment 96327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96327=edit
Bug 14973: Do not skip validation step when submiting a suggestion - OPAC

Signed-off-by: Lisette Scheer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96259|0   |1
is obsolete||

--- Comment #58 from Nick Clemens  ---
Created attachment 96329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96329=edit
Bug 14973: Remove double declaration of suggestions_loop

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96255|0   |1
is obsolete||

--- Comment #54 from Nick Clemens  ---
Created attachment 96325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96325=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (opac
side)

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

Signed-off-by: Lisette Scheer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

  Attachment #96256|0   |1
is obsolete||

--- Comment #55 from Nick Clemens  ---
Created attachment 96326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96326=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (staff
side)

Signed-off-by: Lisette Scheer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #50 from Jonathan Druart  
---
Created attachment 96258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96258=edit
Bug 14973: Remove double textarea for notes

Certainly a bad merge conflict resolution (I am certainly the one to
blame).
However I do not understand where this "note" variable come from.

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #53 from Jonathan Druart  
---
Created attachment 96261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96261=edit
Bug 14973: Fix edit a suggestion and dup found

The find duplicate call must only be done when the suggestion is new. It
does not make sense to search for a duplicate when the suggestion
already exists.

This patch also fixes a side-effect:
- Create a suggestion using an existing biblio title
- Ignore the warning and save
- Edit again and save
=> BOOM on date

Template process failed: undef error - The given date (18/11/2019) does
not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm
line 168

The dates are not processed and so badly formatted when sent to the
template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #52 from Jonathan Druart  
---
Created attachment 96260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96260=edit
Bug 14973: Add missing filters in templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #49 from Jonathan Druart  
---
Created attachment 96257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96257=edit
Bug 14973: Do not skip validation step when submiting a suggestion - OPAC

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #48 from Jonathan Druart  
---
Created attachment 96256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96256=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (staff
side)

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #51 from Jonathan Druart  
---
Created attachment 96259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96259=edit
Bug 14973: Remove double declaration of suggestions_loop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94301|0   |1
is obsolete||
  Attachment #94302|0   |1
is obsolete||
  Attachment #94303|0   |1
is obsolete||
  Attachment #94304|0   |1
is obsolete||
  Attachment #95113|0   |1
is obsolete||
  Attachment #95114|0   |1
is obsolete||
  Attachment #95517|0   |1
is obsolete||

--- Comment #47 from Jonathan Druart  
---
Created attachment 96255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96255=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (opac
side)

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #46 from Martin Renvoize  ---
Hmm, might be worth taking a look at bug 23173 for some possible inspiration
here.. it add hooks to allow searching of various sources via plugins before
submitting an ILL request.. feels like a similar mechanism could be employed
here too and would go be perhaps a more flexible end result?

Just some food for thought.. it's still on my list to work through this patch
set anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23173

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #45 from Jonathan Druart  
---
Created attachment 95517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95517=edit
Bug 14973: Fix edit a suggestion and dup found

The find duplicate call must only be done when the suggestion is new. It
does not make sense to search for a duplicate when the suggestion
already exists.

This patch also fixes a side-effect:
- Create a suggestion using an existing biblio title
- Ignore the warning and save
- Edit again and save
=> BOOM on date

Template process failed: undef error - The given date (18/11/2019) does
not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm
line 168

The dates are not processed and so badly formatted when sent to the
template.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 CC||savitra.sir...@osslabs.biz

--- Comment #44 from Jonathan Druart  
---
*** Bug 6813 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|23854   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854
[Bug 23854] Cannot edit a suggestion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23854


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854
[Bug 23854] Cannot edit a suggestion
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Keywords||rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #43 from Séverine Queune  ---
Found an issue coming from this patch, when testing bug 14763 :
biblioitems.itemtypes is now  mandatory to edit a suggestion.
It seems an important data to map, so I don't think a modification of the
present code is needed, but maybe a warning should be clearly displayed in the
release note, and maybe Koha (About > System information ?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14963


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963
[Bug 14963] Ability to suggest purchase on existing catalogue record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #42 from Jonathan Druart  
---
Created attachment 95114
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95114=edit
Bug 14973: Add missing filters in templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #41 from Jonathan Druart  
---
Created attachment 95113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95113=edit
Bug 14973: Remove double declaration of suggestions_loop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #40 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #39)
> (In reply to Jonathan Druart from comment #38)
> > Séverine, this is how FindDuplicate works so far. If we want to improve its
> > behavior we should done it on a separate bug report. It is out of the scope
> > of this one.
> 
> Thank you Jonathan for the information.
> Except that point, the other behaviours were good, so ok to keep the "Signed
> off" status.
> About the opening of a new bug, can you do it ? I'm not sure I can correctly
> describe the problem.

It already exists actually :)
See bug 15248.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #39 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #38)
> Séverine, this is how FindDuplicate works so far. If we want to improve its
> behavior we should done it on a separate bug report. It is out of the scope
> of this one.

Thank you Jonathan for the information.
Except that point, the other behaviours were good, so ok to keep the "Signed
off" status.
About the opening of a new bug, can you do it ? I'm not sure I can correctly
describe the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #38 from Jonathan Druart  
---
Séverine, this is how FindDuplicate works so far. If we want to improve its
behavior we should done it on a separate bug report. It is out of the scope of
this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #37 from Séverine Queune  ---
Sorry, another example...
Filling "Ramsès : Le Temple des millions d'années" is a duplicate of the 2nd
volume for "Ramses" collection of Christian Jacq (sn=984), but the alert is
made for the the 5th volume "Ramsès : Sous l'acacia d'Occident" (sn=99)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #36 from Séverine Queune  ---
I have strange behaviours when the title I search for is not exactly the same
registered in Koha.
For example on BibLibre's sandbox http://pro.es5-koha.sandbox.biblibre.eu :

1) the 4th volume of "Lanfeust de Troy" is existing in Koha with title
"Lanfeust de Troy : Le paladin d'eckmül". The alert is correct when I use all
the different elements of this title. But if I only fill "Le paladin d'eckmül",
I have an alert leading to a bad biblio (sn=4 instead of sn=1976).

2) for the title "[Le ]Siècle des Lumières", if I fill as the title "Le siècle
des lumières" (which is certainly what patrons will do), the alert leads to the
same bad notice as for exemple 1 (sn=4 instead of sn=741) !

3) the detection of "L'amour fou" for "[L']Amour fou" is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Lisette Scheer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #35 from Lisette Scheer  ---
Works as expected. 
Very excited for this feature. 
I did notice that when checking the title it doesn't matter what the case of
the letters are but with author it does on both the patron and staff side. (ie
if the author is cataloged as Tyler, chris it won't warn if Tyler, Chris is
entered instead.) 
Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #94298|0   |1
is obsolete||

--- Comment #34 from ByWater Sandboxes  ---
Created attachment 94304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94304=edit
Bug 14973: Remove double textarea for notes

Certainly a bad merge conflict resolution (I am certainly the one to
blame).
However I do not understand where this "note" variable come from.

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #93141|0   |1
is obsolete||

--- Comment #31 from ByWater Sandboxes  ---
Created attachment 94301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94301=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (opac
side)

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #94297|0   |1
is obsolete||

--- Comment #33 from ByWater Sandboxes  ---
Created attachment 94303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94303=edit
Bug 14973: Do not skip validation step when submiting a suggestion - OPAC

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #93142|0   |1
is obsolete||

--- Comment #32 from ByWater Sandboxes  ---
Created attachment 94302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94302=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (staff
side)

Signed-off-by: Lisette Scheer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #30 from Jonathan Druart  
---
Created attachment 94298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94298=edit
Bug 14973: Remove double textarea for notes

Certainly a bad merge conflict resolution (I am certainly the one to
blame).
However I do not understand where this "note" variable come from.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alex.arn...@biblibre.com|jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Failed QA   |Needs Signoff

--- Comment #29 from Jonathan Druart  
---
There was indeed a bug at the OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #28 from Jonathan Druart  
---
Created attachment 94297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94297=edit
Bug 14973: Do not skip validation step when submiting a suggestion - OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #27 from Séverine Queune  ---
Sorry Jonathan, I tried with :
 - title only
 - title + author
 - title + author + isbn (and other informations)
but I never get a warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #26 from Jonathan Druart  
---
The patches have been rebased against master. It was a bit tricky but it seems
that they still work as expected.

I am with Alex here, we should not block this one because of FindDuplicate
behaviors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #25 from Jonathan Druart  
---
Created attachment 93142
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93142=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (staff
side)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #60877|0   |1
is obsolete||
  Attachment #60913|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  
---
Created attachment 93141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93141=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (opac
side)

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
  Change sponsored?|--- |Seeking developer

--- Comment #23 from Séverine Queune  ---
The BULAC (http://www.bulac.fr/) would like to sponsore this development.

Alex, did you work further on the patch ?

As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to
quote us for the development of such a feature or just ask for more information
is welcome to write to us: .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #22 from Alex Arnaud  ---
(In reply to Koha Team AMU from comment #21)
> Tested on the Biblibre sandbox n°3.
> 
> In the database : NOTRE DAME DE PARIS / Victor Hugo [Livres] (biblionumber :
> 974)
> 
> When we make a suggestion in low-case "notre dame de paris", no warning
> message, the suggestion is added.
> 
> When we make a suggestion in upper-case "NOTRE DAME DE PARIS", a warning
> message appears before validate.
> 
> It will be better if this patch is not case sensitive.

This feature use FindDuplicate function and i think the problem come from here.
So i agree that this is not a good match but this patch is not intended to
improve matching methods. As mentioned in comment 16, we should improve
findDuplicate in another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=6813

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #20 from Alex Arnaud  ---
Created attachment 60913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60913=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (staff
side)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #44334|0   |1
is obsolete||
  Attachment #44335|0   |1
is obsolete||

--- Comment #19 from Alex Arnaud  ---
Created attachment 60877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60877=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion (opac
side)

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Koha Team Lyon 3  changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #18 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #17)

> 2/ Should not we have the same behavior on the staff side?

This patch is about warning non librarian user. It can therefore be assumed
that librarians know which tools to use for finding a potential duplicate
record.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #17 from Jonathan Druart  
---
Alex,
1/ I think MarcRecordFromSuggestion is confusing. It does not take an existing
suggestion in parameter, and that's why you use the default framework to get
the marc fields. Either you rename it with something like
MarcRecordFromNewSuggestion, or you take into account that this suggestion can
already be linked to a record.

2/ Should not we have the same behavior on the staff side?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #16 from Paul Poulain  ---
I agree it's not super-powerfull, and I also agree with Alex about using
FindDuplicate.
The next step is probably to improve FindDuplicate. idea : using the matching
points system.
Opening a ticket for that now ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Paul Poulain  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15248

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #43193|0   |1
is obsolete||

--- Comment #10 from Alex Arnaud  ---
Created attachment 44319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44319=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #44091|0   |1
is obsolete||

--- Comment #11 from Alex Arnaud  ---
Created attachment 44320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44320=edit
Bug 14973 - Fix broken itemtypes list in opac-suggestions form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #12 from Alex Arnaud  ---
Nicole,

I have added the test plan to the commit message of the first commit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #44319|0   |1
is obsolete||

--- Comment #13 from Nicole C. Engard  ---
Created attachment 44334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44334=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion

Test plan:
- Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase
suggestion",
- type the title (and author?) of a document that stand in you database
- you should get a warning message about an exiting biblio.
- clicking on confirm your suggestion add it, cancel does nothing

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #15 from Nicole C. Engard  ---
This is neat, it's not super powerful, but I see how one day it could be. I'll
note in the documentation that it only works if the title and the name are
exact - so if I enter author Barbara Kingsolver it doesn't find her, but if I
put in Kingsolver,  Barbara it does.

Still a good feature that doesn't break anything that I can see :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #44320|0   |1
is obsolete||

--- Comment #14 from Nicole C. Engard  ---
Created attachment 44335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44335=edit
Bug 14973 - Fix broken itemtypes list in opac-suggestions form

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Nicole Engard (ByWater)  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

--- Comment #9 from Nicole Engard (ByWater)  ---
I don't see a test plan on this - can you add one and then I'll happily test.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #7 from Alex Arnaud  ---
I go back on my word about findDuplicate. Searching duplicates with full title
and author works for me.

I have a book: Les montagnes from Keith Lye.
Submit a suggestion with title "Les montagnes" => duplicate message
Submit a suggestion with title "Les montagnes" and author "Keith Lye" =>
duplicate message
Submit a suggestion with title "Les montagnes", author "Keith Lye" and itemtype
"Book" => duplicate message.

Anyone has the same problem than Marc ?

I will send a new patch because i have broken the itemtypes list in the form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #8 from Alex Arnaud  ---
Created attachment 44091
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44091=edit
Bug 14973 - Fix broken itemtypes list in opac-suggestions form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Gaetan Boisson  changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com

--- Comment #5 from Gaetan Boisson  ---
I would say not finding a match on a partial title is ok. Otherwise we'll have
a lot of fake positives, which will be unsettling for our users and might
discourage them from creating suggestions.

However, not finding a match when the full title and the author was entered is
definitely a bug for me. I think if findDuplicate says there is a duplicate
when just the title is entered, it should definitely find one if both title and
author are entered. I am not sure about how it works though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #6 from Alex Arnaud  ---
I agree with Gaetan. If we use simpleSearch, this means that if we type
"Dragons" as a title, a book like "Rise of the Dragons" could be shown as a
duplicate to the user. I think this is not what we want.
However, findDuplicate should be able to find duplicate when typing full title
and author. So i think we should fix this sub.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #4 from Marc Véron  ---
Hi Alex,

Maybe simpleSearch is better in this case. Can you give it a try?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #3 from Alex Arnaud  ---
Hello Marc,

I used C4::Search::FindDuplicate which seems to require almost the full title /
author.

Either we fix findDuplicate to make it more flexible or we create an other
subrutine (using simpleSearch ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Hi Alex,

I tested in Opac: Purchase Suggestions

Existing Biblio with item:
Wachtmeister Studers erste Fälle by Friedrich Glauser

Suggested:
Wachtmeister Studers erste Fälle -> Duplicate messsage
Wachtmeister Studer -> No message
Wachtmeister Studers -> No message
Wachtmeister Studers erste -> No Message
Studers erste Fälle -> No message

Combining full title with full Author
Wachtmeister Studers erste Fälle
Friedrich Glauser 
-> No Message

Wachtmeister Studers erste Fälle
Glauser, Friedrich
-> No Message

Combining full title with partial Author
Wachtmeister Studers erste Fälle
Glauser 
-> No Message

So it seems to work with the full title only. Is this intended?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #1 from Alex Arnaud  ---
Created attachment 43193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43193=edit
Bug 14973: Check existing biblio when submitting a purchase suggestion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/