https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Caroline Cyr La Rose changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Nick Clemens changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Owen Leonard changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Brendan Gallagher changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #66 from Owen Leonard ---
(In reply to Marcel de Rooy from comment #65)
> Resetting status
Sorry, I assumed that since the status of this bug was "Passed QA" that the
patches which git-bz would grab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
Status|Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Owen Leonard changed:
What|Removed |Added
Status|Passed QA |Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #63 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #61)
> Note that another report should deal with adding missing constraints on
> the currency code in suggestions and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
Status|Pushed to Master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #62 from Marcel de Rooy ---
(In reply to Brendan Gallagher from comment #60)
> Pushed the last two patches (48772 and 48783) Thanks
Thanks.
Don't forget the DBIx updates.
I added a follow-up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #61 from Marcel de Rooy ---
Created attachment 48858
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48858=edit
Bug 15084: [QA Follow-up] Correct field length of currency
Bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #60 from Brendan Gallagher ---
Pushed the last two patches (48772 and 48783) Thanks
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #57 from Marcel de Rooy ---
Aarrggg
This was hard to find:
The foreign key constraint (in AQorder) will sometimes fail on you:
Why?
aqorder:
| currency| varchar(3)| YES |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #56 from Marcel de Rooy ---
Created attachment 48783
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48783=edit
Bug 15084: [QA Follow-up] Update kohastructure
Adds two db revs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #55 from Jonathan Druart
---
Created attachment 48772
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48772=edit
Bug 15084: typo currency vs currency_code
The
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #54 from Jonathan Druart
---
@RM: The schema has not been regenerated.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #53 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #52)
> Created attachment 48747 [details] [review]
> Bug 15084 [QA Followup] - Fix new uses of GetCurrency
>
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #52 from Kyle M Hall ---
Created attachment 48747
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48747=edit
Bug 15084 [QA Followup] - Fix new uses of GetCurrency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Héctor Eduardo Castro Avalos changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #51 from Kyle M Hall ---
Created attachment 48703
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48703=edit
Bug 15084 [QA Followup] - Update Schema files
Signed-off-by: Kyle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Brendan Gallagher changed:
What|Removed |Added
Status|Passed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47221|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47216|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47219|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47220|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #47 from Jonathan Druart
---
Created attachment 48603
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48603=edit
Bug 15084: Fix conflict with bug 15446 (type vs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47215|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47217|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47214|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47213|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #47218|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Brendan Gallagher changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #32 from Kyle M Hall ---
Created attachment 47217
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47217=edit
Bug 15084: Remove C4::Budgets::ConvertCurrency
This subroutine is
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #29 from Kyle M Hall ---
Created attachment 47214
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47214=edit
Bug 15084: Make sure the previous active currency is marked as
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #30 from Kyle M Hall ---
Created attachment 47215
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47215=edit
Bug 15084: use Koha::Acquisition::Currenc[y|ies] in admin/currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Kyle M Hall changed:
What|Removed |Added
Attachment #45807|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #34 from Kyle M Hall ---
Created attachment 47219
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47219=edit
Bug 15084: DB Changes - add currency.archived and FK on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #33 from Kyle M Hall ---
Created attachment 47218
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47218=edit
Bug 15084: Add tests for Koha::Acquisition::Currenc[y|ies]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #31 from Kyle M Hall ---
Created attachment 47216
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47216=edit
Bug 15084: Replace C4::Budgets::GetCurrencies with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #35 from Kyle M Hall ---
Created attachment 47220
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47220=edit
Bug 15084: DBIx::Class - Shema changes
Signed-off-by: Josef Moravec
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #36 from Kyle M Hall ---
Created attachment 47221
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47221=edit
Bug 15084 [QA Followup] - Clean up test currencies after unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Blocks|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45691|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45696|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45694|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45695|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45690|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Status|Needs Signoff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45761|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45759|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
Attachment #45692|0 |1
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #18 from Jonathan Druart
---
Created attachment 45761
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45761=edit
Bug 15084: DBIx::Class - Shema changes
--
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #45693|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #19 from Jonathan Druart
---
(In reply to Josef Moravec from comment #16)
> Jonathan, there is a typo in atomic update sql file,
>
> update table aqorders set currency=NULL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Josef Moravec changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #15 from Jonathan Druart
---
Rebased against master
--
You are receiving this mail because:
You are watching all bug changes.
___
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Attachment #44162|0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #12 from Jonathan Druart
---
Created attachment 45694
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45694=edit
Bug 15084: Replace C4::Budgets::GetCurrencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #9 from Jonathan Druart
---
Created attachment 45691
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45691=edit
Bug 15084: Make sure the previous active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #11 from Jonathan Druart
---
Created attachment 45693
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45693=edit
Bug 15084: DB Changes - add currency.archived and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #10 from Jonathan Druart
---
Created attachment 45692
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45692=edit
Bug 15084: use Koha::Acquisition::Currenc[y|ies]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #13 from Jonathan Druart
---
Created attachment 45695
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45695=edit
Bug 15084: Remove C4::Budgets::ConvertCurrency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #14 from Jonathan Druart
---
Created attachment 45696
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45696=edit
Bug 15084: Add tests for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Summary|Move the
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #7 from Jonathan Druart
---
Created attachment 44168
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44168=edit
Bug 15084: Add tests for
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See Also|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #3 from Jonathan Druart
---
Created attachment 44164
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44164=edit
Bug 15084: use Koha::Acquisition::Currenc[y|ies]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #6 from Jonathan Druart
---
Created attachment 44167
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44167=edit
Bug 15084: Remove C4::Budgets::ConvertCurrency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #2 from Jonathan Druart
---
Created attachment 44163
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44163=edit
Bug 15084: Make sure the previous active currency
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #5 from Jonathan Druart
---
Created attachment 44166
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44166=edit
Bug 15084: Replace C4::Budgets::GetCurrencies with
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #4 from Jonathan Druart
---
Created attachment 44165
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44165=edit
Bug 15084: DB Changes - add currency.archived and
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
--- Comment #1 from Jonathan Druart
---
Created attachment 44162
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44162=edit
Bug 15084: Add Koha::Acquisition::Currenc[y|ies]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
Jonathan Druart changed:
What|Removed |Added
See Also|
96 matches
Mail list logo