subject:"\[Koha\-bugs\] \[Bug 15494\] Block renewals by arbitrary item values"

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2023-05-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||32478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32478
[Bug 32478] Remove Koha::Config::SysPref->find since bypasses cache
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2021-08-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||22866


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866
[Bug 22866] ItemsDeniedRenewal cannot be overriden
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-12-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27154

--- Comment #72 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #71)
> Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm
> and Koha/Util/SystemPreferences.pm?
> 
> Koha/Config/SysPref.pm:sub get_yaml_pref_hash {
> Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash {

Opened bug 27154.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154
[Bug 27154] Koha/Util/SystemPreferences.pm must be removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-12-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #71 from Jonathan Druart  
---
Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm and
Koha/Util/SystemPreferences.pm?

Koha/Config/SysPref.pm:sub get_yaml_pref_hash {
Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash {

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-04-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #70 from Katrin Fischer  ---
*** Bug 20213 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-11-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #69 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-11-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #68 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80327|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80328|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80329|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80330|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80331|0   |1
is obsolete||

--- Comment #65 from Katrin Fischer  ---
Created attachment 81415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81415=edit
Bug 15494: (QA follow-up) Additional polishing

[1] Fix two typos in Circulation.t.
Although the test does not fail, line 2127 contains two typos.
Changing INVISILE to INVISIBLE :)
And type should be itype.
[2] Remove $yaml as leftover from older code.
[3] Add a next when the split on /:/ does not give two results. This will
prevent uninit warnings (although still disabled now in Circulation).
[4] For the same reason we should switch the lines for NULL and empty
string. The undefs you insert should trigger a warn.
[5] The line for empty string should not insert undef, but empty string.
For the same reason adding the condition defined($_) ...
And proving it by adding two tests for the opposite values of
callnumber and itemnotes.
[6] Adding a strip spaces around the fieldname. User friendly..

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80332|0   |1
is obsolete||

--- Comment #66 from Katrin Fischer  ---
Created attachment 81416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81416=edit
Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object

To test:
1 - prove -v t/db_dependent/Koha/Config/SysPrefs.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80333|0   |1
is obsolete||

--- Comment #67 from Katrin Fischer  ---
Created attachment 81417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81417=edit
Bug 15494: (follow-up) Update tests to generate their own data (no delete)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #64 from Katrin Fischer  ---
Created attachment 81414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81414=edit
Bug 15494: Add syspref

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #63 from Katrin Fischer  ---
Created attachment 81413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81413=edit
Bug 15494: Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Small patch |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #62 from Katrin Fischer  ---
Created attachment 81412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81412=edit
Bug 15494: Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #61 from Katrin Fischer  ---
Created attachment 81411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81411=edit
Bug 15494: Unit tests

prove -v t/db_dependent/Circulation.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #60 from Nick Clemens  ---
Created attachment 80333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80333=edit
Bug 15494: (follow-up) Update tests to generate their own data (no delete)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #58 from Nick Clemens  ---
Created attachment 80331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80331=edit
Bug 15494: (QA follow-up) Additional polishing

[1] Fix two typos in Circulation.t.
Although the test does not fail, line 2127 contains two typos.
Changing INVISILE to INVISIBLE :)
And type should be itype.
[2] Remove $yaml as leftover from older code.
[3] Add a next when the split on /:/ does not give two results. This will
prevent uninit warnings (although still disabled now in Circulation).
[4] For the same reason we should switch the lines for NULL and empty
string. The undefs you insert should trigger a warn.
[5] The line for empty string should not insert undef, but empty string.
For the same reason adding the condition defined($_) ...
And proving it by adding two tests for the opposite values of
callnumber and itemnotes.
[6] Adding a strip spaces around the fieldname. User friendly..

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #57 from Nick Clemens  ---
Created attachment 80330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80330=edit
Bug 15494 - Add syspref

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #59 from Nick Clemens  ---
Created attachment 80332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80332=edit
Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object

To test:
1 - prove -v t/db_dependent/Koha/Config/SysPrefs.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #55 from Nick Clemens  ---
Created attachment 80328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80328=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #56 from Nick Clemens  ---
Created attachment 80329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80329=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Attachment #79249|0   |1
is obsolete||
  Attachment #79250|0   |1
is obsolete||
  Attachment #79251|0   |1
is obsolete||
  Attachment #79252|0   |1
is obsolete||
  Attachment #79253|0   |1
is obsolete||
  Attachment #79254|0   |1
is obsolete||
  Attachment #79293|0   |1
is obsolete||

--- Comment #54 from Nick Clemens  ---
Created attachment 80327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80327=edit
Bug 15494 - Unit tests

prove -v t/db_dependent/Circulation.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #53 from Jonathan Druart  
---
Should not Koha::Util::SystemPreferences->get_yaml_pref_hash be a method of
Koha::Config::SysPref instead?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #52 from Nick Clemens  ---
(In reply to Nick Clemens from comment #50)
> (In reply to Jonathan Druart from comment #39)
> > 1. In tests, prefer
> > Koha::IssuingRules->search->update($what_you_need_to_be_set);
> > instead of the DELETE then INSERT. It makes the changes more readable in my
> > opinion.
> 
> I generally agree, but circ rules are messy and this file has the same code
> existing. Should be refactored as a whole
> 
okay, found an easy way to fix, updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #51 from Nick Clemens  ---
Created attachment 79293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79293=edit
Bug 15494: Update tests to generate their own data (no delete)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancement offers the
  release notes||possibility to prevent
   ||renewals given certain item
   ||values. Using a yaml syntax
   ||the library can specify
   ||certain item field values
   ||that, when matched, will
   ||prevent renewals for
   ||affected items.
   ||
   ||If using
   ||automatic renewal notices
   ||your notice should be
   ||updated to account for the
   ||new reason that renewals
   ||may be denied
   ||"item_denied_renewal"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #50 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #39)
> 1. In tests, prefer
> Koha::IssuingRules->search->update($what_you_need_to_be_set);
> instead of the DELETE then INSERT. It makes the changes more readable in my
> opinion.

I generally agree, but circ rules are messy and this file has the same code
existing. Should be refactored as a whole


> 2. What about "NULL" string values? :)

I think we expect a certain level of input from the user and are fairly
thorough here

> 3. Should not we have the same code for 
> OpacHiddenItems and ItemsDeniedRenewal (and UpdateNotForLoanStatusOnCheckin?)
> There is also UpdateItemLocationOnCheckin (bug 14576)
> 
> The minimum would be a new get_rules_from_prefs sub

Moved to its own sub/module - changes for other prefs should be on their own
reports

> Ah! Not sure the reason is available in the template tho.

The reasons are stored in the issues table, they should be available to
templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #49 from Nick Clemens  ---
Created attachment 79254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79254=edit
Bug 15494: Move yaml syspref code to its own sub

To test:
1 - prove -v t/db_dependent/Koha/Util/SystemPreferences.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #48 from Nick Clemens  ---
Created attachment 79253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79253=edit
Bug 15494: (QA follow-up) Additional polishing

[1] Fix two typos in Circulation.t.
Although the test does not fail, line 2127 contains two typos.
Changing INVISILE to INVISIBLE :)
And type should be itype.
[2] Remove $yaml as leftover from older code.
[3] Add a next when the split on /:/ does not give two results. This will
prevent uninit warnings (although still disabled now in Circulation).
[4] For the same reason we should switch the lines for NULL and empty
string. The undefs you insert should trigger a warn.
[5] The line for empty string should not insert undef, but empty string.
For the same reason adding the condition defined($_) ...
And proving it by adding two tests for the opposite values of
callnumber and itemnotes.
[6] Adding a strip spaces around the fieldname. User friendly..

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #45 from Nick Clemens  ---
Created attachment 79250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79250=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #47 from Nick Clemens  ---
Created attachment 79252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79252=edit
Bug 15494 - Add syspref

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Attachment #71134|0   |1
is obsolete||
  Attachment #71135|0   |1
is obsolete||
  Attachment #71136|0   |1
is obsolete||
  Attachment #71137|0   |1
is obsolete||
  Attachment #71138|0   |1
is obsolete||

--- Comment #44 from Nick Clemens  ---
Created attachment 79249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79249=edit
Bug 15494 - Unit tests

prove -v t/db_dependent/Circulation.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #46 from Nick Clemens  ---
Created attachment 79251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79251=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Edie Discher  changed:

   What|Removed |Added

 CC||edisc...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20213

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Cheryl  changed:

   What|Removed |Added

 CC||clack...@cityoffargo.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #43 from Katrin Fischer  ---
Ah! Not sure the reason is available in the template tho.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #42 from Jonathan Druart  
---
s/people/Koha administrators

In the update DB process I guess, a warning to tell this new code is added and
must be taken into account in the template of the notice.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #41 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #40)
> We should also tell people that a new item_denied_renewal condition must be
> added to AUTO_RENEWALS

Can you explain that one? People?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #40 from Jonathan Druart  
---
We should also tell people that a new item_denied_renewal condition must be
added to AUTO_RENEWALS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #39 from Jonathan Druart  
---
1. In tests, prefer
Koha::IssuingRules->search->update($what_you_need_to_be_set);
instead of the DELETE then INSERT. It makes the changes more readable in my
opinion.

2. What about "NULL" string values? :)

3. Should not we have the same code for 
OpacHiddenItems and ItemsDeniedRenewal (and UpdateNotForLoanStatusOnCheckin?)
There is also UpdateItemLocationOnCheckin (bug 14576)

The minimum would be a new get_rules_from_prefs sub

Marking as FQA for discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #38 from Marcel de Rooy  ---
Has been tested already before, spent sufficient time on changes now.
Looks good to me.
No blocker, but slightly confusing in staff checkouts table:

0 Renewal denied by syspref
(10 of 10 renewals remaining)

If I can't renew, what is the value of these 10? :)

Passed QA with follow-up for some minor issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71133|0   |1
is obsolete||

--- Comment #37 from Marcel de Rooy  ---
Created attachment 71138
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71138=edit
Bug 15494: (QA follow-up) Additional polishing

[1] Fix two typos in Circulation.t.
Although the test does not fail, line 2127 contains two typos.
Changing INVISILE to INVISIBLE :)
And type should be itype.
[2] Remove $yaml as leftover from older code.
[3] Add a next when the split on /:/ does not give two results. This will
prevent uninit warnings (although still disabled now in Circulation).
[4] For the same reason we should switch the lines for NULL and empty
string. The undefs you insert should trigger a warn.
[5] The line for empty string should not insert undef, but empty string.
For the same reason adding the condition defined($_) ...
And proving it by adding two tests for the opposite values of
callnumber and itemnotes.
[6] Adding a strip spaces around the fieldname. User friendly..

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71132|0   |1
is obsolete||

--- Comment #36 from Marcel de Rooy  ---
Created attachment 71137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71137=edit
Bug 15494 - Add syspref

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71129|0   |1
is obsolete||

--- Comment #33 from Marcel de Rooy  ---
Created attachment 71134
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71134=edit
Bug 15494 - Unit tests

prove -v t/db_dependent/Circulation.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71130|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 71135
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71135=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #71131|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 71136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71136=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #30 from Marcel de Rooy  ---
Created attachment 71131
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71131=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #31 from Marcel de Rooy  ---
Created attachment 71132
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71132=edit
Bug 15494 - Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #32 from Marcel de Rooy  ---
Created attachment 71133
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71133=edit
Bug 15494: (QA follow-up) Additional polishing

[1] Fix two typos in Circulation.t.
Although the test does not fail, line 2127 contains two typos.
Changing INVISILE to INVISIBLE :)
And type should be itype.
[2] Remove $yaml as leftover from older code.
[3] Add a next when the split on /:/ does not give two results. This will
prevent uninit warnings (although still disabled now in Circulation).
[4] For the same reason we should switch the lines for NULL and empty
string. The undefs you insert should trigger a warn.
[5] The line for empty string should not insert undef, but empty string.
For the same reason adding the condition defined($_) ...
And proving it by adding two tests for the opposite values of
callnumber and itemnotes.
[6] Adding a strip spaces around the fieldname. User friendly..

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #70629|0   |1
is obsolete||
  Attachment #70630|0   |1
is obsolete||
  Attachment #70631|0   |1
is obsolete||
  Attachment #70632|0   |1
is obsolete||

--- Comment #28 from Marcel de Rooy  ---
Created attachment 71129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71129=edit
Bug 15494 - Unit tests

prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #29 from Marcel de Rooy  ---
Created attachment 71130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71130=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #27 from Marcel de Rooy  ---
Working on this one now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #26 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #21)
> + unless ($item){ carp "No item passed in!" && return }
> Not our preferred coding style

This was just copying others in this file, changed to "return unless $item"

> + return () if (! $yaml =~ /\S/ );
> Just return here. 
Removed

> +eval {
> +$denyingrules = YAML::Load($yaml);
> +};
> How much time are we spending on doing this? What is the performance effect?
Was about .037 seconds (with 2 fields and 1000 values)
Using split is about .014 seconds, okay, I switched

> +return ();
Yup

> Why not in just one line: my $val = $item->{$field} // '';
Good point

>Why not just provide an example as close as possible to the pref itself?

Okay

> Just curious too if this supports denying renewal on an empty string? If so,
> the conversion from undef to empty string might not be what we want. 
Okay, can use "" or NULL for specific now (see the pref explanation)


> Changing status. Please make some adjustments.
Improved, squashed, sent back for SO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #24 from Nick Clemens  ---
Created attachment 70631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70631=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #25 from Nick Clemens  ---
Created attachment 70632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70632=edit
Bug 15494 - Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68146|0   |1
is obsolete||
  Attachment #68147|0   |1
is obsolete||
  Attachment #68148|0   |1
is obsolete||
  Attachment #68149|0   |1
is obsolete||
  Attachment #70295|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 70629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70629=edit
Bug 15494 - Unit tests

prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #23 from Nick Clemens  ---
Created attachment 70630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70630=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #21 from Marcel de Rooy  ---
+ unless ($item){ carp "No item passed in!" && return }
Not our preferred coding style

+ return () if (! $yaml =~ /\S/ );
Just return here. The only call is in scalar context. We do not need a list.
Shorter: return if $yaml !~ /\S/;

+eval {
+$denyingrules = YAML::Load($yaml);
+};
How much time are we spending on doing this? What is the performance effect? If
the pref always looks like field1: [val]\nfield2: [val2] we can just split on
newline and split on ':', etc. Give me some convincing numbers please.

+return ();
Same as above

+my $val;
+if (exists $item->{$field}) {
+$val = $item->{$field};
+}
+$val = '' unless defined $val;
Why not in just one line: my $val = $item->{$field} // '';

+- How to write these rules is documented on the http://wiki.koha-community.org/wiki/OpacHiddenItems; target="_blank">Koha
wiki.
This is from the preference file. Not sure if this is the preferred way. A wiki
page could be gone just as easily. Why not just provide an example as close as
possible to the pref itself. Just another 40 chars ?

Just curious too if this supports denying renewal on an empty string? If so,
the conversion from undef to empty string might not be what we want. Can we
signal empty string or undef to be a blocking value? [No blocker for me btw :)]

Changing status. Please make some adjustments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #20 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #19)
> It seems due dates were being set to now. If the tests take long enough to
> run then the items were overdue. Set the date in the future now

Yes, that works better. Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #19 from Nick Clemens  ---
It seems due dates were being set to now. If the tests take long enough to run
then the items were overdue. Set the date in the future now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #18 from Nick Clemens  ---
Created attachment 70295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295=edit
Bug 15494 - Followup: Make sure items in tests are not overdue

prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Marcel de Rooy  ---
# Subtest: ItemsDeniedRenewal preference
1..14
not ok 1 - Renewal allowed when no rules
#   Failed test 'Renewal allowed when no rules'
#   at t/db_dependent/Circulation.t line 2108.
#  got: '0'
# expected: '1'
not ok 2 - Renewal allowed when no rules
#   Failed test 'Renewal allowed when no rules'
#   at t/db_dependent/Circulation.t line 2109.
#  got: 'overdue'
# expected: undef
ok 3 - Renewal blocked when 1 rules (withdrawn)
ok 4 - Renewal blocked when 1 rule (withdrawn)
not ok 5 - Renewal allowed when 1 rules not matched (withdrawn)
#   Failed test 'Renewal allowed when 1 rules not matched (withdrawn)'
#   at t/db_dependent/Circulation.t line 2121.
#  got: '0'
# expected: '1'
not ok 6 - Renewal allowed when 1 rules not matched (withdrawn)
#   Failed test 'Renewal allowed when 1 rules not matched (withdrawn)'
#   at t/db_dependent/Circulation.t line 2122.
#  got: 'overdue'
# expected: undef
ok 7 - Renewal blocked when 2 rules matched (withdrawn, itype)
ok 8 - Renewal blocked when 2 rules matched (withdrawn,itype)
not ok 9 - Renewal allowed when 2 rules not matched (withdrawn, itype)
#   Failed test 'Renewal allowed when 2 rules not matched (withdrawn,
itype)'
#   at t/db_dependent/Circulation.t line 2135.
#  got: '0'
# expected: '1'
not ok 10 - Renewal allowed when 2 rules not matched (withdrawn, itype)
#   Failed test 'Renewal allowed when 2 rules not matched (withdrawn,
itype)'
#   at t/db_dependent/Circulation.t line 2136.
#  got: 'overdue'
# expected: undef
ok 11 - Renewal blocked when 3 rules matched (withdrawn, itype, location)
ok 12 - Renewal blocked when 3 rules matched (withdrawn,itype, location)
not ok 13 - Renewal allowed when 3 rules not matched (withdrawn, itype,
location)
#   Failed test 'Renewal allowed when 3 rules not matched (withdrawn,
itype, location)'
#   at t/db_dependent/Circulation.t line 2150.
#  got: '0'
# expected: '1'
not ok 14 - Renewal allowed when 3 rules not matched (withdrawn, itype,
location)
#   Failed test 'Renewal allowed when 3 rules not matched (withdrawn,
itype, location)'
#   at t/db_dependent/Circulation.t line 2151.
#  got: 'overdue'
# expected: undef
# Looks like you failed 8 tests of 14.
not ok 114 - ItemsDeniedRenewal preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #16 from Nick Clemens  ---
Hmmm...they all pass for me, can you try again and paste the full results?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #15 from Marcel de Rooy  ---
# Looks like you failed 8 tests of 14.
t/db_dependent/Circulation.t .. 114/114
#   Failed test 'ItemsDeniedRenewal preference'
#   at t/db_dependent/Circulation.t line 2153.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67889|0   |1
is obsolete||

--- Comment #14 from Katrin Fischer  ---
Created attachment 68149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68149=edit
Bug 15494 - Add syspref

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67887|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 68147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68147=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67888|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 68148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68148=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67886|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 68146
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68146=edit
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Katrin Fischer  ---
This seems to work quite well! Also tested renew through checkout, renewal tab
and OPAC.

When renewing the item from the list of checkouts and using the renewal limit
override functionality, the message displayed is:

Renew failed: item_denied_renewal

This could be improved, maybe with a small follow-up?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #8 from Nick Clemens  ---
Created attachment 67888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67888=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #7 from Nick Clemens  ---
Created attachment 67887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67887=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #9 from Nick Clemens  ---
Created attachment 67889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67889=edit
Bug 15494 - Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63700|0   |1
is obsolete||
  Attachment #63701|0   |1
is obsolete||
  Attachment #63702|0   |1
is obsolete||
  Attachment #63703|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 67886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67886=edit
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Code looks good, but there is a bigger conflict in the test file I am not sure
about, can you please rebase? 

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15494 - Unit tests
Using index info to reconstruct a base tree...
M   t/db_dependent/Circulation.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Circulation.t
CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15494 - Unit tests
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15494---Unit-tests-pu3VeI.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #3 from Nick Clemens  ---
Created attachment 63702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63702=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #4 from Nick Clemens  ---
Created attachment 63703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63703=edit
Bug 15494 - Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #1 from Nick Clemens  ---
Created attachment 63700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63700=edit
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #2 from Nick Clemens  ---
Created attachment 63701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63701=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Change sponsored?|Seeking cosponsors  |Sponsored
Summary|Make Longoverdue/Lost items |Block renewals by arbitrary
   |not renewable   |item values
 CC||n...@bywatersolutions.com
   Patch complexity|--- |Small patch
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

91 matches

Mail list logo