[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545
Bug 15545 depends on bug 18037, which changed state.

Bug 18037 Summary: Hold notes template cleanup (from 15545)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #41 from Marcel de Rooy  ---
Blocked (temporarily) in favor of bug 18037.
Actually splitting the patch set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||18037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18037
[Bug 18037] Hold notes template cleanup (from 15545)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #40 from Marcel de Rooy  ---
>From khall on irc to clarify:

marcelr: pluggability should be for the controlling behavior, not for the
action imo. I'm trying to say if the plugin hook could be used to decide if any
given hold form field should be required it would make more sense to me. That
being said, I'm not opposed to it the way it works atm. I'm wondering if maybe
HEA should be able to track installed plugins, that would be useful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #39 from Kyle M Hall  ---
I'm really on the fence. I don't see anything wrong with extending the plugin
functionality, but on the other hand, there is a *very* specific behavior. If
it were an extension to control all the hold fields it would seem a bit less
odd.

Marcel, considering the small size of the patches, I don't think moving the sub
to Koha::Hold is too big of an ask ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #38 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #37)
> I would like to see the C4::Reserves sub moved to a Koha::Hold method at
> least.

I would not block this for that reason; the change was already pending before
Koha::Objects were invented :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #37 from Jonathan Druart  
---
I do not manage to clear up my mind about the use of this plugin.

I'd say it's the kind of feature that could be driven by a syspref. The
quantity of code to wrap the plugin seems the same as the size of the plugin
itself. It is also the kind of code we will not be able to know if it is used
by someone in few years (what we do have with a syspref, cf Hea).

I would like to see the C4::Reserves sub moved to a Koha::Hold method at least.

Kyle, can we get your opinion on this one please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #36 from Marcel de Rooy  ---
Rebase for C4/Reserves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53547|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 59253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59253=edit
Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl

This patch implements use of the new Reserves routine IsHoldNoteRequired,
making it possible to require a note when placing a hold.
Only a very small change in opac-reserve.pl is needed. As well as
corresponding changes in the template. I am removing some unused template
code related to a former approach.

Test plan:
[1] Disable UseKohaPlugins, enable OpacHoldNotes.
[2] Place a hold on a serial record (leader pos 7 == s). Verify that
the hold note is not required.
[3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins.
(Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz.
This file can be found as an attachment to this BZ report.)
[4] Again place a hold on a serial record. The hold note should be required.

Signed-off-by: Liz Rea  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #53546|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 59252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59252=edit
Bug 15545: Add routine IsHoldNoteRequired to Reserves module

This routine will be used to determine if a hold note is required.
In the current approach this is implemented by use of Koha plugins.
A former approach included a syspref. This is no longer needed. This
approach is even more flexible.

The routine will use all plugins it finds with metadata tag
'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a
check method that returns true, the hold note should be regarded as
required.

The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an
implementation where the value of the leader or MARC21 300$a determines
if the hold note is required. Similarly, any other field of the
bibliographic record could be used in a new plugin.

Test plan:
Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t.

Signed-off-by: Liz Rea  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #33 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #29)
> The version of the patch on bug 9743 and the first version on this bug
> report did not introduced a new way to modify behaviors using plugings. If
> they get pushed, we will have a precedent and new patches/plugins will use
> it. That will add more stuffs to modify if we decide the switch our plugin
> system.

Reopened and back to SO qeueue. Still applies.
There has been no movement on the plugin system since the above was written.
And note that one of the two patches was written Dec 2014.
The argument that this "introduces a new way to use plugins" is imo not really
valid. No dangerous precedents here. It would be quite trivial to adjust this
routine to a new plugin system as should be done for others too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|WONTFIX |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #32 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Marcel de Rooy from comment #30)
> > I'm kind of exhausted in finding new ways to get this simple change in Koha.
> 
> My goal was not to exhaust you, but just to make sure it was the best thing
> to do.
> Sorry about that. My suggestion was to ask on koha-devel what others think.

No problem. But I prefer not to keep this report pending for another longer
period of time. Moving it to custom :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #31 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #30)
> I'm kind of exhausted in finding new ways to get this simple change in Koha.

My goal was not to exhaust you, but just to make sure it was the best thing to
do.
Sorry about that. My suggestion was to ask on koha-devel what others think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|Signed Off  |RESOLVED

--- Comment #30 from Marcel de Rooy  ---
I'm kind of exhausted in finding new ways to get this simple change in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #29 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #28)
> (In reply to Jonathan Druart from comment #27)
> > (In reply to Marcel de Rooy from comment #26)
> > > (In reply to Jonathan Druart from comment #25)
> > > > I don't think I am ready to QA this one.
> > > > Julian has announced a new plugin system few weeks ago and this patch 
> > > > will
> > > > adds a precedent for the existing plugin system.
> > > > Do you have in mind other uses case? Did you plan to extend it to other
> > > > behaviors?
> > > > It would be great to ping koha-devel to get other dev opinions.
> > > 
> > > Please follow the trace in the see also bug and see that it is already 
> > > three
> > > years under way.
> > 
> > I do not understand, are you talking about bug 9743? How this bug report can
> > answer my questions?
> 
> It didn't ? :)
> My point is: why block something that I am waiting for over three years
> because something else was created a few months ago?

The version of the patch on bug 9743 and the first version on this bug report
did not introduced a new way to modify behaviors using plugings. If they get
pushed, we will have a precedent and new patches/plugins will use it. That will
add more stuffs to modify if we decide the switch our plugin system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #28 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #27)
> (In reply to Marcel de Rooy from comment #26)
> > (In reply to Jonathan Druart from comment #25)
> > > I don't think I am ready to QA this one.
> > > Julian has announced a new plugin system few weeks ago and this patch will
> > > adds a precedent for the existing plugin system.
> > > Do you have in mind other uses case? Did you plan to extend it to other
> > > behaviors?
> > > It would be great to ping koha-devel to get other dev opinions.
> > 
> > Please follow the trace in the see also bug and see that it is already three
> > years under way.
> 
> I do not understand, are you talking about bug 9743? How this bug report can
> answer my questions?

It didn't ? :)
My point is: why block something that I am waiting for over three years because
something else was created a few months ago?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #27 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #26)
> (In reply to Jonathan Druart from comment #25)
> > I don't think I am ready to QA this one.
> > Julian has announced a new plugin system few weeks ago and this patch will
> > adds a precedent for the existing plugin system.
> > Do you have in mind other uses case? Did you plan to extend it to other
> > behaviors?
> > It would be great to ping koha-devel to get other dev opinions.
> 
> Please follow the trace in the see also bug and see that it is already three
> years under way.

I do not understand, are you talking about bug 9743? How this bug report can
answer my questions?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #26 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #25)
> I don't think I am ready to QA this one.
> Julian has announced a new plugin system few weeks ago and this patch will
> adds a precedent for the existing plugin system.
> Do you have in mind other uses case? Did you plan to extend it to other
> behaviors?
> It would be great to ping koha-devel to get other dev opinions.

Please follow the trace in the see also bug and see that it is already three
years under way.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #25 from Jonathan Druart  
---
I don't think I am ready to QA this one.
Julian has announced a new plugin system few weeks ago and this patch will adds
a precedent for the existing plugin system.
Do you have in mind other uses case? Did you plan to extend it to other
behaviors?
It would be great to ping koha-devel to get other dev opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #24 from Liz Rea  ---
to be fair it says "OpacHoldNotes" so... yeah I just wasn't putting two and two
together. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #23 from Marcel de Rooy  ---
(In reply to Liz Rea from comment #20)
> I think I see what I did wrong now - I was testing this in the staff client!
> How very silly of me. Will give it one more go today, you know, doing it
> properly. :)

Thx Liz for your signoff. Should have mentioned opac in the latest commit
message..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Liz Rea  changed:

   What|Removed |Added

  Attachment #51834|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #22 from Liz Rea  ---
Created attachment 53547
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53547=edit
Bug 15545: Use IsHoldNoteRequired in opac-reserve.pl

This patch implements use of the new Reserves routine IsHoldNoteRequired,
making it possible to require a note when placing a hold.
Only a very small change in opac-reserve.pl is needed. As well as
corresponding changes in the template. I am removing some unused template
code related to a former approach.

Test plan:
[1] Disable UseKohaPlugins, enable OpacHoldNotes.
[2] Place a hold on a serial record (leader pos 7 == s). Verify that
the hold note is not required.
[3] Enable UseKohaPlugins. Install the Rijks_HoldNoteRequired plugins.
(Go to plugins/plugins-home.pl and upload Rijks_HoldNoteRequired.kpz.
This file can be found as an attachment to this BZ report.)
[4] Again place a hold on a serial record. The hold note should be required.

Signed-off-by: Liz Rea  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Liz Rea  changed:

   What|Removed |Added

  Attachment #51833|0   |1
is obsolete||

--- Comment #21 from Liz Rea  ---
Created attachment 53546
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53546=edit
Bug 15545: Add routine IsHoldNoteRequired to Reserves module

This routine will be used to determine if a hold note is required.
In the current approach this is implemented by use of Koha plugins.
A former approach included a syspref. This is no longer needed. This
approach is even more flexible.

The routine will use all plugins it finds with metadata tag
'implements' set to 'IsHoldNoteRequired'. If one of these plugins has a
check method that returns true, the hold note should be regarded as
required.

The plugins Rijks_HoldNoteRequired_Extent and _Leader offer an
implementation where the value of the leader or MARC21 300$a determines
if the hold note is required. Similarly, any other field of the
bibliographic record could be used in a new plugin.

Test plan:
Run unit test t/db_dependent/Reserves/IsHoldNoteRequired.t.

Signed-off-by: Liz Rea  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #20 from Liz Rea  ---
Hi Marcel,

I think I see what I did wrong now - I was testing this in the staff client!
How very silly of me. Will give it one more go today, you know, doing it
properly. :)

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #19 from Marcel de Rooy  ---
(In reply to Liz Rea from comment #18)

Hi,

> However I still can't make the required hold notes work. Also was further
> confused by bug 16391, which makes your plugins not show up in the list when
> you go back to the page, even if they are installed. Removing method=tool
> from the url makes them turn up. That's not your fault, it just caused me
> trouble when I was testing.
You are right. I made a remark on that report too. Could add a fake tool
subroutine to make them show up, but that would not be a real solution.

> The patches don't break anything that I can see. I was testing on current
> master, 3692f92.
Well, that is a major goal :)

> Maybe you know something else I could be doing wrong?
First verify that the plugin is installed etc., so we know that it is called.
Pick a marc record with available item, change the leader (probably replace nam
by nas), i.e. make sure that position 7 is the character s.
Go to opac, place a hold on that specific record. If you unhide the options,
you already should see the text line: Please enter additional information about
the requested item. Pressing Place Hold should not work. Depending on the
browser, the text box is marked red or something. If that is the case, you
actually finished testing already (the hold note indeed is required now).

Alternatively, you could also edit the plugin's Leader.pm, add a "return 1;" in
the check subroutine near the top. Because we are not focusing on testing the
plugin here but only the routine in Reserves calling available plugins. In that
case messing with records is not needed..

Thanks again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #18 from Liz Rea  ---
Hi,

With the dependency, I got the tests to pass. Yay!

However I still can't make the required hold notes work. Also was further
confused by bug 16391, which makes your plugins not show up in the list when
you go back to the page, even if they are installed. Removing method=tool from
the url makes them turn up. That's not your fault, it just caused me trouble
when I was testing.

The patches don't break anything that I can see. I was testing on current
master, 3692f92.

Maybe you know something else I could be doing wrong?

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

--- Comment #17 from Liz Rea  ---
It may well be because of the dependency, I missed that. I'll have another go.
:)

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #16 from Marcel de Rooy  ---
(In reply to Liz Rea from comment #15)
> I have both the test failing:
> 
> t/db_dependent/Reserves/IsHoldNoteRequired.t .. 
> 1..3
> ok 1 - Should be false if plugins are disabled
> not ok 2 - Should be true for biblionumber 2
I had the same result when I did not apply the dependency. Please first apply
the (fairly simple) patch for bug 16586. When I run the test again, it passes.


> And I can't seem to make it work functionally either, sorry.
Could you explain further? Related to the missing depend ?

Thx for testing this. It did not yet receive much attention lately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold ( via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
 Status|Needs Signoff   |Failed QA

--- Comment #15 from Liz Rea  ---
Hi,

I have both the test failing:

t/db_dependent/Reserves/IsHoldNoteRequired.t .. 
1..3
ok 1 - Should be false if plugins are disabled
not ok 2 - Should be true for biblionumber 2

#   Failed test 'Should be true for biblionumber 2'
#   at t/db_dependent/Reserves/IsHoldNoteRequired.t line 53.
#  got: undef
# expected: '1'
ok 3 - Should be false for biblionumber 0
# Looks like you failed 1 test of 3.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/3 subtests 

Test Summary Report
---
t/db_dependent/Reserves/IsHoldNoteRequired.t (Wstat: 256 Tests: 3 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=3,  2 wallclock secs ( 0.01 usr  0.00 sys +  0.99 cusr  0.05
csys =  1.05 CPU)
Result: FAIL

And I can't seem to make it work functionally either, sorry.

Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold (via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15545] Optionally make hold notes required when placing a hold (via Koha::Plugin)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15545

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Optionally require notes|Optionally make hold notes
   |when placing a hold |required when placing a
   ||hold (via Koha::Plugin)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/