subject:"\[Koha\-bugs\] \[Bug 15561\] Add ability to charge cancellation fee from \"Holds over\" tab"

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2019-01-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #29 from Katrin Fischer  ---
Patches no longer apply, can you please rebase?

warning: 1 line applied after fixing whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt
Auto-merging circ/waitingreserves.pl
CONFLICT (content): Merge conflict in circ/waitingreserves.pl
Auto-merging C4/Reserves.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15561 - Add ability to charge cancelation fee from
"Holds over" tab
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15561---Add-ability-to-charge-cancelation-fee--N7o9xj.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

--- Comment #28 from Kyle M Hall  ---
Created attachment 81907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81907=edit
Bug 15561 [QA Followup] - Add atomic update, fix other issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

--- Comment #27 from Kyle M Hall  ---
Created attachment 81906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81906=edit
Bug 15561 [QA Followup] - Rename ExpireReservesMaxPickUpDelayCharge to
WaitingHoldCancelationFee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

--- Comment #26 from Kyle M Hall  ---
Created attachment 81905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81905=edit
Bug 15561 [QA Followup] - Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #63358|0   |1
is obsolete||
  Attachment #63359|0   |1
is obsolete||
  Attachment #63360|0   |1
is obsolete||
  Attachment #63361|0   |1
is obsolete||

--- Comment #25 from Kyle M Hall  ---
Created attachment 81904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81904=edit
Bug 15561 - Add ability to charge cancelation fee from "Holds over" tab

The fee set in ExpireReservesMaxPickUpDelayCharge can only be charged by
the automatic expiration cron script. Some libraries would prefer to
manually cancel holds via the "Holds over" tab of the "Holds awaiting
pickup" page but still be able to charge the cancellation fee.

Test Plan:
1) Apply this patch
2) Set ExpireReservesMaxPickUpDelayCharge to some number
3) Go to the Holds awaiting pickup page
4) Go to the Holds over tab
5) Note the new checkbox for charging the fee
6) Test canceling a single hold with the checkbox checked
7) Note a fee is charged
8) Test canceling a single hold with the checkbox unchecked
9) Note a fee is not charged
10) Test canceling all holds with the checkbox checked
11) Note the patrons are charged fees
12) Test canceling all holds without the checkbox checked
13) Note the patrons are not charged fees

Signed-off-by: Jason Burds 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2018-11-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Brian  changed:

   What|Removed |Added

 CC||bkl...@dubuque.lib.ia.us

--- Comment #24 from Brian  ---
Any updates on the 15561 bug?

Carnegie Stout Team would be grateful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2017-08-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

2017-08-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15561

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
Summary|Add ability to charge   |Add ability to charge
   |cancelation fee from "Holds |cancellation fee from
   |over" tab   |"Holds over" tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

[Koha-bugs] [Bug 15561] Add ability to charge cancellation fee from "Holds over" tab

10 matches

Site Navigation

Mail list logo

Footer information