https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Victor Grousset/tuxayo changed:
What|Removed |Added
Version(s)|19.11.00,19.05.04 |19.11.00,19.05.04,1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Lucas Gass changed:
What|Removed |Added
Status|Pushed to stable|Pushed to oldstable
--
You ar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Lucas Gass changed:
What|Removed |Added
CC||lu...@bywatersolutions.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #81 from Victor Grousset/tuxayo ---
Hi, here is a branch with the backported patches from 19.05.x on top of current
18.11.x
https://git.biblibre.com/biblibre/kohac/commits/branch/18.11.x-backport-bz-16111
I tested the R
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #80 from Victor Grousset/tuxayo ---
@Lucas I'm trying to backport to 18.11, it's not trivial but it seems safe.
Will link a branch after finishing and testing it.
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.c
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #78 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Attachment #92437|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #77 from Marcel de Rooy ---
@RM: RSS needs further attention but I think this is a good start now. See
earlier comments. I reverted some changes in the third patch. You might want to
ask Jonathan for comments. But I would
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Attachment #92623|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #75 from Marcel de Rooy ---
Created attachment 92623
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92623&action=edit
Bug 16111: (QA follow-up) Few additional corrections
[1] Refining the regex on the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #74 from Marcel de Rooy ---
Created attachment 92622
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92622&action=edit
Bug 16111: (QA follow-up) Changes related to partial revert
When reverting the & ch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Attachment #92435|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #72 from Marcel de Rooy ---
Created attachment 92620
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92620&action=edit
Bug 16111: [CHANGED] Replace link href by link in rss part
Original patch title: Re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Attachment #92439|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Attachment #92436|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Status|BLOCKED |Passed QA
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #69 from Marcel de Rooy ---
Git grep on rss2
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-showreviews-rss.tt: [%
OPACBaseURL | html %]/cgi-bin/koha/opac-showreviews.pl&format=rss2
koha-tmpl/opac-tmpl/bootstrap/en/mo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #68 from Marcel de Rooy ---
Before each item we have:
NO
ITEM INFO ?
EMPTY search
term and page !
Seems useless. Not touching it here
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #67 from Marcel de Rooy ---
Should we use dc:creator or author? Koha just puts author in item:title element
Specs: An item's title element holds character data that provides the item's
headline.
See also: For all elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #66 from Marcel de Rooy ---
opac-search.pl
+$format = 'rss' if $format =~ /rss/;
Hmm. Maybe we should only allow rss2 now too ?
Adding a follow-up.
--
You are receiving this mail because:
You are watching all bug change
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #65 from Marcel de Rooy ---
The rss template contains things like:
SEARCH_RESULT.query_cgi and SEARCH_RESULT.limit_cgi
These are empty!
SEARCH_RESULTS comes from:
@newresults = searchResults( $search_context, $query_desc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #64 from Marcel de Rooy ---
I am seeing URLs like
/cgi-bin/koha/opac-search.pl?&sort_by=relevance_dsc&format=atom
OR
/cgi-bin/koha/opac-search.pl?amp;idx=kw&q=perl&format=rss
The extra ampersand was removed (before) by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #63 from Victor Grousset/tuxayo ---
> refresh the page, it should do RSS things (i.e. firefox should render it as a
> nice looking thing, rather than raw XML.)
Is that actually the case? Since version 64, there is no mo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |BLOCKED
--- Comment #62 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
CC||victor.grous...@biblibre.co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Cab Vinton changed:
What|Removed |Added
CC|bibli...@gmail.com |
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #92438|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #59 from Liz Rea ---
Created attachment 92438
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92438&action=edit
Bug 16111: Further fixes to the RSS to make feed work
- fixed links per the WC3 spec
- fix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Liz Rea changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #57 from Liz Rea ---
Created attachment 92436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92436&action=edit
Bug 16111: Adjust some more filters
Signed-off-by: Liz Rea
--
You are receiving this ma
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #58 from Liz Rea ---
Created attachment 92437
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92437&action=edit
Bug 16111: Replace & with &
Signed-off-by: Liz Rea
--
You are receiving this mail becau
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Liz Rea changed:
What|Removed |Added
Attachment #92050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Liz Rea changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #55 from Katrin Fischer ---
> > Shouldn't the URL be in the link's href attribute ?
>
> The element is an empty element, it contains attributes only.
> So yes.
The validators don't like that and every RSS documentation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #54 from Katrin Fischer ---
I've been using the Feed validator here. There are still 2 issues:
https://validator.w3.org/feed/check.cgi
- The link element in the item element is wrong with the href, it shoudl be
url
- Th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #53 from Jonathan Druart
---
Created attachment 92366
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92366&action=edit
Bug 16111: Replace & with &
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #51
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Attachment #92362|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #49
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Christopher Brannon changed:
What|Removed |Added
CC|cbran...@cdalibrary.org |
--
You are receivin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #47 from Jonathan Druart
---
Created attachment 92362
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92362&action=edit
Bug 16111: Adjust some more filters
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #46
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |jonathan.dru...@bugs.koha-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Attachment #81285|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #43 from Owen Leonard ---
Jonathan could you take a stab at rebasing this? I got lost.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Andrew Isherwood changed:
What|Removed |Added
Attachment #78579|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Andrew Isherwood changed:
What|Removed |Added
Attachment #78580|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Andrew Isherwood changed:
What|Removed |Added
Attachment #78689|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Andrew Isherwood changed:
What|Removed |Added
Attachment #78578|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Andrew Isherwood changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are r
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #37 from Jonathan Druart
---
Created attachment 78689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78689&action=edit
Bug 16111: Replace with http://lists.koha-community.org/cgi-bin/mailman/listinfo/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #36 from Jonathan Druart
---
(In reply to Marcel de Rooy from comment #35)
> -
> - [% timestamp | html %]
> +
> + [% timestamp %]
>
> rss2 => atom here
> Copy and paste ?
Nope, that's the point of these pat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #35 from Marcel de Rooy ---
-
- [% timestamp | html %]
+
+ [% timestamp %]
rss2 => atom here
Copy and paste ?
--
You are receiving this mail because:
You are watching all bug changes.
__
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #34
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #33 from Julian Maurice ---
Comment on attachment 78579
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78579
Bug 16111: Fix atom support
Review of attachment 78579:
-->
(https://bugs.koha-community.o
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Blocks||21332
Referenced Bugs:
htt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #78581|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #30 from Owen Leonard ---
Created attachment 78579
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78579&action=edit
Bug 16111: Fix atom support
Signed-off-by: Owen Leonard
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #77057|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #31 from Owen Leonard ---
Created attachment 78580
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78580&action=edit
Bug 16111: Remove 'rss2' which should be 'rss' or 'atom'
Signed-off-by: Owen Leonard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #32 from Owen Leonard ---
Created attachment 78581
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78581&action=edit
Bug 16111: (follow-up) Fixes for simplicity and validation
This patch simplifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Cab Vinton changed:
What|Removed |Added
CC||bibli...@gmail.com
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #27 from Owen Leonard ---
Created attachment 77060
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77060&action=edit
Bug 16111: (follow-up) Fixes for simplicity and validation
This patch simplifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Signed Off |Needs Signoff
--
You are re
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #76160|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #25 from Owen Leonard ---
Created attachment 77058
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77058&action=edit
Bug 16111: Fix atom support
Signed-off-by: Owen Leonard
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #26 from Owen Leonard ---
Created attachment 77059
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77059&action=edit
Bug 16111: Remove 'rss2' which should be 'rss' or 'atom'
Signed-off-by: Owen Leonard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #76148|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- Co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #21 from Jonathan Druart
---
Do whatever you want, but my opinion would be to not remove code that could be
fixed easily. To fix the original issue, it's a 3-lines patch ( Bug 16111: Fix
content type for RSS feed ).
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Severity|minor |normal
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #20 from Jonathan Druart
---
Created attachment 76162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76162&action=edit
Bug 16111: Remove 'rss2' which should be 'rss' or 'atom'
--
You are receiving th
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Jonathan Druart changed:
What|Removed |Added
Attachment #49837|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #19 from Jonathan Druart
---
Created attachment 76161
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76161&action=edit
Bug 16111: Fix atom support
--
You are receiving this mail because:
You are watc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #17 from Jonathan Druart
---
I am sorry but we are doing something very wrong here.
The POC patch shows that it is very easy to support atom, whereas the "Revised"
patch is removing all this code.
I would suggest to:
1.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Owen Leonard changed:
What|Removed |Added
Attachment #49629|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marjorie Barry-Vila changed:
What|Removed |Added
CC||marjorie.barry-vila@co
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Christopher Brannon changed:
What|Removed |Added
CC||cbran...@cdalibrary.or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #13 from Nick Clemens ---
Would it be reasonable to fix the RSS here and then move the atom
discussion/fix/removal to another bug report so this one can get through?
--
You are receiving this mail because:
You are watch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
--- Comment #12 from Jonathan Druart
---
The purpose of the POC is to prove it could be fixed quickly.
I think the atom feeds have worked before but have been broken when migrating
to TT.
--
You are receiving this mail because:
Yo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16111
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
1 - 100 of 115 matches
Mail list logo