[Koha-bugs] [Bug 16394] Fix formatting of review.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16394] Fix formatting of review.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Owen is right stating that we decided a while ago not to clean files globally
to avoid conflicts. Tab cleaning is a bit less difficult than perltidy, as it
does keep the lines the same and you can use -w to not see whitespace changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16394] Fix formatting of review.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

--- Comment #1 from Owen Leonard  ---
The staff client templates are full of tab characters, so I don't think we
should file bugs for each one. My understanding of the general practice
regarding indentation is:

- Always remove tab characters from lines which are changed by your patches.

- If you want to make other changes to whitespace or indentation, submit a
separate patch.

Submitting whitespace fixes is always going to create merge problems for
pending patches, so we should check http://splitter.koha-community.org for
pending patches.

It would be interesting if the splitter tool could show a list of templates
which have /no/ patches in the queue. Those would be great candidates for
whitespace fix patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16394] Fix formatting of review.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16238, 16241


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238
[Bug 16238] Upgrade jQuery in staff client: use .prop() instead of .attr()
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16241
[Bug 16241] Move staff client CSS out of language directory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16394] Fix formatting of review.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16394

Marc Véron  changed:

   What|Removed |Added

 Depends on||16381


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16381
[Bug 16381] Fix capitalization on tags review page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/