[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon--- via Koha-bugs]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Janusz Kaczmarek  changed:

   What|Removed |Added

 Blocks||24424


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424
[Bug 24424] Advanced editor - interface hangs as "Loading" when given an
invalid bib number
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||After this patch,
  release notes||frameworks will be handled
   ||correctly by the advanced
   ||cataloguing editor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Martin Renvoize  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
   Priority|P5 - low|P2
 Resolution|--- |FIXED
   Severity|major   |enhancement

--- Comment #28 from Martin Renvoize  ---
Marking this as an enhancement as although I do agree it's an important issue
to be resolved, it would be an unexpected change for existing users on the
stable branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #27 from Jonathan Druart  
---
Created attachment 79621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79621=edit
Bug 16424: (follow-up) remove wrong copyright statements

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #26 from Jonathan Druart  
---
Copyright is wrong in svc/bib_framework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #25 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #24 from Katrin Fischer  ---
Created attachment 79504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79504=edit
Bug 16424: (QA follow-up) Use Modern::Perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79297|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 79502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79502=edit
Bug 16424: Handle framework code properly also when adding a new record

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79298|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 79503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79503=edit
Bug 16424: Update default values in advanced editor when changing frameworks.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79296|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 79501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79501=edit
Bug 16424: Make the svc/bib service keep the existing framework code

Previously the framework code would have been reset when the record was saved,
but that seems to have been a mistake.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79295|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 79500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79500=edit
Bug 16424: Minor CSS change for the advanced editor Settings menu

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #79294|0   |1
is obsolete||

--- Comment #19 from Katrin Fischer  ---
Created attachment 79499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79499=edit
Bug 16424: Add framework support to advanced MARC editor

Keeps the selected framework, allows selecting another and validates the record
using the correct framework. Contains additional minor tweaks to display proper
error messages.

To test:
1. Add a record with a non-default framework in the basic editor.
2. Switch to advanced editor and make sure the settings menu displays the
correct framework.
3. Save the record and confirm that the framework code did not change.
4. Change the framework and save the record again.
5. Verify that the framework code changed.
6. Change one framework to make an extra field mandatory.
7. Make sure that the field is required in the editor when the framework above
is selected but not when another framework is selected.

Signed-off-by: Michal Denar 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Martin Renvoize  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe
   |y.org   |.com
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #15 from Michal Denar  ---
Created attachment 79295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79295=edit
Bug 16424: Minor CSS change for the advanced editor Settings menu

Signed-off-by: Michal Denar 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #18 from Michal Denar  ---
Created attachment 79298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79298=edit
Bug 16424: Update default values in advanced editor when changing frameworks.

Signed-off-by: Michal Denar 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #17 from Michal Denar  ---
Created attachment 79297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79297=edit
Bug 16424: Handle framework code properly also when adding a new record

Signed-off-by: Michal Denar 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Michal Denar  changed:

   What|Removed |Added

  Attachment #79009|0   |1
is obsolete||
  Attachment #79010|0   |1
is obsolete||
  Attachment #79011|0   |1
is obsolete||
  Attachment #79017|0   |1
is obsolete||
  Attachment #79022|0   |1
is obsolete||

--- Comment #14 from Michal Denar  ---
Created attachment 79294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79294=edit
Bug 16424: Add framework support to advanced MARC editor

Keeps the selected framework, allows selecting another and validates the record
using the correct framework. Contains additional minor tweaks to display proper
error messages.

To test:
1. Add a record with a non-default framework in the basic editor.
2. Switch to advanced editor and make sure the settings menu displays the
correct framework.
3. Save the record and confirm that the framework code did not change.
4. Change the framework and save the record again.
5. Verify that the framework code changed.
6. Change one framework to make an extra field mandatory.
7. Make sure that the field is required in the editor when the framework above
is selected but not when another framework is selected.

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #16 from Michal Denar  ---
Created attachment 79296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79296=edit
Bug 16424: Make the svc/bib service keep the existing framework code

Previously the framework code would have been reset when the record was saved,
but that seems to have been a mistake.

Signed-off-by: Michal Denar 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #13 from Michal Denar  ---
Ere,
thank You for explanation. I tried ot again and Rancor works as You describe.

Good work.

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #12 from Ere Maijala  ---
Hi Michal,
Thanks for testing. Validation is only done when the record is saved, so you
won't see notification about missing fields until you try to save the record.
If you are able to save the record without errors after selecting a framework
that requires a field that the record does not contain, there's an error. I
couldn't tell from the video since I don't know for sure which fields are
required in the frameworks you used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

--- Comment #11 from Michal Denar  ---
Hi Ere,
I'm testing this patch. But at point 
7. Make sure that the field is required in the editor when the framework above
is selected but not when another framework is selected I don't see any changes.
Short video is more than thousands words: http://recordit.co/qAwNt4BQtd

Is necessary to save record between change of framework?

Thank You

Mike

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #10 from Ere Maijala  ---
Created attachment 79022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79022=edit
Bug 16424: Update default values in advanced editor when changing frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

 Blocks||21365


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21365
[Bug 21365] Advanced MARC Editor - Rancor - BiblioAddsAuthorities not working
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #9 from Ere Maijala  ---
Created attachment 79017
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79017=edit
Bug 16424: Handle framework code properly also when adding a new record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #8 from Ere Maijala  ---
Ok, moved the css change to a separate patch. Please remember to regenerate css
when testing to make the settings menu in the advanced editor look good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78978|0   |1
is obsolete||

--- Comment #7 from Ere Maijala  ---
Created attachment 79011
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79011=edit
Bug 16424: Make the svc/bib service keep the existing framework code

Previously the framework code would have been reset when the record was saved,
but that seems to have been a mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

  Attachment #78977|0   |1
is obsolete||

--- Comment #5 from Ere Maijala  ---
Created attachment 79009
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79009=edit
Bug 16424: Add framework support to advanced MARC editor

Keeps the selected framework, allows selecting another and validates the record
using the correct framework. Contains additional minor tweaks to display proper
error messages.

To test:
1. Add a record with a non-default framework in the basic editor.
2. Switch to advanced editor and make sure the settings menu displays the
correct framework.
3. Save the record and confirm that the framework code did not change.
4. Change the framework and save the record again.
5. Verify that the framework code changed.
6. Change one framework to make an extra field mandatory.
7. Make sure that the field is required in the editor when the framework above
is selected but not when another framework is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #6 from Ere Maijala  ---
Created attachment 79010
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79010=edit
Bug 16424: Minor CSS change for the advanced editor Settings menu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/css/staff-global.css

Ere, changes to .css should not be committed to avoid such conflicts. It may be
better to have a step to the test plan to remind testers to regenerate it. If
you want it to be testable in a sandbox you can provide the css changes on a
separate patch (to ease rebase and QA)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #3 from Ere Maijala  ---
The first patch contains the actual functionality. The second one is not
necessary for this to work, but fixes the issue that was an apparent bug in the
service.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #2 from Ere Maijala  ---
Created attachment 78978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78978=edit
Bug 16424: Make the svc/bib service keep the existing framework code

Previously the framework code would have been reset when the record was saved,
but that seems to have been a mistake.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

--- Comment #1 from Ere Maijala  ---
Created attachment 78977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78977=edit
Bug 16424: Add framework support to advanced MARC editor

Keeps the selected framework, allows selecting another and validates the record
using the correct framework. Contains additional minor tweaks to display proper
error messages.

To test:
1. Add a record with a non-default framework in the basic editor.
2. Switch to advanced editor and make sure the settings menu displays the
correct framework.
3. Save the record and confirm that the framework code did not change.
4. Change the framework and save the record again.
5. Verify that the framework code changed.
6. Change one framework to make an extra field mandatory.
7. Make sure that the field is required in the editor when the framework above
is selected but not when another framework is selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Ere Maijala  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |ere.maij...@helsinki.fi
 CC||ere.maij...@helsinki.fi
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Jonathan Druart  changed:

   What|Removed |Added

Version|3.22|unspecified
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|minor   |major
 Depends on||11559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559
[Bug 11559] Professional cataloger's interface
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16424] Advanced editor reverts records back to Default framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16424

Katrin Fischer  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m, katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/