https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16441

            Bug ID: 16441
           Summary: C4::Letters::getletter is not plack safe
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: jonathan.dru...@bugs.koha-community.org
          Reporter: jonathan.dru...@bugs.koha-community.org
        QA Contact: testo...@bugs.koha-community.org
        Depends on: 9452
            Blocks: 7172

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to remove it.
It won't be a big deal to hit the DBMS to get a valid letter when needed.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172
[Bug 7172] Omnibus for Plack variable scoping problems
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452
[Bug 9452] C4::Letters does not function under Plack
-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to