[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #47 from Katrin Fischer --- It looks like this is still valid: Koha/Edifact/Order.pm:use Readonly qw( Readonly ); Koha/Edifact/Order.pm:Readonly::Scalar my $seg_terminator => q{'};

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Assignee|mtomp...@hotmail.com

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #73447|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #73444|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #73446|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #45 from M. Tompsett --- Created attachment 73452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73452=edit Bug 16588: Follow up with more missing changes Hunting for _INDEX and

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #73445|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #40 from M. Tompsett --- Still some issues to work on. Please do not think I am finished. Sorry for being spammy. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #57516|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #57519|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #57518|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Attachment #57517|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #34 from M. Tompsett --- The removal of Readonly::XS is actually a separate problem, in that even if we were keeping Readonly, we shouldn't be using or checking for Readonly::XS. See bug 20103

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #32 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #31) > (In reply to Jonathan Druart from comment #30) > > (In reply to Srdjan Jankovic from comment #29) >

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #31 from Srdjan Jankovic --- (In reply to Jonathan Druart from comment #30) > (In reply to Srdjan Jankovic from comment #29) > > Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #30 from Jonathan Druart --- (In reply to Srdjan Jankovic from comment #29) > Is there any reason we have BIBLIOS_INDEX and AUTHORITIES_INDEX defined in >

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Srdjan Jankovic changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #27 from Jonathan Druart --- Created attachment 57518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57518=edit Bug 16588 Remove Readonly from Edifact::Order

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #26 from Jonathan Druart --- Created attachment 57517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57517=edit Bug 16588: Koha::SearchEngine must return a

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #28 from Jonathan Druart --- Created attachment 57519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57519=edit Bug 16588: Remove Readonly from the dependency

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What|Removed |Added Attachment #55935|0

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Colin Campbell changed: What|Removed |Added Attachment #55934|0

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #22 from Mirko Tietgen --- Can we please not re-discuss this from the beginning now that we are almost there? It was brought up months ago and now it got a lot of work put into it. I need this

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) perl core* -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #20 from Jonathan Druart --- (In reply to Colin Campbell from comment #19) > WHY?? > > Using constant instead of readonly is more bug prone - If you must remove > readonly

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #19 from Colin Campbell --- WHY?? Using constant instead of readonly is more bug prone - If you must remove readonly use simple scalars instead of constant -- You are receiving this

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added Attachment #53638|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added Attachment #54477|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added Attachment #53637|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Nick Clemens changed: What|Removed |Added Attachment #53636|0 |1

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Marc Véron changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #13 from Jonathan Druart --- Created attachment 54477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54477=edit Bug 16588: (follow-up) Remove Readonly from

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #12 from M. Tompsett --- After applying this, there was still Readonly in Koha/Edifact/Order.pm, which is related in part to bug 16703's adding it back in, I think. Does _const really need Readonly

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 --- Comment #10 from Jonathan Druart --- (In reply to Colin Campbell from comment #9) > Would it not be preferable to add Readonly rather than replace usages of > Readonly by constant

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Colin Campbell changed: What|Removed |Added CC|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 Jonathan Druart changed: What|Removed |Added