[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Bug 16764 depends on bug 8352, which changed state. Bug 8352 Summary: Add automatic printing of 'hold to pull' notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Fridolin SOMERSchanged: What|Removed |Added Status|Pushed to Stable|RESOLVED CC||fridolin.som...@biblibre.co ||m Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Nick Clemenschanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- Awesome work all, pushed to stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Katrin Fischerchanged: What|Removed |Added Attachment #69141|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 70090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70090=edit Bug 16764 - Update printers administration page This patch updates the template for printers administration according to current interface guidelines. - Custom JavaScript form validation is removed in favor of the built-in form validation plugin. - Printer-specific header search form is removed, along with server-side pagination code. The functionality of both is now taken care of the adding DataTables sorting and pagination to the table. - Edit and delete links are styled as Boostrap buttons with Font Awesome icons. - Confirmation dialogs are updated to use Font Awesome icons. To test properly you will need to add multiple printers. - Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no menu link for the page). - When no printers exist you should see a message dialog saying so. - Add a new printer. Confirm that printer name and queue are required fields. - After adding multiple printers, confirm that the table of printers is correctly sorted and searched by the DataTables plugin. - Delete a printer and verify that the confirmation dialog is correctly styled. Signed-off-by: Marc Véron Update: rebased and updated Bootstrap 3 classes Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=16765 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #8 from Owen Leonard --- I'd like to put this back in the queue since Bug 8352 has been idle for so long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Owen Leonardchanged: What|Removed |Added Attachment #52511|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 69141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69141=edit Bug 16764 - Update printers administration page This patch updates the template for printers administration according to current interface guidelines. - Custom JavaScript form validation is removed in favor of the built-in form validation plugin. - Printer-specific header search form is removed, along with server-side pagination code. The functionality of both is now taken care of the adding DataTables sorting and pagination to the table. - Edit and delete links are styled as Boostrap buttons with Font Awesome icons. - Confirmation dialogs are updated to use Font Awesome icons. To test properly you will need to add multiple printers. - Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no menu link for the page). - When no printers exist you should see a message dialog saying so. - Add a new printer. Confirm that printer name and queue are required fields. - After adding multiple printers, confirm that the table of printers is correctly sorted and searched by the DataTables plugin. - Delete a printer and verify that the confirmation dialog is correctly styled. Signed-off-by: Marc Véron Update: rebased and updated Bootstrap 3 classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Owen Leonardchanged: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17845 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 --- Comment #6 from Kyle M Hall--- (In reply to Jonathan Druart from comment #5) > (In reply to Kyle M Hall from comment #4) > > Bug 8352 revamps the printer administration as well. > > Yes but it is in discussion and does no longer apply. What do you suggest? Since this is a purely cosmetic change, I would appreciate if we held off on it for bug 8352. I haven't had time to get back to that one recently, but I'm still pursuing it. The blocker on it is getting the needed Perl libs packaged for Debian. I really need s For Dummies version of getting libraries packaged, but alas, there is none ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |In Discussion CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- (In reply to Kyle M Hall from comment #4) > Bug 8352 revamps the printer administration as well. Yes but it is in discussion and does no longer apply. What do you suggest? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Kyle M Hallchanged: What|Removed |Added CC||k...@bywatersolutions.com Depends on||8352 --- Comment #4 from Kyle M Hall --- Bug 8352 revamps the printer administration as well. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 [Bug 8352] Add automatic printing of 'hold to pull' notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Marc Véronchanged: What|Removed |Added Attachment #52500|0 |1 is obsolete|| --- Comment #3 from Marc Véron --- Created attachment 52511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52511=edit Bug 16764 - Update printers administration page This patch updates the template for printers administration according to current interface guidelines. - Custom JavaScript form validation is removed in favor of the built-in form validation plugin. - Printer-specific header search form is removed, along with server-side pagination code. The functionality of both is now taken care of the adding DataTables sorting and pagination to the table. - Edit and delete links are styled as Boostrap buttons with Font Awesome icons. - Confirmation dialogs are updated to use Font Awesome icons. To test properly you will need to add multiple printers. - Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no menu link for the page). - When no printers exist you should see a message dialog saying so. - Add a new printer. Confirm that printer name and queue are required fields. - After adding multiple printers, confirm that the table of printers is correctly sorted and searched by the DataTables plugin. - Delete a printer and verify that the confirmation dialog is correctly styled. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 --- Comment #2 from Owen Leonard--- In case it helps with testing: INSERT INTO `printers` (`printername`, `printqueue`, `printtype`) VALUES ('Printer 01', 'print_queue_01', 'type01'), ('Printer 02', 'print_queue_02', 'type02'), ('Printer 03', 'print_queue_03', 'type03'), ('Printer 04', 'print_queue_04', 'type04'), ('Printer 05', 'print_queue_05', 'type05'), ('Printer 06', 'print_queue_06', 'type06'), ('Printer 07', 'print_queue_07', 'type07'), ('Printer 08', 'print_queue_08', 'type08'), ('Printer 09', 'print_queue_09', 'type09'), ('Printer 10', 'print_queue_10', 'type10'), ('Printer 11', 'print_queue_11', 'type11'), ('Printer 12', 'print_queue_12', 'type12'), ('Printer 13', 'print_queue_13', 'type13'), ('Printer 14', 'print_queue_14', 'type14'), ('Printer 15', 'print_queue_15', 'type15'), ('Printer 16', 'print_queue_16', 'type16'), ('Printer 17', 'print_queue_17', 'type17'), ('Printer 18', 'print_queue_18', 'type18'), ('Printer 19', 'print_queue_19', 'type19'), ('Printer 20', 'print_queue_20', 'type20'), ('Printer 21', 'print_queue_21', 'type21'), ('Printer 22', 'print_queue_22', 'type22'), ('Printer 23', 'print_queue_23', 'type23'), ('Printer 24', 'print_queue_24', 'type24'), ('Printer 25', 'print_queue_25', 'type25'); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Owen Leonardchanged: What|Removed |Added CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16764] Update printers administration page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764 --- Comment #1 from Owen Leonard--- Created attachment 52500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52500=edit Bug 16764 - Update printers administration page This patch updates the template for printers administration according to current interface guidelines. - Custom JavaScript form validation is removed in favor of the built-in form validation plugin. - Printer-specific header search form is removed, along with server-side pagination code. The functionality of both is now taken care of the adding DataTables sorting and pagination to the table. - Edit and delete links are styled as Boostrap buttons with Font Awesome icons. - Confirmation dialogs are updated to use Font Awesome icons. To test properly you will need to add multiple printers. - Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no menu link for the page). - When no printers exist you should see a message dialog saying so. - Add a new printer. Confirm that printer name and queue are required fields. - After adding multiple printers, confirm that the table of printers is correctly sorted and searched by the DataTables plugin. - Delete a printer and verify that the confirmation dialog is correctly styled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/