[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-21 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53558|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 53595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53595=edit
Bug 16948: 'Return to batch item deletion' button should only show when there
are items that could not be deleted

To test:

1) Go to Tools --> Batch item deletion
2) Put in an item barcode and click Continue
3) Deselect the item (so that you don't actually delete it) and click Delete
selected items
4) Notice there are two links that say 'Return to batch item deletion' - one as
a link and one as a button.
5) Apply patch and refresh page. You may have to go back and resend the form
6) Button should be gone, only one link shows.
7) Check out the same item that you are testing with to a patron
8) Put the barcode into batch item deletion again and follow the prompts. Do
not deselect it after clicking Continue this time. (It will not be deleted as
it has been checked out).
9) After clicking Delete selected items, you should be redirected and see a
table with the item in it and the reason it can't be deleted. The button and
the link saying 'Return to batch item deletion' should both be present.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-21 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-21 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Claire Gravely  changed:

   What|Removed |Added

  Attachment #53539|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 53558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53558=edit
Bug 16948: 'Return to batch item deletion' button should only show when there
are items that could not be deleted

To test:

1) Go to Tools --> Batch item deletion
2) Put in an item barcode and click Continue
3) Deselect the item (so that you don't actually delete it) and click Delete
selected items
4) Notice there are two links that say 'Return to batch item deletion' - one as
a link and one as a button.
5) Apply patch and refresh page. You may have to go back and resend the form
6) Button should be gone, only one link shows.
7) Check out the same item that you are testing with to a patron
8) Put the barcode into batch item deletion again and follow the prompts. Do
not deselect it after clicking Continue this time. (It will not be deleted as
it has been checked out).
9) After clicking Delete selected items, you should be redirected and see a
table with the item in it and the reason it can't be deleted. The button and
the link saying 'Return to batch item deletion' should both be present.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-21 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16949
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Aleisha Amohia  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-20 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

--- Comment #1 from Aleisha Amohia  ---
Created attachment 53539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53539=edit
Bug 16948: 'Return to batch item deletion' button should only show when there
are items that could not be deleted

To test:

1) Go to Tools --> Batch item deletion
2) Put in an item barcode and click Continue
3) Deselect the item (so that you don't actually delete it) and click Delete
selected items
4) Notice there are two links that say 'Return to batch item deletion' - one as
a link and one as a button.
5) Apply patch and refresh page. You may have to go back and resend the form
6) Button should be gone, only one link shows.
7) Check out the same item that you are testing with to a patron
8) Put the barcode into batch item deletion again and follow the prompts. Do
not deselect it after clicking Continue this time. (It will not be deleted as
it has been checked out).
9) After clicking Delete selected items, you should be redirected and see a
table with the item in it and the reason it can't be deleted. The button and
the link saying 'Return to batch item deletion' should both be present.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/