https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Frédéric Demians changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Kyle M Hall changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #16 from Jonathan Druart
---
Created attachment 55325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55325=edit
Bug 17231 - (QA Followup)
Nicer grep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Jonathan Druart changed:
What|Removed |Added
Attachment #55093|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #14 from Nick Clemens ---
(In reply to Jonathan Druart from comment #13)
> So should not we test the regex from ^?
Hmm...we could, but I would still argue for the eval - the downloader
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #13 from Jonathan Druart
---
(In reply to Nick Clemens from comment #12)
> > @@ +109,5 @@
> > > +'fmt' => '43' #webm is the only format
> > >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Nick Clemens changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #12 from Nick Clemens ---
(In reply to Jonathan Druart from comment #10)
> Comment on attachment 55093 [details] [review]
> /youtu\.?be/
> seems easier to read, don't you think?
Yeah, I can
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #11 from Nick Clemens ---
Created attachment 55298
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55298=edit
Bug 17231 - (QA Followup)
Nicer grep
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #10 from Jonathan Druart
---
Comment on attachment 55093
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55093
Bug 17231 - HTML5MediaYouTube should recognize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Claire Gravely changed:
What|Removed |Added
Attachment #55091|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Claire Gravely changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #8 from Claire Gravely ---
(In reply to Nick Clemens from comment #7)
> (In reply to Claire Gravely from comment #6)
> > It now searches ok :), but if the record has two 856 $u (one for a link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #7 from Nick Clemens ---
(In reply to Claire Gravely from comment #6)
> It now searches ok :), but if the record has two 856 $u (one for a link and
> one for a video for example) it does not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #6 from Claire Gravely ---
(In reply to Nick Clemens from comment #5)
> Fixed! That was bad grepping on my part, worked cause it matched everything
> :-)
>
> I added an eval to catch those
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #5 from Nick Clemens ---
Fixed! That was bad grepping on my part, worked cause it matched everything :-)
I added an eval to catch those errors as well, say if you link to something
like:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Nick Clemens changed:
What|Removed |Added
Attachment #55076|0 |1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #3 from Claire Gravely ---
(In reply to Claire Gravely from comment #2)
> After applying the patch: I get the following error when doing a catalogue
> search on the intranet for a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Claire Gravely changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Nick Clemens changed:
What|Removed |Added
Patch complexity|---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
--- Comment #1 from Nick Clemens ---
Created attachment 55076
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55076=edit
Bug 17231 - HTML5MediaYouTube should recognize youtu.be links from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17231
Nick Clemens changed:
What|Removed |Added
Status|NEW
23 matches
Mail list logo