[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Jonathan Druart changed: What|Removed |Added Blocks||21684 Referenced Bugs:

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #58 from Marcel de Rooy --- Thx Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.or

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #52 from Jonathan Druart --- Created attachment 62490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62490&action=edit Bug 17669: Add new switch to crontab example and debian daily cron file The new s

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #54 from Jonathan Druart --- Created attachment 62492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62492&action=edit Bug 17669: [QA Follow-up] Rename --temp-uploads-override parameter As requested b

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #53 from Jonathan Druart --- Created attachment 62491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62491&action=edit Bug 17669: [QA Follow-up] Rename preference by removing underscores Requested by

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #57 from Jonathan Druart --- Created attachment 62495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62495&action=edit Bug 17669: Remove warning 'variable $kohaobj masks earlier declaration in same sco

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #56 from Jonathan Druart --- Created attachment 62494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62494&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzill

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #55 from Jonathan Druart --- Created attachment 62493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62493&action=edit Bug 17669: [QA Follow-up] Allow zero in temp-uploads-days As requested by QA on c

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #51 from Jonathan Druart --- Created attachment 62489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62489&action=edit Bug 17669: Incorporate the changes in cleanup_database Two command line options a

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #49 from Jonathan Druart --- Created attachment 62487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62487&action=edit Bug 17669: Small change to sub delete Instead of looping through _resultset here

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #50 from Jonathan Druart --- Created attachment 62488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62488&action=edit Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_depend

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Jonathan Druart changed: What|Removed |Added Attachment #61465|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #47 from Marcel de Rooy --- Joubu: hi; any chance to have another look at the qa changes on the upload reports 17669/18300 ? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Signed Off --- Comment #46

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #45 from Marcel de Rooy --- Created attachment 61819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61819&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #61818|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #61809|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #43 fr

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #42 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #39) > If you insist now on further tests of the return value, I would rather move > the last follow-up somewhere else. Suppose I do that on 18300? --

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #61805|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #40 from Marcel de Rooy --- Hmm Still a very small thing: if I come across an undef, pass -1 instead of 0E0 (two places?) -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #39 from Marcel de Rooy --- If you insist now on further tests of the return value, I would rather move the last follow-up somewhere else. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #38 from Marcel de Rooy --- Created attachment 61805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61805&action=edit Bug 17669: [QA Follow-up] More consistency in return values of delete See Bugzilla

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #37 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #36) > Very small thing again, delete_temporary returns true if no errors occur. I > am wondering if we should not return true if the delete worked. >

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #36 from Jonathan Druart --- Very small thing again, delete_temporary returns true if no errors occur. I am wondering if we should not return true if the delete worked. 92 } elsif( !defined($days) || $days eq '' )

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #61742|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #34 from Marcel de Rooy --- Created attachment 61742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61742&action=edit Bug 17669: [QA Follow-up] Allow zero in temp-uploads-days As requested by QA on com

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #61727|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #33 from Jonathan Druart --- I did not find where it is referenced, not in the syspref's description nor POD of the script nor tests. To me today is 0, not -1 -- You are receiving this mail because: You are watching a

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #32 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #31) > Marcel, just wondering: It seems that there is no way to delete *all* > temporary uploads (the ones from today). If we handle differently 0 and

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #31 from Jonathan Druart --- Marcel, just wondering: It seems that there is no way to delete *all* temporary uploads (the ones from today). If we handle differently 0 and NULL for UploadPurgeTemporaryFilesDays, it would

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #30 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > The pref name contains '_', it's unusual. Not blocker > > I'd rename the option's name of the script with --temp-uploads-days > (currently --te

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #28 from Marcel de Rooy --- Created attachment 61729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61729&action=edit Bug 17669: [QA Follow-up] Rename preference by removing underscores Requested by QA

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #29 from Marcel de Rooy --- Created attachment 61730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61730&action=edit Bug 17669: [QA Follow-up] Rename --temp-uploads-override parameter As requested by

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #27 from Marcel de Rooy --- Created attachment 61727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61727&action=edit Bug 17669: Rename preference by removing underscores Requested by QA on comment25.

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #26 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #25) > Right, I forgot that, makes sense. > It sounds weird to have ->delete behaving differently than > Koha::Objects->delete, not blocker Should be

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #25 from Jonathan Druart --- Right, I forgot that, makes sense. It sounds weird to have ->delete behaving differently than Koha::Objects->delete, not blocker The pref name contains '_', it's unusual. Not blocker I'd re

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #24 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #23) > Why do we need to overwrite Koha::UploadedFiles->delete finally? Because I want to call Koha::UploadedFile->delete and not DBIx::delete. Otherw

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Attachment #61243|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Attachment #61242|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Attachment #61240|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Attachment #61241|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added Attachment #61239|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #17 from Marcel de Rooy --- (In reply to Mirko Tietgen from comment #16) > I applied all patches and ran the test, I get > > prove t/db_dependent/Upload.t > t/db_dependent/Upload.t .. 1/11 The method delete_temporary is

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net --

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Blocks||18300 Referenced Bugs: h

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58812|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58811|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58810|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58176|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #11 from Marcel de Rooy --- Created attachment 61240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61240&action=edit Bug 17669: Small change to sub delete Instead of looping through _resultset here an

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are recei

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Bug 17669 depends on bug 17501, which changed state. Bug 17501 Summary: Koha Objects for uploaded files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501 What|Removed |Added --

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #9 from Marcel de Rooy --- Rebased on top of changes to 17501 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58179|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58178|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Attachment #58177|0 |1 is obsolete|

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Component|Architecture, internals,|Tools |a

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #4 from Marcel de Rooy --- Created attachment 58179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58179&action=edit Bug 17669: Add new switch to crontab example and debian daily cron file The new swit

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #1 from Marcel de Rooy --- Created attachment 58176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58176&action=edit Bug 17669: Introduce new preference for purging temp uploads The new preference is:

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #2 from Marcel de Rooy --- Created attachment 58177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58177&action=edit Bug 17669: Add delete_temporary method with unit tests Test plan: Run t/db_dependent

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 --- Comment #3 from Marcel de Rooy --- Created attachment 58178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58178&action=edit Bug 17669: Incorporate the changes in cleanup_database Two command line options are

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added Depends on||17501 Referenced Bugs: h

[Koha-bugs] [Bug 17669] Add purging temporary uploads to cleanup_database

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17669 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community