[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Lari Taskula changed: What|Removed |Added Blocks||20490

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #44 from Katrin Fischer --- If someone would be willing to test and sign-off for 16.11.x, I am willing to push this :) -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #43 from Francesco Rivetti --- (In reply to Jonathan Druart from comment #41) > (In reply to Katrin Fischer from comment #40) > > This seems to use some new constructs, is this safe for backporting to > >

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #42 from Katrin Fischer --- I will watch this a bit longer and consider pushing it to the next 16.11.x release. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #41 from Jonathan Druart --- (In reply to Katrin Fischer from comment #40) > This seems to use some new constructs, is this safe for backporting to > 16.11.x? That would need to

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #39 from Petter Goksøyr Åsen --- (In reply to Petter Goksøyr Åsen from comment #38) > > Pushed to master for 17.05, thanks Francesco! > > It does not appear to be pushed: >

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #38 from Petter Goksøyr Åsen --- > Pushed to master for 17.05, thanks Francesco! It does not appear to be pushed: http://git.koha-community.org/gitweb/?p=koha.git;a=shortlog -- You are

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #35 from Jonathan Druart --- Created attachment 60545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60545=edit Bug 17941 don't compute priority more than

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #36 from Jonathan Druart --- Created attachment 60546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60546=edit Bug 17941 add tests to cover the optimization

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Jonathan Druart changed: What|Removed |Added Attachment #60472|0

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Attachment #60192|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Attachment #60457|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Attachment #60191|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Attachment #60190|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added Attachment #60189|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Status|In Discussion |Needs

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #29 from Francesco Rivetti --- (In reply to M. Tompsett from comment #26) > So, if you could add a test which triggers check 8, that would be good. done, sorry it took a while! I ended up adding a new

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #28 from Francesco Rivetti --- Created attachment 60457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60457=edit Bug 17941 add tests to cover the optimization of the nested loop the new

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #27 from Francesco Rivetti --- (In reply to M. Tompsett from comment #26) > As you can see, I added print statements, "check 8" is not triggered. oh great, got it. Will do asap and add a new patch F --

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #24 from M. Tompsett --- Comment on attachment 60191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60191 Bug 17941 typo Review of attachment 60191: -->

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #25 from M. Tompsett --- Comment on attachment 60192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60192 Bug 19741 more typos Review of attachment 60192: -->

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #23 from M. Tompsett --- Comment on attachment 60189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60189 Bug 17941 avoid scanning the full cartesian product Review of attachment

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Attachment #60188|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #20 from Francesco Rivetti --- Created attachment 60190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60190=edit Bug 17941 don't compute priority more than needed -- You are receiving

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #22 from Francesco Rivetti --- Created attachment 60192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60192=edit Bug 19741 more typos -- You are receiving this mail because: You are

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #21 from Francesco Rivetti --- Created attachment 60191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60191=edit Bug 17941 typo -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Attachment #59740|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #18 from Francesco Rivetti --- Created attachment 60188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60188=edit Bug 17941 Adding PureFunctions functionality -- You are receiving this

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Attachment #60181|0 |1

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #17 from Francesco Rivetti --- as per Joubu request on irc, sending the patches again via git-bz -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #14 from Francesco Rivetti --- Created attachment 60184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60184=edit BZ 17941 typo -- You are receiving this mail because: You are watching

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #16 from Francesco Rivetti --- Created attachment 60186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60186=edit BZ 17941 avoid scanning the full cartesian product when a item match a

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #15 from Francesco Rivetti --- Created attachment 60185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60185=edit BZ 17941 don't compute priority more than needed -- You are receiving

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #13 from Francesco Rivetti --- I found few more spot where some optimization was easy to add, and should definitely make it faster. I still think using pure functions helps in general, but this is probably a

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #12 from Francesco Rivetti --- Created attachment 60181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60181=edit local transformation that will greatly improve the performance -- You

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #11 from Francesco Rivetti --- (In reply to Alex Sassmannshausen from comment #10) > - Documentation for Attributes mentions it is experimental and the internal > API may change. We may need to consider

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Alex Sassmannshausen changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #9 from Petter Goksøyr Åsen --- Some adittional evidence from testings Fransesco's patch: Here are the stats of cache hits/misses from one call to /svc/checkouts (on a patron with 5

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Francesco Rivetti changed: What|Removed |Added CC|

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #7 from Petter Goksøyr Åsen --- (In reply to Jonathan Druart from comment #6) > Hum, are you sure this is Plack-compatible? It should be. I've been testing under Plack today without

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #6 from Jonathan Druart --- Hum, are you sure this is Plack-compatible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #5 from Petter Goksøyr Åsen --- (In reply to Jonathan Druart from comment #4) > No do not wait, release as soon as you can :) OK, for the adventurous:

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #4 from Jonathan Druart --- (In reply to Petter Goksøyr Åsen from comment #3) > We do belive this patch is a good step forward, but we will test it > extensivly in staging

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #3 from Petter Goksøyr Åsen --- Hi Jonathan. Thanks for looking into this! We were actually working on this problem right now, so I have some information. The code in question is quite

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 --- Comment #1 from Jonathan Druart --- Created attachment 59740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59740=edit Try to recreate CanBookBeRenewed perf issue --

[Koha-bugs] [Bug 17941] CanBookBeRenewed is very inefficient/slow

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17941 Jonathan Druart changed: What|Removed |Added CC|