[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #10 from Alex Buckley  ---
(in reply to M.Tompsett in comment 5)

In the most recent commit patch I have attached to this bug I removed the
inline styling into an internal style sheet at the top of the acqui-home.tt
file.

Additionally I removed the errant warn from the acqui-home.pl script.

Test plan:
1. From the main page of the staff client click go to More->Acquisitions
(making sure there is no currency and budget and fund in the Koha database.
Also make sure you are logged in as a superlibrarian user not the database
administrator).

2. Notice the yellow warning messages: One telling the user to create a
currency and the other informing the user to create a budget it doesn't say you
have to create a fund as well which could be confusing for new users after they
have created the budget).

3. Apply this bug. 

4. Refresh the Acquisitions page and you will see a message telling the user to
specify a currency outside a div box, whilst the other is in a div box (with
the Koha staff client light grey/blue background colour). The message inside
the coloured div box contains numbered links clearly showing what the user must
do to set up acquisitions. Each link opens in a new tab, saving the user from
having to go back to the main acquisitions page constantly. 

5. Create a currency

6. Refresh the main Acquisitions page and notice that the currency notice has
disappeared. 

7. Click the two links to create a budget and fund then refresh the main
acquisitions page and the coloured div message box has disappeared because the
user has set up the Acquisitions successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #9 from Alex Buckley  ---
Created attachment 59992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59992=edit
Bug 18002 - Removed errant warn and inline styling into an internal style sheet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #8 from Alex Buckley  ---
Please disregard comment 7 as I was logging in as the database administrator
and so the acquisitions message was being displayed constantly as I was not
tied to a particular branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18060

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #7 from Alex Buckley  ---
(in reply to M.Tompsett in comment 5)

An interesting feature I have just noticed is that loop_budget is always
returned as null so that the acquisitionsModal div is always displayed even if
the user has created a budget.

On my system this is not specific to bug 18002, I also get it when testing on
my master branch, as the warning telling the user to define a budget is
displayed even if there are multiple budgets.

Do you also find the message appears even when you have created a budget?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com,
   ||oleon...@myacpl.org

--- Comment #6 from M. Tompsett  ---
I'm adding Owen for feedback on the inline styling, as he is much more
experienced with making things pretty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #5 from M. Tompsett  ---
Comment on attachment 59911
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59911
Bug 18002 - Removed the Javascript preventing the display of currency and
acquisition setup messages at the same time

Review of attachment 59911:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18002=59911)
-

::: acqui/acqui-home.pl
@@ +107,4 @@
>  push @budget_loop, $budget;
>  }
>  
> +warn \@budget_loop;

usually a plain warn is a bad idea. I believe other code looks like:
$debug && ...

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt
@@ +103,4 @@
>  [% INCLUDE 'budgets-active-currency.inc' hide = 'yes' %]
>  [% UNLESS ( loop_budget ) %]
>  [% IF ( CAN_user_acquisition_period_manage ) %]
> + style="z-index:1;background-color:#EDF4F6;padding:20px;width:60%;height:30%;position:fixed;align:center;left:auto;top:auto;right:auto;bottom:10%;">

Inline styling is not really a good idea. Though, perhaps Owen can better speak
to that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #3 from Alex Buckley  ---
Created attachment 59910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59910=edit
Bug 18002 - Added in modal box and message (outside of modal box) for when
users first visit Acquisitions.

These messages are in place of the unclear yellow warning messages.

Test plan:
1. Drop and recreate your database

2. Go through the web installer without installing any optional data
values

3. Visit Acquisitions you should see two large yellow warning message
boxes telling you to specify a currency and a budget

4. Apply this patch

5. Refresh the Acquisitions page. Instead of the two yellow warning
messages you will see a message sentence telling you to create a
currency (providing you with a link).
As well as a modal box fading in specifying (with links) the steps you need
to do to set up Acquisitions, in the following order: create budget, fund,
vendor and basket

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #4 from Alex Buckley  ---
Created attachment 59911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59911=edit
Bug 18002 - Removed the Javascript preventing the display of currency and
acquisition setup messages at the same time

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

Alex Buckley  changed:

   What|Removed |Added

 Depends on|17855   |
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17855


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
[Bug 17855] Updated Koha web installer and new onboarding tool feature to guide
users through setting up Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #2 from Alex Buckley  ---
Because users can go through the web installer and onboarding tool then get
straight to work cataloguing items (which is likely to be the first thing they
do) I suggest that the acquisition onboarding functionality (required by this
bug report) be placed as a independent onboarding tool when the user first goes
into the acquisition area to help the user to create a budget, fund, vendor and
basket.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

--- Comment #1 from Owen Leonard  ---
I think it would be nice to be able to skip this step since Koha can function
just fine without the use of acquisitions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/