[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Bug 18182 depends on bug 18427, which changed state. Bug 18427 Summary: Add a primary key to serialitems https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18427 What|Removed |Added

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #28 from Jonathan Druart --- Created attachment 62386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62386=edit Bug 18182: Fix Koha::RefundLostItemFeeRules

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #26 from Jonathan Druart --- Created attachment 62384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62384=edit Bug 18182: [QA Follow-up] Fix a few typos,

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #27 from Jonathan Druart --- Created attachment 62385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62385=edit Bug 18182: Tests all Koha::Objects-based

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added Attachment #62371|0

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #62122|0 |1

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #61753|0 |1

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #62121|0 |1

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #61752|0 |1

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added See

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|gmcha...@gmail.com

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #20 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #17) > Serialitems should have a primary key. Since itemnumber is a unique key, we > could promote it to PK as well. Should

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Attachment #62114|0

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Attachment #62113|0

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #17 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #16) > I have added tests, but one fails on 'Koha::Serial::Item'. > Could you take a look? CREATE TABLE `serialitems` (

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #16 from Jonathan Druart --- I have added tests, but one fails on 'Koha::Serial::Item'. Could you take a look? -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #14 from Jonathan Druart --- Created attachment 62113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62113=edit Bug 18182: Tests all Koha::Objects-based

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #15 from Jonathan Druart --- Created attachment 62114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62114=edit Bug 18182: Fix Koha::RefundLostItemFeeRules --

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #13 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #8) > I decided not to do it, but instead enforce the idea that plurals should be > used. I even changed the wiki about

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #12 from Marcel de Rooy --- Created attachment 61753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61753=edit Bug 18182: [QA Follow-up] Fix a few typos, consistent rollback

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added Attachment #61702|0

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #10 from Marcel de Rooy --- This line in Koha::Objects prevents us from just sending @pks to find: my $result = $self->_resultset()->find($id); Koha::Objects here assumes one id, which is not

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #9 from Marcel de Rooy --- $categorycode, 'Firstname correctly set' ); LOL -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #8 from Tomás Cohen Arazi --- Marcel, I thought a bit more about this and... (In reply to Marcel de Rooy from comment #3) > Great, Tomas. > > Few remarks: > I would rather remove the id column. We

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Attachment #60819|0 |1

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #5) > (In reply to Tomás Cohen Arazi from comment #4) > > Singular classes are not aware of the plural class name. And we need

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #5 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #4) > Singular classes are not aware of the plural class name. And we need the > plural to ->find the created object.

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #3) > Great, Tomas. > > Few remarks: > I would rather remove the id column. We c/should take care of that in the > code. >

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #3 from Marcel de Rooy --- Great, Tomas. Few remarks: I would rather remove the id column. We c/should take care of that in the code. Like: my @pk =

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Change sponsored?|---

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 60819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60819=edit Bug 18182: Make TestBuilder capable of returning Koha::Object

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 60820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60820=edit Bug 18182: (followup) Add POD -- You are receiving this mail

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18182] TestBuilder should be able to return Koha::Object objects

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18182 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz