[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Michaela Sieber  changed:

   What|Removed |Added

 Blocks||35138


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35138
[Bug 35138] Elastic search - add new facets
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Michaela Sieber  changed:

   What|Removed |Added

 CC||michaela.sie...@kit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||This new feature allows
  release notes||librarians with appropriate
   ||permissions to configure
   ||(show/hide/re-order) the
   ||search facets provided by
   ||elasticsearch.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Blocks||22636


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22636
[Bug 22636] Elasticsearch admin page design enhancement
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||Manual,
   ||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #102 from Martin Renvoize  ---
New feature will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #101 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #100)
> Awesome work all!
> 
> Pushed to master for 19.05

\o/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #100 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #99 from Nick Clemens  ---
Created attachment 87141
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87141=edit
Bug 18235: (RM follow-up) fix mappings reset

Without this we could not recreate mappings as there are no defaults for
the additional fields - this restores behavoiur from before patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #97 from Josef Moravec  ---
Created attachment 86956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86956=edit
Bug 18235: (QA follow-up) Restore facet_order for su-geo field in mappings file

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86955|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA

--- Comment #98 from Josef Moravec  ---
Rebased and adapted to bug 22495.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86349|0   |1
is obsolete||

--- Comment #94 from Josef Moravec  ---
Created attachment 86953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86953=edit
Bug 18235: (QA follow-up) Make db update idempotent

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #96 from Josef Moravec  ---
Created attachment 86955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86955=edit
Bug 18253: (QA follow-up) Restore facet_order for su-geo field in mappings file

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86348|0   |1
is obsolete||

--- Comment #93 from Josef Moravec  ---
Created attachment 86952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86952=edit
Bug 18235: Do not call get_facetable_fields excessively

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86347|0   |1
is obsolete||

--- Comment #92 from Josef Moravec  ---
Created attachment 86951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86951=edit
Bug 18235: Update facet_order default value in atomic update

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86350|0   |1
is obsolete||

--- Comment #95 from Josef Moravec  ---
Created attachment 86954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86954=edit
Bug 18235: (QA follow-up) Series facet name after rebase

Bug 19575 changes many field names so "se" facet field became "title-series"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86340|0   |1
is obsolete||

--- Comment #85 from Josef Moravec  ---
Created attachment 86944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86944=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
Rebuild index
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86345|0   |1
is obsolete||

--- Comment #90 from Josef Moravec  ---
Created attachment 86949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86949=edit
Bug 18235: (QA follow-up) Fix POD

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86346|0   |1
is obsolete||

--- Comment #91 from Josef Moravec  ---
Created attachment 86950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86950=edit
Bug 18235: (QA follow-up) Add missing filters

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86343|0   |1
is obsolete||

--- Comment #88 from Josef Moravec  ---
Created attachment 86947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86947=edit
Bug 18235: Add unit tests for get_facetable_fields

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86341|0   |1
is obsolete||

--- Comment #86 from Josef Moravec  ---
Created attachment 86945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86945=edit
Bug 18235: Add missing POD to get_facetable_fields

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86344|0   |1
is obsolete||

--- Comment #89 from Josef Moravec  ---
Created attachment 86948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86948=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86342|0   |1
is obsolete||

--- Comment #87 from Josef Moravec  ---
Created attachment 86946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86946=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #84 from Josef Moravec  ---
Bug 22495 is going to restore su-geo, so I think we should wait with this again
:(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Depends on||22495


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495
[Bug 22495] Restore su-geo field in Elasticsearch mappings
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

--- Comment #83 from Josef Moravec  ---
I rebased it and add a follow-up to adapt to 19575, just not sure what to do,
with su-geo, look like it was removed in bug 1957...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #82 from Josef Moravec  ---
Created attachment 86350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86350=edit
Bug 18235: (QA follow-up) Series facet name after rebase

Bug 19575 changes many field names so "se" facet field became "title-series"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #81 from Josef Moravec  ---
Created attachment 86349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86349=edit
Bug 18235: (QA follow-up) Make db update idempotent

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #80 from Josef Moravec  ---
Created attachment 86348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86348=edit
Bug 18235: Do not call get_facetable_fields excessively

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #73 from Josef Moravec  ---
Created attachment 86341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86341=edit
Bug 18235: Add missing POD to get_facetable_fields

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #79 from Josef Moravec  ---
Created attachment 86347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86347=edit
Bug 18235: Update facet_order default value in atomic update

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #78 from Josef Moravec  ---
Created attachment 86346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86346=edit
Bug 18235: (QA follow-up) Add missing filters

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #77 from Josef Moravec  ---
Created attachment 86345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86345=edit
Bug 18235: (QA follow-up) Fix POD

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #76 from Josef Moravec  ---
Created attachment 86344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86344=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #74 from Josef Moravec  ---
Created attachment 86342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86342=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #85983|0   |1
is obsolete||
  Attachment #85984|0   |1
is obsolete||
  Attachment #85985|0   |1
is obsolete||
  Attachment #85986|0   |1
is obsolete||
  Attachment #85987|0   |1
is obsolete||
  Attachment #85988|0   |1
is obsolete||
  Attachment #85989|0   |1
is obsolete||
  Attachment #85990|0   |1
is obsolete||
  Attachment #85991|0   |1
is obsolete||
  Attachment #85992|0   |1
is obsolete||

--- Comment #72 from Josef Moravec  ---
Created attachment 86340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86340=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
Rebuild index
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #71 from Nick Clemens  ---
Conflict in the mappings file, please rebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Blocks|22449   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449
[Bug 22449] Improve Elastic search facet setting UI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

   Target Milestone|--- |19.05
 QA Contact|m.de.r...@rijksmuseum.nl|josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Blocks||22449


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449
[Bug 22449] Improve Elastic search facet setting UI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #70 from Josef Moravec  ---
Created attachment 85992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85992=edit
Bug 18235: (QA follow-up) Make db update idempotent

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #67 from Josef Moravec  ---
Created attachment 85989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85989=edit
Bug 18235: (QA follow-up) Add missing filters

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #69 from Josef Moravec  ---
Created attachment 85991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85991=edit
Bug 18235: Do not call get_facetable_fields excessively

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #68 from Josef Moravec  ---
Created attachment 85990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85990=edit
Bug 18235: Update facet_order default value in atomic update

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #66 from Josef Moravec  ---
Created attachment 85988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85988=edit
Bug 18235: (QA follow-up) Fix POD

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #63 from Josef Moravec  ---
Created attachment 85985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85985=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #65 from Josef Moravec  ---
Created attachment 85987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85987=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #62 from Josef Moravec  ---
Created attachment 85984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85984=edit
Bug 18235: Add missing POD to get_facetable_fields

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #64 from Josef Moravec  ---
Created attachment 85986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85986=edit
Bug 18235: Add unit tests for get_facetable_fields

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

  Attachment #85212|0   |1
is obsolete||
  Attachment #85213|0   |1
is obsolete||
  Attachment #85214|0   |1
is obsolete||
  Attachment #85215|0   |1
is obsolete||
  Attachment #85216|0   |1
is obsolete||
  Attachment #85885|0   |1
is obsolete||
  Attachment #85886|0   |1
is obsolete||
  Attachment #85969|0   |1
is obsolete||
  Attachment #85970|0   |1
is obsolete||

--- Comment #61 from Josef Moravec  ---
Created attachment 85983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85983=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
Rebuild index
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #60 from Josef Moravec  ---
(In reply to Jonathan Druart from comment #54)
> I would support an integration ASAP then we could discuss the ergonomic
> (patches submitted 2 years ago).
> 
> Unless somebody else is willing to make the changes ;)

(In reply to Owen Leonard from comment #55)
> I've got some interface changes in process, but they don't need to hold this
> up.

I agree, we could pass and push this soon and then work on UI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #59 from Josef Moravec  ---
(In reply to Owen Leonard from comment #53)
> (In reply to Josef Moravec from comment #52)
> > the facet table is at
> > the end of page and easy to oversee...
> 
> I wonder if it should be in a separate tab?

I think it is good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #58 from Jonathan Druart  
---
Created attachment 85970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85970=edit
Bug 18235: Do not call get_facetable_fields excessively

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #57 from Jonathan Druart  
---
Created attachment 85969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85969=edit
Bug 18235: Update facet_order default value in atomic update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #56 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #50)
> Comment on attachment 85214 [details] [review]
> Bug 18235: DB changes
> 
> Review of attachment 85214 [details] [review]:
> -
> 
> :::
> installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql
> @@ +1,1 @@
> > +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' 
> > AFTER weight;
> 
> Here is default 0
> 
> ::: installer/data/mysql/kohastructure.sql
> @@ +1493,4 @@
> >`label` varchar(255) NOT NULL COMMENT 'the human readable name of the 
> > field, for display',
> >`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 
> > 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when 
> > storing it in the search engine',
> >`weight` decimal(5,2) DEFAULT NULL,
> > +  `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the 
> > field in facet list if faceted',
> 
> And here NULL

Right, must be NULL in the atomic update file.

(In reply to Josef Moravec from comment #51)
> Comment on attachment 85212 [details] [review]
> Bug 18235: ES - Facets configurable
> 
> Review of attachment 85212 [details] [review]:
> -
> 
> ::: Koha/SearchEngine/Elasticsearch.pm
> @@ +971,5 @@
> > +my @faceted_fields = Koha::SearchFields->search(
> > +{ name => { -in => \@search_field_names }, facet_order => { '!=' 
> > => undef } }, { order_by => ['facet_order'] }
> > +);
> > +my @not_faceted_fields = Koha::SearchFields->search(
> > +{ name => { -in => \@search_field_names }, facet_order => undef }, 
> > { order_by => ['facet_order'] }
> 
> Why do you retrieve fields from database in 2 queries, you always use them
> all.

To have the not faceted fields at the end of the array. I agree it's a lazy way
to handle that, but it works :)


> ::: admin/searchengine/elasticsearch/mappings.pl
> @@ +215,4 @@
> >  push @all_search_fields, $search_field_unblessed;
> >  }
> >  
> > +my @facetable_fields = 
> > Koha::SearchEngine::Elasticsearch->get_facetable_fields();
> 
> get_facetable_fields is called 3 or 4 times every run of mappings.pl.

Yep, could be lowered to 2.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #55 from Owen Leonard  ---
I've got some interface changes in process, but they don't need to hold this
up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #54 from Jonathan Druart  
---
I would support an integration ASAP then we could discuss the ergonomic
(patches submitted 2 years ago).

Unless somebody else is willing to make the changes ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #53 from Owen Leonard  ---
(In reply to Josef Moravec from comment #52)
> the facet table is at
> the end of page and easy to oversee...

I wonder if it should be in a separate tab?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||josef.mora...@gmail.com,
   ||oleon...@myacpl.org

--- Comment #52 from Josef Moravec  ---
Hi Jonathan, great job, I have just some small questions (see above)

I also adding Owen if he can advice us how to do the UI better, it is not
obvious that the facet order could be changed, also the facet table is at the
end of page and easy to oversee...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #51 from Josef Moravec  ---
Comment on attachment 85212
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212
Bug 18235: ES - Facets configurable

Review of attachment 85212:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18235=85212)
-

::: Koha/SearchEngine/Elasticsearch.pm
@@ +971,5 @@
> +my @faceted_fields = Koha::SearchFields->search(
> +{ name => { -in => \@search_field_names }, facet_order => { '!=' => 
> undef } }, { order_by => ['facet_order'] }
> +);
> +my @not_faceted_fields = Koha::SearchFields->search(
> +{ name => { -in => \@search_field_names }, facet_order => undef }, { 
> order_by => ['facet_order'] }

Why do you retrieve fields from database in 2 queries, you always use them all.

::: admin/searchengine/elasticsearch/mappings.pl
@@ +215,4 @@
>  push @all_search_fields, $search_field_unblessed;
>  }
>  
> +my @facetable_fields = 
> Koha::SearchEngine::Elasticsearch->get_facetable_fields();

get_facetable_fields is called 3 or 4 times every run of mappings.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #50 from Josef Moravec  ---
Comment on attachment 85214
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214
Bug 18235: DB changes

Review of attachment 85214:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=18235=85214)
-

:::
installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql
@@ +1,1 @@
> +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER 
> weight;

Here is default 0

::: installer/data/mysql/kohastructure.sql
@@ +1493,4 @@
>`label` varchar(255) NOT NULL COMMENT 'the human readable name of the 
> field, for display',
>`type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 
> 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when 
> storing it in the search engine',
>`weight` decimal(5,2) DEFAULT NULL,
> +  `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the 
> field in facet list if faceted',

And here NULL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #48 from Josef Moravec  ---
Created attachment 85885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85885=edit
Bug 18235: (QA follow-up) Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #49 from Josef Moravec  ---
Created attachment 85886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85886=edit
Bug 18235: (QA follow-up) Add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #47 from Jonathan Druart  
---
Those patches have been waiting for one year, only for a commit message
problem.

As I do not plan to rebase them endlessly, I think it would be great for
libraries using ES to get a green stamp from people involved in the ES
development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #45 from Jonathan Druart  
---
Created attachment 85215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85215=edit
Bug 18235: Add unit tests for get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #44 from Jonathan Druart  
---
Created attachment 85214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #43 from Jonathan Druart  
---
Created attachment 85213
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85213=edit
Bug 18235: Add missing POD to get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73000|0   |1
is obsolete||
  Attachment #73001|0   |1
is obsolete||
  Attachment #74643|0   |1
is obsolete||
  Attachment #75995|0   |1
is obsolete||
  Attachment #75996|0   |1
is obsolete||

--- Comment #42 from Jonathan Druart  
---
Created attachment 85212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
Rebuild index
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #46 from Jonathan Druart  
---
Created attachment 85216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85216=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||ere.maij...@helsinki.fi,
   ||katrin.fisc...@bsz-bw.de

--- Comment #41 from Katrin Fischer  ---
This patch doesn't apply right now. Might not be a hard fix if you are familiar
with the Elasticsearch code. Can we get a rebase please?

@Ere - It'd also be great if you could have a look here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

e.betemps  changed:

   What|Removed |Added

 CC||e.bete...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #40 from Jonathan Druart  
---
I have amended the last 2 patches: 1. rename atomic update file and 2. remove
the line from commit message that was not related to the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #74642|0   |1
is obsolete||

--- Comment #39 from Jonathan Druart  
---
Created attachment 75996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75996=edit
Bug 18235: Add unit tests for get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72999|0   |1
is obsolete||

--- Comment #38 from Jonathan Druart  
---
Created attachment 75995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75995=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #37 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #35)
> Created attachment 74642 [details] [review]
> Bug 18235: Add unit tests for get_facetable_fields
> 
> rename atomic update file

Looks like this patch does not what it was named for. Atomic update file's name
is still Bug_xxx.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73193|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 74642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74642=edit
Bug 18235: Add unit tests for get_facetable_fields

rename atomic update file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #36 from Jonathan Druart  
---
Created attachment 74643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74643=edit
Bug 18235: Add missing POD to get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #34 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #33)
> * Commit title does not start with 'Bug X: ' - 9400c92
> POD is missing for get_facetable_fields

That's all?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #33 from Marcel de Rooy  ---
* Commit title does not start with 'Bug X: ' - 9400c92
POD is missing for get_facetable_fields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #32 from Marcel de Rooy  ---
Resuming here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #31 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #30)
> There is a lot of noise from YAML while running qa tools and a git
> manipulation fail too.

Noise appears before and after the patch, so not related.
The git manipulation is on the atomic update (it should not have been moved in
the last patch), I will fix it on pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Failed QA

--- Comment #30 from Marcel de Rooy  ---
There is a lot of noise from YAML while running qa tools and a git manipulation
fail too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master
 Status|Signed Off  |BLOCKED

--- Comment #29 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #28 from Alex Arnaud  ---
Created attachment 73193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73193=edit
Bug 18235 - Add unit tests for get_facetable_fields

rename atomic update file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #27 from Jonathan Druart  
---
I did not create a new tab because we already have 3: 
Search fields
Biblios
Authorities
and I do not think it makes sense to have a 4th "Facet order" which will refer
to biblio search only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

--- Comment #26 from Séverine Queune  ---
+1 for the new 'Facet order' tab !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nicolas Legrand  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #25 from Alex Arnaud  ---
Ergonomic suggestion:
  - move the the facet table in a new tab (discussed with some interested
libraries). Currently it is not visible at the first glance.

QA suggestion:
  - rename bug_x.sql with the appropriate bug number,
  - add unit test for get_facetable_fields

Then, nice feature and i would like this to move forward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

--- Comment #24 from Nicolas Legrand  ---
Added missing curly, removed a http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72938|0   |1
is obsolete||

--- Comment #23 from Nicolas Legrand  ---
Created attachment 73001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73001=edit
Bug 18235: DBIx schema changes

Fresh changes for SearchField, facet_order.

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72937|0   |1
is obsolete||

--- Comment #22 from Nicolas Legrand  ---
Created attachment 73000
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73000=edit
Bug 18235: ES - Facets configurable

This patch adds a new section 'Facet order' in the Biblio tab of the
'Search engine configuration' admin page of the Elastic mappings.
The idea is to let the librarians define the facet to display and order
them as their needs.

The ergonomic is not perfect and I am open to any suggestions.

Test plan:
Move up and down the field list to order the facets
Hide/show some facets
Rebuild index
At the OPAC and the staff interface you should see the changes on the
search result page.

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72936|0   |1
is obsolete||

--- Comment #21 from Nicolas Legrand  ---
Created attachment 72999
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72999=edit
Bug 18235: DB changes

Signed-off-by: Nick Clemens 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/