[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Pushed to

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry changed: What|Removed |Added Status|Pushed to master|Pushed to stable --

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Andrew Fuerste-Henry changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #43 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #41) > Created attachment 113897 [details] [review] > Bug 18267: (QA follow-up) fix typo: overriden => overridden Patch pushed to master.

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 113897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113897=edit Bug 18267: (QA follow-up) fix typo: overriden => overridden -- You are

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #40 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Martin Renvoize changed: What|Removed |Added Severity|normal |major -- You are

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Attachment #113569|0 |1 is obsolete|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #39 from Kyle M Hall --- Created attachment 113597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113597=edit Bug 18267 Refactored Edifact Price Calculations Refactored the price calculations for

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #38 from Colin Campbell --- *** Bug 17279 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Status|Failed QA |Needs Signoff Patch

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Attachment #65246|0 |1 is obsolete|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #34 from Kyle M Hall --- Created attachment 68714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68714=edit Bug 18267 [QA Followup] - Supress warnings Signed-off-by: Kyle M

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #33 from Kyle M Hall --- Created attachment 68713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68713=edit Bug 18267 Update doc for Koha::EDI Document change to

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #32 from Kyle M Hall --- Created attachment 68712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68712=edit Bug 18267 Add tests for all price methods Add test for

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #28 from Kyle M Hall --- Created attachment 68708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68708=edit Bug 18267 Populate new price fields in EDI Processing New price

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #31 from Kyle M Hall --- Created attachment 68711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68711=edit Bug 18267 Add test for new tax_rate method Test return for new

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Attachment #65244|0 |1

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #29 from Kyle M Hall --- Created attachment 68709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68709=edit Bug 18267 Remove obsolete Edifact::Line price method The old

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #30 from Kyle M Hall --- Created attachment 68710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68710=edit Bug 18267 - Record tax rate on receipt from EDI Invoice As part

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Kyle M Hall changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jon Knight changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #26 from Jon Knight --- Created attachment 68536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68536=edit Bug 18267 Update doc for Koha::EDI Document change to

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #25 from Colin Campbell --- (In reply to Jon Knight from comment #24) > (In reply to Colin Campbell from comment #23) > > The error is because there are teo versions of patch populate

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #24 from Jon Knight --- (In reply to Colin Campbell from comment #23) > The error is because there are teo versions of patch populate price fields > using new methods one for 16.11.x and one for

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #23 from Colin Campbell --- The error is because there are teo versions of patch populate price fields using new methods one for 16.11.x and one for all subsequent versions applying both

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #22 from Katrin Fischer --- Hi Colin, there is a tiny conflict in EDI.pm: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18267 populate_order_with_prices should be exported Applying: Bug

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Status|Patch doesn't apply

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jon Knight changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 David Bourgault changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Priority|P5 - low

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #17 from Colin Campbell --- Created attachment 65254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65254=edit Update doc for changed methods perldoc was for old

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #16 from Colin Campbell --- Created attachment 65253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65253=edit Unit tests for price methods -- You are receiving this

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #15 from Colin Campbell --- Created attachment 65252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65252=edit Unit Tests for tax-rate -- You are receiving this mail

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #14 from Colin Campbell --- Created attachment 65251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65251=edit Record tax rate from the invoice -- You are receiving

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #13 from Colin Campbell --- Created attachment 65250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65250=edit Remove dead code - price method replaced by more specific

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #12 from Colin Campbell --- Created attachment 65246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65246=edit patch to populate price fields using new methods (16.11

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Attachment #61601|0

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Attachment #61600|0

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Nick Clemens changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Barry Cannon changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #6 from Colin Campbell --- Created attachment 61606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61606=edit proposed patch Add test for new method added to line --

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Attachment #61602|0

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Colin Campbell changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #3 from Colin Campbell --- Created attachment 61602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61602=edit Proposed patch -- You are receiving this mail because:

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #2 from Colin Campbell --- Created attachment 61601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61601=edit Proposed patch -- You are receiving this mail because:

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 --- Comment #1 from Colin Campbell --- Created attachment 61600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61600=edit Proposed patch -- You are receiving this mail because:

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Martin Renvoize changed: What|Removed |Added