[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Kyle M Hall changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Martin Renvoize changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Martin Renvoize changed: What|Removed |Added Attachment #62826|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Martin Renvoize changed: What|Removed |Added Attachment #62739|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Martin Renvoize changed: What|Removed |Added Attachment #62738|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Martin Renvoize changed: What|Removed |Added QA

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added Attachment #62710|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #20 from Jonathan Druart --- Created attachment 62739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62739=edit Bug 18442: Add a test Signed-off-by: Jonathan

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #18 from Tomás Cohen Arazi --- I think the patch looks ok, meaning it makes sense. But we really need a small regression test, to make sure we are actually fixing the issue in the right place and

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #17 from Alex Buckley --- (In reply to Martin Renvoize in comment 15) Thanks for the feedback Martin -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #16 from Alex Buckley --- Created attachment 62710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62710=edit Bug 18442: Implemented $userid ||= $q_userid if $return == 2;

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Attachment #62567|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #15 from Martin Renvoize --- Correct. I'd like to see the `if $return == 2` added. I believe adding that should protect us from any unforeseen down the line action at a distance bugs

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #14 from Alex Buckley --- (In reply to Martin Renvoize in comment 13) Hi Martin So just to confirm you would like to see: $userid ||= $q_userid if $return == 2; -- You are receiving

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #13 from Martin Renvoize --- Checking the $return value would certainly be the belt and braces approach. I like it. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #12 from Jonathan Druart --- The patch is ok to me. I'd like opinion about $userid ||= $q_userid; vs $userid ||= $q_userid if $return == 2; -- You are receiving this

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #11 from Alex Buckley --- (In reply to Jonathan Druart in comment 9) Hi Jonathan I have added your suggested alteration in my patch so now we just have a single patch attached to this bug

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #10 from Alex Buckley --- Created attachment 62567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62567=edit Bug 18442 - Implemented assignment of the $userid variable

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Attachment #62448|0

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #9 from Jonathan Druart --- (In reply to Alex Buckley from comment #8) > Ah yup would you like me to implement: $userid ||= $q_userid; I'd love only 1 patch and avoid

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #8 from Alex Buckley --- Ah yup would you like me to implement: $userid ||= $q_userid; -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added Severity|major

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Marc Véron changed: What|Removed |Added Attachment #62423|0 |1 is

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #3 from Alex Buckley --- This patch does not undo the security bug fixes of bug 18275 (opac-memberentry.pl security vulnerabilities) because all tests in the unit test t/db_dependent/Auth.t

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 --- Comment #2 from Alex Buckley --- Created attachment 62423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62423=edit Bug 18442 - Implemented assignment of the $userid variable

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Alex Buckley changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 18442] Permission error when logging into staff interface as db user

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18442 Chris Cormack changed: What|Removed |Added CC|