[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

int  changed:

   What|Removed |Added

 CC||i...@arcor.de

--- Comment #2 from int  ---
'make test' fails differently depending on the database (with 'run the
database-dependent test suite' is set to 'no').
If he can't connect to a database (e.g. 'Access denied'),
Koha_ExternalContent_OverDrive.t and XSLT.t fail.
If he can connect to an empty database or a database without data (but with the
tables), Matcher.t and Prices.t fail. This seems to be your case.

With a "real" database with data, Matcher.t seems to work. I didn't investigate
this further, but if you import kohastructure.sql, e.g.
> mysql -u root -p kohatest < installer/data/mysql/kohastructure.sql
and everything from installer/data/mysql/mandatory and installer/data/mysql/en,
it should work. (If I didn't miss something.)

Prices.t seems to rely on some testdata, see the fixture data in t/Prices.t
(fixtures_ok).
If there is a database-connection available, he seem to want this data from the
database (and not the mock anymore). So if you set it up in the database, the
test also works:
> INSERT INTO aqbooksellers (id, name, listincgst, invoiceincgst)
> VALUES (1, '0 0', 0, 0), (2, '0 1', 0, 1), (3, '1 0', 1, 0), (4, '1 1', 1, 1);
I would assume that if 'run the database-dependent test suite' is set to 'no',
'make test' ignores even working database credentials in koha-conf.xml. This
doesn't seem to be the case right now. I don't know if this is a general
problem or if this bug should be split into several for each failing test
(Koha_ExternalContent_OverDrive.t, XSLT.t, Matcher.t and Prices.t).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #1 from Mason James  ---

> t/Matcher.t and t/Prices.t do fail
> 
> Test Summary Report
> ---
> t/Matcher.t   (Wstat: 768 Tests: 12 Failed: 3)
>   Failed tests:  3-5
>   Non-zero exit status: 3
> t/Prices.t(Wstat: 65280 Tests: 5 Failed: 1)
>   Failed test:  5
>   Non-zero exit status: 255
>   Parse errors: Bad plan.  You planned 16 tests but ran 5.
> Files=100, Tests=11528, 95 wallclock secs ( 0.89 usr  0.16 sys + 81.23 cusr 
> 3.06 csys = 85.34 CPU)
> Result: FAIL
> Failed 2/100 test programs. 4/11528 subtests failed.
> Makefile:9572: recipe for target 'test_dynamic' failed
> make: *** [test_dynamic] Error 255



the Prices.t test does seem to be currently failing on jenkins..

https://jenkins.koha-community.org/job/Koha_Master_U16/lastBuild/consoleText
Build #171 (31-May-2017 02:11:06)

#   Failed test 'No tests run for subtest "Configuration 1: 0 0"'
#   at t/Prices.t line 155.
Can't call method "listincgst" on an undefined value at
/srv/jenkins/workspace/Koha_Master_U16/C4/Acquisition.pm line 2883.
# Looks like your test exited with 255 just after 5.
[23:35:52] t/Prices.t  
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 12/16 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Mason James  changed:

   What|Removed |Added

Version|unspecified |17.05
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Bob Ewart  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] Run database_dependent test suite --No ignored

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

Bob Ewart  changed:

   What|Removed |Added

 CC||bob-ew...@bobsown.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/