[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #37 from Katrin Fischer  ---
*** Bug 14958 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nick Clemens  changed:

   What|Removed |Added

 Blocks||24242


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24242
[Bug 24242] Funds with no library assigned do not appear on edit suggestions
page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|19.11.00|19.11.00,19.05.05
released in||

--- Comment #36 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.05

Great job everyone and thanks a lot BULAC ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #35 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #34 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #29)
> This all works as I expect, I think the test plan descriptions are still
> incorrect, under the scenarios below all works as explained and is correct:
> 
> A super yes, ib no
> B super no, ib no
> C super yes, ib yes
> D super no, ib yes

Indeed, not completely back to binary mode it seems ;)

I have amended the test plan and added the sponsored-by lines.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94740|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 94742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94742=edit
Bug 18743: Correct number of pending suggestions (acq home page)

This patch could be moved to its own bug report if we want to adjust
tests.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94739|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 94741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94741=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is not set (=No)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94738|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 94740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94740=edit
Bug 18743: Correct number of pending suggestions (acq home page)

This patch could be moved to its own bug report if we want to adjust
tests.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94737|0   |1
is obsolete||

--- Comment #30 from Jonathan Druart  
---
Created attachment 94739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94739=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is set (=Yes)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is not set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #29 from Nick Clemens  ---
This all works as I expect, I think the test plan descriptions are still
incorrect, under the scenarios below all works as explained and is correct:

A super yes, ib no
B super no, ib no
C super yes, ib yes
D super no, ib yes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #28 from Nick Clemens  ---
Created attachment 94738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94738=edit
Bug 18743: Correct number of pending suggestions (acq home page)

This patch could be moved to its own bug report if we want to adjust
tests.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nick Clemens  changed:

   What|Removed |Added

  Attachment #94515|0   |1
is obsolete||
  Attachment #94516|0   |1
is obsolete||

--- Comment #27 from Nick Clemens  ---
Created attachment 94737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94737=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is set (=Yes)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is not set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #26 from sandbo...@biblibre.com  ---
Created attachment 94516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94516=edit
Bug 18743: Correct number of pending suggestions (acq home page)

This patch could be moved to its own bug report if we want to adjust
tests.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #94418|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #25 from sandbo...@biblibre.com  ---
Created attachment 94515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94515=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is set (=Yes)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is not set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #24 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #94417|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23594


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594
[Bug 23594] Batch modification for itemtypes on suggestions page
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #23 from Jonathan Druart  
---
Created attachment 94418
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94418=edit
Bug 18743: Correct number of pending suggestions (acq home page)

This patch could be moved to its own bug report if we want to adjust
tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #94300|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  
---
Created attachment 94417
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94417=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set (=No)
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches is set (=Yes)
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is not set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #21 from Séverine Queune  ---
I had a doubt concerning the settings of IndependentBranches, so for each test
I precise which of the 'Yes/No' I used.

> A. You are superlibrarian and IndependentBranches is not set
> 1. Hit /suggestion/suggestion.pl
With IndependentBranches = 'Yes'

> => Default view shows the suggestions from your library
no : I can see all the pending suggestions whatever is the fitler I used for
Library

> 2. Filter by another library
> => You see the suggestions from this library
no : same as 1.

> 3. Filter by "Any" libraries
> => You see all the suggestions
no : same as 1.

> 4. "Organize by library"
> => You see all the suggestions, organized by library
no : all the suggestions are displayed in only one tab which name is the
library I'm logged in

> 5. Filter by a specific library
> => You see the suggestion from your library, all in one tab
None of the filter boxes open when I clic on them so I can't test.
Tested with 2 different superadmin accounts, located in 2 different sites, on 2
different computers.


> B. You are not superlibrarian and IndependentBranches
> Same as A.
With IndependentBranches = 'No'
1. ok
2. ok
3. ok
4. ok
5. ok

> C. You are superlibrarian and IndependentBranches is set
> Same as A.
With IndependentBranches = 'No'
1. ok
2. ok
3. ok
4. ok
5. ok

> D. You are not superlibrarian and IndependentBranches is not set
> You will never see suggestions coming from outside your library
With IndependentBranches = 'Yes'
1. ok
2. ok : option not available as expected
3. ok : only suggestions for my site are displayed
4+5. no : if I filter on my site and then "organize by library", the table is
not displayed. I can only see it filtering on "Any". 

I wonder what is the behaviour we want to have concerning the count of
"suggestions waiting" on /koha/mainpage.pl and /acqui/acqui-home.pl : for case
D, only the pending suggestions on the site of the logged user are counted.
For the 3 other cases, all the suggestions are counted. I understand this logic
as these users can modifiy all of them, but I think it might be a little
disturbing for a user to see "x pending suggestions" and, on the suggestion
page, having an empty page because all the suggestions are made for an other
site.
Could we imagine to have something like : "Pending suggestions : my site = x /
all = y" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

SiobhanC  changed:

   What|Removed |Added

 CC||siobhancot...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|alexbuck...@catalyst.net.nz |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
  Change sponsored?|Seeking developer   |Sponsored

--- Comment #20 from Jonathan Druart  
---
I think I have tracked down the different weird behaviors. They have all been
addressed in the last patch.

Please test :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #72637|0   |1
is obsolete||
  Attachment #72679|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 94300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94300=edit
Bug 18743: Fix suggestion listing when organized by library

There are some weird behaviors happening when using the "Organize by:
library" dropdown along with the library filter (in the "Acquisition
information" box).

I am suggesting the following test plan:
0. Create several suggestion from different libraries

A. You are superlibrarian and IndependentBranches is not set
1. Hit /suggestion/suggestion.pl
=> Default view shows the suggestions from your library
2. Filter by another library
=> You see the suggestions from this library
3. Filter by "Any" libraries
=> You see all the suggestions
4. "Organize by library"
=> You see all the suggestions, organized by library
5. Filter by a specific library
=> You see the suggestion from your library, all in one tab

B. You are not superlibrarian and IndependentBranches
Same as A.

C. You are superlibrarian and IndependentBranches is set
Same as A.

D. You are not superlibrarian and IndependentBranches is not set
You will never see suggestions coming from outside your library

QA: To be clear: the whole script needs a rewrite, but here we are just
trying to fix weird behaviors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #18 from Fridolin SOMERS  ---
I propose a general postulate n°2 :

"Behavior/display is the same between : 
  - IndependantBranches off
  - IndependantBranches on + superlibrarian
"

This makes code really less complicated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|--- |Seeking developer

--- Comment #17 from Séverine Queune  ---
The BULAC (http://www.bulac.fr/) would LOVE to see this discussion reopened and
is ready to sponsor the development chosen.

As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to
quote us for the development of such a feature or just ask for more information
is welcome to write to us: .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #16 from Katrin Fischer  ---
(In reply to Fridolin SOMERS from comment #15)
> I think we must redefine the behavior we want before proposing patches.
> 
> I propose a general postulate n°1 :
> "A suggestion without branch is considered like a suggestion of the current
> user branch."
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #15 from Fridolin SOMERS  ---
I think we must redefine the behavior we want before proposing patches.

I propose a general postulate n°1 :
"A suggestion without branch is considered like a suggestion of the current
user branch."

This makes this case more easy for filtering and counting. We say that branch
is not defined yet and you may set your branch (even if independant branches
and no-superlibarian).

I have listed the current behavior and we will discuss what behavior is wanted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #14 from Fridolin SOMERS  ---
*** Bug 10449 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #13 from Séverine Queune  ---
Linked to Bug 10449, Frido is working on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10449

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #12 from Séverine Queune  ---
The first patch didn't apply as expected : no suggestion was visible.
The alternative patch filters correctly suggestions on branches when logged as
non-superlibrarian ; all sugegstions can be seen by a superlibrairian.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71030|0   |1
is obsolete||

--- Comment #11 from Séverine Queune  ---
Created attachment 72679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72679=edit
Bug 18743 - ALTERNATE: Take IndependantBranches syspref into account

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

--- Comment #10 from Nicolas Legrand  ---
just rebased the first one master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #64768|0   |1
is obsolete||

--- Comment #9 from Nicolas Legrand  ---
Created attachment 72637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72637=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled

Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.

But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.

If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.

Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.

Test plan:
1. Relicate the bug described in description comment

2. Apply patch

3. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)

4. Create 1 suggestion for a different branch (which I will refer to as
branch B)

5. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'

6. Go to Acquisitions->Suggestions Management

7. Notice that suggestions from branch A and B are displayed

8. In the Organize by are click to filter by library and click go

9. Notice that one tab says  (2) whilst the other tab
says  (1) with each tab containing the relevant
suggestions to that branch

10. In the Acquisition information filter select branch A and then click
'Go' and notice that it successfully filters the results and shows 2
suggestions of branch A only

11. Now change the IndependentBranches syspref to 'no'

12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and
10

13. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module

14. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management

15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9
and 10

16. Change IndependentBranches to 'yes'

17. Go to Acquisitions->Suggestions Management

18. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches

19. Also notice that there is no 'library' option in the 'Organized by'
area and there is no library filter in the acquisition information area. This
is because only suggestions from the current branch are displayed and so
organizing/filtering by library is redundant.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Maksim Sen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Maksim Sen  changed:

   What|Removed |Added

 CC||maksim@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Maksim Sen  changed:

   What|Removed |Added

  Attachment #68298|0   |1
is obsolete||

--- Comment #8 from Maksim Sen  ---
Created attachment 71030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71030=edit
Bug 18743 - ALTERNATE: Take IndependantBranches syspref into account

---
THIS IS AN ALTERNATE PATCH
I am submitting it here, because it covers less than Alex's patch, but does so
in a simpler fashion.
APPLY ONLY THIS PATCH, OR THE OTHER, NOT BOTH.
---

Displays suggestions for all libraries when IndependantBranches is set to no,
or user is Super librarian by adding a missing if statement.

TEST PLAN
[0] Apply patch
[1] Set IndependentBranches to 'Yes'.
[2] Create a suggestion with a user from branch A.
[3] As a superlibrarian, visit the suggestion page, you should see the
suggestion.
[4] As staff from branch A, visit the sugg. page, you should see the
suggestion.
[5] As staff from branch B, visit the sugg. pase, you should NOT see the
suggestion.
[6] As staff from branch A, make sure the amount of suggestions to the left of
"Suggestions pending approval: "
is the same as the amount of suggestions in the suggestions page.
[7] Set IndependentBranches to 'No'.
[8] Redo step 3-5. You should always see the suggestion.
[9] Sign-off.
[10] Have fun.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Katrin Fischer  ---
Hi David,

this does not seem to work really well yet. To test:
- Add a suggestion for A, B and any.
- Add a staff user with acq permissions from A.
- Activated independent branches.
- Verify that selecting the 'Any' option from the branches list you can still
always see all suggestions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #6 from David Bourgault  ---
Created attachment 68298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68298=edit
Bug 18743 - ALTERNATE: Take IndependantBranches syspref into account

---
THIS IS AN ALTERNATE PATCH
I am submitting it here, because it covers less than Alex's patch, but does so
in a simpler fashion.
APPLY ONLY THIS PATCH, OR THE OTHER, NOT BOTH.
---

Displays suggestions for all libraries when IndependantBranches is set to no,
or user is Super librarian by adding a missing if statement.

TEST PLAN
[0] Apply patch
[1] Set IndependentBranches to 'Yes'.
[2] Create a suggestion with a user from branch A.
[3] As a superlibrarian, visit the suggestion page, you should see the
suggestion.
[4] As staff from branch A, visit the sugg. page, you should see the
suggestion.
[5] As staff from branch B, visit the sugg. pase, you should NOT see the
suggestion.
[6] Set IndependentBranches to 'No'.
[7] Redo step 3-5. You should always see the suggestion.
[8] Sign-off.
[9] Have fun.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Katrin Fischer  changed:

   What|Removed |Added

Version|16.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Hi Alex,

something seems not to be working quite right. What I have done:

1) Made 2 suggestions from the OPAC for Centerville and Fairfield. Centerville
is my home library (turn on AllowPurchaseSuggestionBranchChoice)
2) Made 1 suggestion from the intranet for 'any' library
3) Checked that with independent branches off, I can see all 3 suggestions in
"Pending"
4) Turned on IndependentBranches - no change in behaviour
5) Applied patch, restarted plack etc.
6) No matter how I 'organize by' I don't see any of the suggestions now, the
page is always empty, no tabs shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #4 from Alex Buckley  ---
Created attachment 64768
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64768=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled

Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.

But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.

If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.

Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.

Test plan:
1. Relicate the bug described in description comment

2. Apply patch

3. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)

4. Create 1 suggestion for a different branch (which I will refer to as
branch B)

5. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'

6. Go to Acquisitions->Suggestions Management

7. Notice that suggestions from branch A and B are displayed

8. In the Organize by are click to filter by library and click go

9. Notice that one tab says  (2) whilst the other tab
says  (1) with each tab containing the relevant
suggestions to that branch

10. In the Acquisition information filter select branch A and then click
'Go' and notice that it successfully filters the results and shows 2
suggestions of branch A only

11. Now change the IndependentBranches syspref to 'no'

12. Repeat steps 6, 7, 8, 9, 10 noticing the same outcome in step 9 and
10

13. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module

14. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management

15. Repeat steps 6, 7, 8, 9, 10 and notice the same outcome as step 9
and 10

16. Change IndependentBranches to 'yes'

17. Go to Acquisitions->Suggestions Management

18. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches

19. Also notice that there is no 'library' option in the 'Organized by'
area and there is no library filter in the acquisition information area. This
is because only suggestions from the current branch are displayed and so
organizing/filtering by library is redundant.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

  Attachment #64763|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #3 from Alex Buckley  ---
Created attachment 64763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64763=edit
Bug 18743 - Removed library filter in Acquisition suggestions when
IndependentBranches enabled

Also ensured that when a superlibrarian is logged in then suggestions from
all branches are displayed with IndependentBranches being either on or off, as
this
syspref does not affect what suggestions superlibrarians can see.

But when non-superlibrarian user with access to the acquisitions module
visits it when IndependentBranches is enabled then only suggestions of
the branch they are logged in with are displayed.

If non-superlibrarian users log in when IndependentBranches is not
enabled then suggestions from all branches are displayed.

Note: The library filter in the 'Organize by' area (which is displayed when
multiple branches suggestions are displayed according to the aforementioned
logic) successfully splits the suggestions into different tabs with the correct
number of suggestions for each branch
displayed in each tab.

Test plan:
1. Create 2 suggestions a library branch (which I will refer to in this
test plan as branch A)

2. Create 1 suggestion for a different branch (which I will refer to as
branch B)

3. Log into staff client as superlibrarian with either branch and ensure the
IndependentBranches syspref is set to 'yes'

4. Go to Acquisitions->Suggestions Management

5. Notice that suggestions from branch A and B are displayed

6. In the Organize by are click to filter by library and click go

7. Notice that one tab says  (2) whilst the other tab
says  (1) with each tab containing the relevant
suggestions to that branch

8. Now change the IndependentBranches syspref to 'no'

9. Repeat steps 4, 5, 6, 7 noticing the same outcome in step 7

10. Log out and log back into staff client in branch A as a non-superlibrarian
user
who has access to the Acquisitions module

11. Currently IndependentBranches is set to 'no' so go to
Acquisitions->Suggestions Management

12. Repeat steps 5, 6, 7 and notice the same outcome as step 7

13. Change IndependentBranches to 'yes'

14. Go to Acquisitions->Suggestions Management

15. Notice that only suggestions from branch A (the branch you are
logged in with) are displayed. This is because when IndependentBranches
is enabled non-superlibrarians do not need to see suggestions from other
branches

16. Also noticethat there is no 'library' option in the 'Organized by'
area. This is because only suggestions from the current branch are
displayed and so organizing by library is redundant.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

  Attachment #64742|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #2 from Alex Buckley  ---
Hi Severine 

I am working through making a patch for this bug report and just to clarify the
issue I thought I would write this up:

When IndependentBranches is enabled then both the 'organise by', and
'Acquisition information' filters should not have a library option because only
suggestions from the currently logged in library branch should be displayed. 

An additional bug I have found on the current master is:

When the IndependentBranches syspref is set to 'no' then only suggestions from
the currently logged in branch are displayed.
For example if the staff member is logged into Fairfield branch then only
suggestions submitted to Fairfield branch are displayed. 

This is incorrect because with IndependentBranches not enabled then the user
should be able to see all suggestions from all library branches and this is
when the 'Organise by' and 'Acquisition information' filters should have a
library option.  

Whereas when IndependentBranches syspref is set to 'yes' then all suggestions
from all library branches are displayed which is not correct. When
IndependentBranches is set to true then only the suggestions from the currently
logged in branch should be displayed. 

Regards 
Alex Buckley

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

--- Comment #1 from Alex Buckley  ---
Created attachment 64742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64742=edit
bug 18743 - Partially working filter of suggestions by libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743

Alex Buckley  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alexbuck...@catalyst.net.nz
   |ity.org |
 CC||alexbuck...@catalyst.net.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/