[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #50 from Fridolin SOMERS --- Pushed to 17.05.x for 17.05.13 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #75729|0 |1 is obsolete|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #45 from Marcel de Rooy --- Created attachment 75729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75729=edit Bug 18821: (QA follow-up) Last tweaks for performance [1] passing unsafe has no use since

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Attachment #75634|0 |1 is obsolete|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #44 from Marcel de Rooy --- Created attachment 75728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75728=edit Bug 18821: Convert to using cache with date checking Signed-off-by: Marcel de Rooy --

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #42 from Marcel de Rooy --- (In reply to Kyle M Hall from comment #35) > I actually think a hybrid of your first and second suggestions is the best > solution. We should use cache *and* test a date! Why do you think we

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #41

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #75634|Switched description from |Bug 18821:

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #75632|0 |1 is obsolete|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #40 from Kyle M Hall --- Created attachment 75635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75635=edit Bug 18821: Convert to using cache with date checking -- You are receiving this mail

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #75288|0 |1 is obsolete|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #38 from Kyle M Hall --- Created attachment 75633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75633=edit Bug 18821: Convert to using cache with date checking -- You are receiving this mail

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #36 from Kyle M Hall --- I forgot to add that this will be the fastest variation as well, since it is guaranteed to be only in memory as opposed to both session and direct db which would read and write to database or

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #35 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #34) > I think we should not use the cache here. We will just dump too much in > memory. > Should we change lastseen to a date and check if NOW> lastseen

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #34 from Marcel de Rooy --- I think we should not use the cache here. We will just dump too much in memory. Should we change lastseen to a date and check if NOW> lastseen ? This would skip a lot of writes ? -- You are

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #32) > Before continuing here I think we should first confirm that the code is the > cause of the problem. > > I have talked with Nick last month and it

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #32 from Jonathan Druart --- Before continuing here I think we should first confirm that the code is the cause of the problem. I have talked with Nick last month and it seemed

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #31 from Kyle M Hall --- > What happens? Somehow $session is already undef when you call track. If we > need to call CGI::Session->new($sessionID) each time, we do not really > benefit in terms

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #29 from Kyle M Hall --- Created attachment 75427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75427=edit Bug 18821 - Flush session after setting tracked_for_session --

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Keywords|Academy |

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #27 from Kyle M Hall --- Thanks for the followup Charles! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #26 from Charles Farmer --- Never mind my last comment, it wouldn't be testable at the function level under t/ otherwise. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #25 from Charles Farmer --- Forgot to post a question in my last message: how come track_login_for_session's inside EXPORTER_OK? Does it make sense to use it anywhere else than inside

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Charles Farmer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Charles Farmer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Charles Farmer changed: What|Removed |Added Attachment #75139|0

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #23 from Charles Farmer --- Created attachment 75289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75289=edit Bug 18821 - (follow-up) adds POD to track_login_for_session,

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #21 from Kyle M Hall --- > However, I don't like the way it is done. Passing the CGI::Session object to > a Koha::Patron method so it can read it and write to it. I think > "Koha::Object"s

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #73891|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Sally Healey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #17 from Kyle M Hall --- (In reply to M. Tompsett from comment #16) > (In reply to Jonathan Druart from comment #15) > > I am not against the patch, but it's hard to imagine that 1 update query

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #16 from M. Tompsett --- (In reply to Jonathan Druart from comment #15) > I am not against the patch, but it's hard to imagine that 1 update query by > request can be a "performance killer". I

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #15 from Jonathan Druart --- I am not against the patch, but it's hard to imagine that 1 update query by request can be a "performance killer". -- You are receiving this mail

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #14 from Kyle M Hall --- (In reply to M. Tompsett from comment #13) > Tests trigger all changed code. Thanks, Kyle. :) Thanks for the catch! I think we can deprecate your scaffolding patch

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #73892|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 M. Tompsett changed: What|Removed |Added Attachment #73706|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 M. Tompsett changed: What|Removed |Added Attachment #73863|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 M. Tompsett changed: What|Removed |Added Attachment #73175|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #9 from Kyle M Hall --- Created attachment 73863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73863=edit Bug 18821 [QA Followup]: Add additional unit tests for completeness

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 --- Comment #8 from M. Tompsett --- Created attachment 73706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73706=edit Bug 18821: [DO NOT PUSH] Print STDERR Scaffolding Tests must trigger

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 M. Tompsett changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #65687|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Nicolas Legrand changed: What|Removed |Added CC|

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Jonathan Druart changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Alex Buckley changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Attachment #64426|0 |1

[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Kyle M Hall changed: What|Removed |Added Summary|GetPatronLastActivity is a