[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Martin Renvoize changed: What|Removed |Added Status|Pushed to Stable|RESOLVED

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #47 from David Cook --- Especially when I don't see a data-dismiss attribute on any other button on that page. If you're not transferring, then this is what the code looks like: Confirm

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 David Cook changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Mason James changed: What|Removed |Added Depends on|18438 |

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #45 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Fridolin SOMERS changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Joel Sasse changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #42 from Jonathan Druart --- I am not confident with this patch, I am expecting side-effects. But I do not have anything else to suggest, let's give a try. -- You are receiving

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67308|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67310|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67309|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Julian Maurice changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #37 from Josef Moravec --- Created attachment 67310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67310=edit Bug 19116: (followup) Add tests to highlight the problem in

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #36 from Josef Moravec --- Created attachment 67309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67309=edit Bug 19116: Add tests Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Attachment #67080|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #34 from Josef Moravec --- Created attachment 67307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67307=edit Bug 19116: (followup) Add tests to highlight the problem in

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Attachment #67079|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #32 from Kyle M Hall --- (In reply to Jonathan Druart from comment #31) > (In reply to Kyle M Hall from comment #30) > > (In reply to Katrin Fischer from comment #27) > > > So better to fix the

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #31 from Jonathan Druart --- (In reply to Kyle M Hall from comment #30) > (In reply to Katrin Fischer from comment #27) > > So better to fix the tests on this bug then? > >

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #30 from Kyle M Hall --- (In reply to Katrin Fischer from comment #27) > So better to fix the tests on this bug then? Katrin, I ran the unit tests on multiple data sets and they passed every

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Kyle M Hall changed: What|Removed |Added Attachment #66511|0 |1

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #29 from Kyle M Hall --- Created attachment 67080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67080=edit Bug 19116: Add tests Signed-off-by: Kyle M Hall

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #27 from Katrin Fischer --- So better to fix the tests on this bug then? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #26 from Josef Moravec --- (In reply to Kyle M Hall from comment #25) > (In reply to Jonathan Druart from comment #22) > > (In reply to Josef Moravec from comment #2) > > > And it is caused by

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #25 from Kyle M Hall --- (In reply to Jonathan Druart from comment #22) > (In reply to Josef Moravec from comment #2) > > And it is caused by bug 18438... > > If this is caused by template

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #24 from Katrin Fischer --- There is a template level fix/patch from Kyle on the linked bug 19273 - not sure what makes more sense. -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #2) > And it is caused by bug 18438... If this is caused by template changes, why do we need to fix it at

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #21 from Jonathan Druart --- Another try, the tests still pass with and without the fix. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart changed: What|Removed |Added Attachment #66824|0

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #19 from Katrin Fischer --- is( $hold->found, "T", 'Hold is in transit' ); before you return it again at the pickup library. No matter what I try, I only get 'undef'. -- You are receiving this

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #18 from Katrin Fischer --- The problem is that the item is not in transit, but I haven't figured out how to fix the tests. -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #17 from Katrin Fischer --- If I am reading the test correctly, you miss returning in the library the item is 'sourced at' in order to create the transport status. -- You are receiving this

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #16 from Jonathan Druart --- I do not recreate the issue with tests, someone else? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #15 from Jonathan Druart --- Created attachment 66824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66824=edit Bug 19116: Add tests -- You are receiving

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #14 from Katrin Fischer --- Can someone help out here and write the tests necessary please? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Lucy Vaux-Harvey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Sally Healey changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Tomás Cohen Arazi changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #11 from Katrin Fischer --- Thx a lot, Josef! Works perfectly! -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added Attachment #66307|0

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #9 from Katrin Fischer --- Testing now - I think we might need a unit test for QA. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #8 from Josef Moravec --- Created attachment 66307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66307=edit Bug 19116: Hold not set to waiting after transfer Test plan: 0)

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #5 from Katrin Fischer --- Retested, had totally forgotten we switched to a modal there. Read through the other bug too, but not totally understanding the problem yet. What is strange: if the

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #4 from Katrin Fischer --- Can you explain a bit about the dependency to the other bug? Just a bit confused because for me it looks like one button works, the other does not... so why not make

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #3 from Josef Moravec --- So we have to options - in hidden.bs.modal handler call some api to mark the hold waiting, which means to extend api first, svc nor rest don't support it or to get

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 --- Comment #1 from Josef Moravec --- Hm, same issue was fixed in 17940, but it is here again... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Josef Moravec changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19116] Holds not set to waiting when "Confirm" is used

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19116 Katrin Fischer changed: What|Removed |Added See Also|