[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
I am willing to push this patch but I do not think it is the way to fix it.

Please do not fix more occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch
 Depends on||15084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67321|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 67922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67922=edit
Bug 19328 - Internal server error because of missing currency

This patch fixes internal server errors because of missing active currency
in files aqbudgetperiods.pl, aqbudgets.pl and aqplan.pl.

To reproduce:
- Make sure that no active currency is defined. You can undefine the active
  currency in Administration->Currencies and exchange rates
- Try to go to Administration->Budgets and Admistration->Funds
Result: Internal server error

To test:
- Apply patch
- Restart plack
- Try to reproduce issue, it should no longer occur. There should be a
  yellow message box "No active currency is defined"
- From Administration-> Budgets administration try to edit a fund and go to
  "Planning". Verify that the message box appears here as well.

Signed-off-by: David Bourgault 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

David Bourgault  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

David Bourgault  changed:

   What|Removed |Added

  Attachment #67179|0   |1
is obsolete||

--- Comment #4 from David Bourgault  ---
Created attachment 67321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67321=edit
Bug 19328 - Internal server error because of missing currency

This patch fixes internal server errors because of missing active currency
in files aqbudgetperiods.pl, aqbudgets.pl and aqplan.pl.

To reproduce:
- Make sure that no active currency is defined. You can undefine the active
  currency in Administration->Currencies and exchange rates
- Try to go to Administration->Budgets and Admistration->Funds
Result: Internal server error

To test:
- Apply patch
- Restart plack
- Try to reproduce issue, it should no longer occur. There should be a
  yellow message box "No active currency is defined"
- From Administration-> Budgets administration try to edit a fund and go to
  "Planning". Verify that the message box appears here as well.

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

--- Comment #3 from Marc Véron  ---
Seems to be a regression.

Oh, there are more candidates for Internal server errors, maybe to be
investigated / fixed in a separate bug:

git grep 'Currencies->get_active'

C4/Biblio.pm:my $active_currency =
Koha::Acquisition::Currencies->get_active;
C4/Overdues.pm:my $active_currency =
Koha::Acquisition::Currencies->get_active;
Koha/Number/Price.pm:my $currency=
Koha::Acquisition::Currencies->get_active;
about.pl:my $warnNoActiveCurrency = (! defined
Koha::Acquisition::Currencies->get_active);
acqui/acqui-home.pl:my $cur = Koha::Acquisition::Currencies->get_active;
acqui/addorder.pl:my $currency =
Koha::Acquisition::Currencies->get_active;
acqui/addorderiso2709.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
acqui/basket.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
acqui/invoice.pl:currency =>
Koha::Acquisition::Currencies->get_active,
acqui/neworderempty.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
admin/aqbudgetperiods.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
admin/aqbudgets.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
admin/aqplan.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
admin/preferences.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
opac/opac-account-pay-paypal-return.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
opac/opac-account-pay.pl:my $active_currency =
Koha::Acquisition::Currencies->get_active;
opac/sco/sco-main.pl:if ( my $active_currency =
Koha::Acquisition::Currencies->get_active ) {
t/db_dependent/Koha/Acquisition/Currencies.t:my $active_currency =
Koha::Acquisition::Currencies->get_active;
t/db_dependent/MungeMarcPrice.t:my $active_currency =
Koha::Acquisition::Currencies->get_active;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
Version|17.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

--- Comment #2 from Marc Véron  ---
Created attachment 67179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67179=edit
Bug 19328 - Internal server error because of missing currency

This patch fixes internal server errors because of missing active currency
in files aqbudgetperiods.pl, aqbudgets.pl and aqplan.pl.

To reproduce:
- Make sure that no active currency is defined. You can undefine the active
  currency in Administration->Currencies and exchange rates
- Try to go to Administration->Budgets and Admistration->Funds
Result: Internal server error

To test:
- Apply patch
- Restart plack
- Try to reproduce issue, it should no longer occur. There should be a
  yellow message box "No active currency is defined"
- From Administration-> Budgets administration try to edit a fund and go to
  "Planning". Verify that the message box appears here as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

--- Comment #1 from Marc Véron  ---
Confirmed on current master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/