[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Hammat wele  changed:

   What|Removed |Added

 Attachment #124201|0   |1
is obsolete||

--- Comment #33 from Hammat wele  ---
Created attachment 153508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153508=edit
Bug 19336: (QA follow-up) Using CirculationRules instead of IssuingRules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Hammat wele  changed:

   What|Removed |Added

 Attachment #124200|0   |1
is obsolete||

--- Comment #32 from Hammat wele  ---
Created attachment 153507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153507=edit
Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after
changes on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Hammat wele  changed:

   What|Removed |Added

 Attachment #124199|0   |1
is obsolete||

--- Comment #31 from Hammat wele  ---
Created attachment 153506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153506=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Hammat wele  changed:

   What|Removed |Added

 Attachment #124198|0   |1
is obsolete||

--- Comment #30 from Hammat wele  ---
Created attachment 153505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153505=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Hammat wele  changed:

   What|Removed |Added

 Attachment #124197|0   |1
is obsolete||

--- Comment #29 from Hammat wele  ---
Created attachment 153504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153504=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alexis Ripetti  changed:

   What|Removed |Added

 CC||alexis.ripe...@inlibro.com
  Attachment #85923|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #28 from Alexis Ripetti  ---
Created attachment 124201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124201=edit
Bug 19336: (QA follow-up) Using CirculationRules instead of IssuingRules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #27 from Alexis Ripetti  ---
Created attachment 124200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124200=edit
Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after
changes on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alexis Ripetti  changed:

   What|Removed |Added

  Attachment #85922|0   |1
is obsolete||

--- Comment #26 from Alexis Ripetti  ---
Created attachment 124199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124199=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alexis Ripetti  changed:

   What|Removed |Added

  Attachment #85921|0   |1
is obsolete||

--- Comment #25 from Alexis Ripetti  ---
Created attachment 124198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124198=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alexis Ripetti  changed:

   What|Removed |Added

  Attachment #85920|0   |1
is obsolete||

--- Comment #24 from Alexis Ripetti  ---
Created attachment 124197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124197=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mazen Khallaf  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mazen.i.khal...@gmail.com

--- Comment #23 from Mazen Khallaf  ---
Couldn't apply the patch

$ git bz apply 19336
y
Bug 19336 - Add option to fines.pl to apply maximal fine amount after delay

85920 - Bug 19336: Add --maxfinesday option to fines.pl
85921 - Bug 19336: (follow-up) Correct DateTime and Koha calls
85922 - Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report
is written
85923 - Bug 19336: (follow-up) Initialize $unitcount  instead of
$unitcounttotal after changes on master

Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 19336: Add --maxfinesday
option to fines.pl
Using index info to reconstruct a base tree...
M   misc/cronjobs/fines.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/fines.pl
CONFLICT (content): Merge conflict in misc/cronjobs/fines.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 19336: Add --maxfinesday option to fines.pl
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19336-Add---maxfinesday-option-to-finespl-d37mQ0.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Nadine Pierre  changed:

   What|Removed |Added

 CC||nadine.pie...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85918|0   |1
is obsolete||

--- Comment #20 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85921=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #22 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85923=edit
Bug 19336: (follow-up) Initialize $unitcount  instead of $unitcounttotal after
changes on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85919|0   |1
is obsolete||

--- Comment #21 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85922=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85917|0   |1
is obsolete||

--- Comment #19 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85920=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85916|0   |1
is obsolete||

--- Comment #18 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85919=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85915|0   |1
is obsolete||

--- Comment #17 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85918=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #85914|0   |1
is obsolete||

--- Comment #16 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85917=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #75381|0   |1
is obsolete||

--- Comment #15 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85916=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #75380|0   |1
is obsolete||

--- Comment #14 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85915=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Mikaël Olangcay Brisebois  changed:

   What|Removed |Added

  Attachment #75379|0   |1
is obsolete||

--- Comment #13 from Mikaël Olangcay Brisebois 
 ---
Created attachment 85914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85914=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Charles Farmer  changed:

   What|Removed |Added

   Assignee|david.bourga...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #12 from Charles Farmer  ---
Rewrote the patch titles to abide by the standardized notation.

Provided a way out of the 'In discussion' status by initializing
$unitcounttotal to 'n/a', the common abbreviation used in a report for a field
that does not apply.

Back in Needs Signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #11 from Charles Farmer  ---
Created attachment 75381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75381=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Charles Farmer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Charles Farmer  changed:

   What|Removed |Added

  Attachment #68335|0   |1
is obsolete||
  Attachment #68336|0   |1
is obsolete||

--- Comment #9 from Charles Farmer  ---
Created attachment 75379
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75379=edit
Bug 19336: Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #10 from Charles Farmer  ---
Created attachment 75380
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75380=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
 Status|Failed QA   |In Discussion

--- Comment #8 from Charles Farmer  ---
Despite the 'uninitialized value in join...' , I feel like $unitcounttotal
shouldn't take any _numerical_ values.

The concept of chargeunits stops making sense once you arbritraly charge the
overduefinescap after X given days, which is exactly what maxfinesdays does.
It's not bothered by closing hours, nor does it care about grace periods, it
bluntly maxes out the fine. This seems like a reason not to consider any
information derived from $issuing_rule->lengthunit.

Now, as I hinted at the beginning, I'm definitely open to initializing
$unitcounttotal. Since its only use is to be concanated with other fields
before being outputed to a file, it could make sense to inform the fines
report's reader that maxfinesdays was applied.

Is this approach sound in your opinion?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #7 from Katrin Fischer  ---
Moving to FQA to trigger reaction from developter to question on comment#6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Arnaud  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |alex.arn...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #6 from Alex Arnaud  ---
Hello David,

What about $type and $unitcounttotal variables? If maxfinesdays is defined and
amount != 0, they are empty.

Indeed, $type is always empty since chargename is never populated. But this
could be fixed in another BZ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68318|0   |1
is obsolete||

--- Comment #5 from Alex Buckley  ---
Created attachment 68336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68336=edit
Bug 19336 - Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67191|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 68335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68335=edit
Bug 19336 - Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #3 from David Bourgault  ---
Created attachment 68318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68318=edit
Bug 19336 - Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.bourga...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |In Discussion

--- Comment #2 from Alex Buckley  ---
Hi David

After checking out an item out with a due date set to be over 30 days ago and
then running this cronjob I have found that the following error is thrown in
the cronjob output:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone/misc/cronjobs$ ./fines.pl
--maxfinesdays 30
DateTime::Duration does not overload comparison.  See the documentation on the
compare() method for details. at ./fines.pl line 129.

And no maximum fine is added to the accountlines table

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #1 from David Bourgault  ---
Created attachment 67191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67191=edit
Bug 19336 - Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/