[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #6 from Marcel de Rooy  ---
Any feedback please ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

--- Comment #5 from Marcel de Rooy  ---
Julian, just a few preliminary comments:

-# FIXME To replace with ->find_or_create?
-if ( my $m_rs = Koha::Biblio::Metadatas->find($metadata) ) {
-$m_rs->metadata( $record->as_xml_record($encoding) );
-$m_rs->store;
-} else {
-my $m_rs = Koha::Biblio::Metadata->new($metadata);
-$m_rs->metadata( $record->as_xml_record($encoding) );
-$m_rs->store;
+
+my $m_rs = Koha::Biblio::Metadatas->find($metadata);
+unless ($m_rs) {
+$m_rs = Koha::Biblio::Metadata->new($metadata);
+}
Why did you not apply what is in the FIXME ?

You add a new sub in C4/Biblio for MARC manipulation. Actually something like
create or update. Should we not be looking now how to do such things in the
Koha namespace instead of extending C4?

You add four prefs. Would it be handy to combine them. And test on its value
before saving?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #67233|0   |1
is obsolete||

--- Comment #4 from Simon Pouchol  ---
Created attachment 68317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68317=edit
Bug 19349: Store record's creator and last modifier in record

Test plan:
1. Run updatedatabase.pl
2. Set sysprefs MarcFieldForCreatorId, MarcFieldForCreatorName,
   MarcFieldForModifierId, MarcFieldForModifierName
3. Create a new biblio
4. Verify that the fields are correctly filled
5. Logout and login as another user
6. Modify the same biblio
7. Verify that only the fields for last modifier have been modified

Works perfectly.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #3 from Julian Maurice  ---
(In reply to Alex Buckley from comment #2)
> Hi Julian
> 
> I have set the four sysprefs with the values 942$w, 942$x, 942$y, and 942$z
> however when I go to create a new biblio these four fields are not displayed
> in the '9' tab of the new biblio page

Hi Alex,

you need to create these subfields in the MARC framework you are using, or make
them visible if they already exist.

Note that the subfields are filled after you click on 'Save', so their values
are not visible in the MARC editor when you create a new biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

--- Comment #2 from Alex Buckley  ---
Hi Julian

I have set the four sysprefs with the values 942$w, 942$x, 942$y, and 942$z
however when I go to create a new biblio these four fields are not displayed in
the '9' tab of the new biblio page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

--- Comment #1 from Julian Maurice  ---
Created attachment 67233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67233=edit
Bug 19349: Store record's creator and last modifier in record

Test plan:
1. Run updatedatabase.pl
2. Set sysprefs MarcFieldForCreatorId, MarcFieldForCreatorName,
   MarcFieldForModifierId, MarcFieldForModifierName
3. Create a new biblio
4. Verify that the fields are correctly filled
5. Logout and login as another user
6. Modify the same biblio
7. Verify that only the fields for last modifier have been modified

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/