[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Resolution|--- |FIXED
 Status|Pushed to Master|RESOLVED

--- Comment #10 from Nick Clemens  ---
Awesome work all! Enhancement, won't be backported to 17.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369
Bug 19369 depends on bug 19234, which changed state.

Bug 19234 Summary: Add query parameters handling helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67544|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 69363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69363=edit
Bug 19369: Unit tests

Signed-off-by: Lari Taskula 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #67545|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 69364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69364=edit
Bug 19369: Add helper function for pagination attributes generation

This patch introduces a new helper function to the
Koha::REST::Plugin::Pagination
plugin, called 'dbic_merge_pagination'.

This simple function adds SQL::Abstract pagination attributes ('page' and
'rows') to the
passed $filter hashref.

To test:
- Apply this patches
- Run:
  $ koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County

Signed-off-by: Lari Taskula 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|19250   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19278


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278
[Bug 19278] Add a configurable default page size for endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
[Bug 19410] Koha::Objects needs a ->search_for_api method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67382|0   |1
is obsolete||

--- Comment #6 from Lari Taskula  ---
Created attachment 67545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67545=edit
Bug 19369: Add helper function for pagination attributes generation

This patch introduces a new helper function to the
Koha::REST::Plugin::Pagination
plugin, called 'dbic_merge_pagination'.

This simple function adds SQL::Abstract pagination attributes ('page' and
'rows') to the
passed $filter hashref.

To test:
- Apply this patches
- Run:
  $ koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67381|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 67544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67544=edit
Bug 19369: Unit tests

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250
[Bug 19250] Add pagination to /acquisitions/vendors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18731


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731
[Bug 18731] CRUD for acquisition orders
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67376|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 67381
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67381=edit
Bug 19369: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #67378|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 67382
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67382=edit
Bug 19369: Add helper function for pagination attributes generation

This patch introduces a new helper function to the
Koha::REST::Plugin::Pagination
plugin, called 'dbic_merge_pagination'.

This simple function adds SQL::Abstract pagination attributes ('page' and
'rows') to the
passed $filter hashref.

To test:
- Apply this patches
- Run:
  $ koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||lari.task...@jns.fi,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 67378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67378=edit
Bug 19369: Add helper function for pagination attributes generation

This patch introduces a new helper function to the
Koha::REST::Plugin::Pagination
plugin, called 'dbic_merge_pagination'.

This simple function adds SQL::Abstract pagination attributes ('page' and
'rows') to the
passed $filter hashref.

To test:
- Apply this patches
- Run:
  $ koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 67376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67376=edit
Bug 19369: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||19234
   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234
[Bug 19234] Add query parameters handling helpers
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/