[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #29 from Fridolin SOMERS  ---
Oups in GIT last commit message has the wrong bug id : Bug 19583

http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f60bff7aa0e3ca932f5572b7837d912b8681ca2a

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

--- Comment #28 from Fridolin SOMERS  ---
Enhancement not pushed to 17.05.x

Viva ElasticSearch ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #27 from Nick Clemens  ---
Small(ish) change, considered as bug

Pushed to stable for 17.11.06

Awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #26 from Jonathan Druart  
---
And I messed up with the bug number when pushing the last patch...
  Bug 19583: Remove use of C4::AuthoritiesMarc
should have been
  Bug 19582: Remove use of C4::AuthoritiesMarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #24 from Jonathan Druart  
---
Nick, please care about spaces and alignment:
In your patch it looks like:
-$query->param('value_any') || undef,
-$query->param('value_match')   || undef
+$query->param('value_match') || undef,
+$query->param('value_any')   || undef

With correct alignement:
+$query->param('value_match')   || undef,
 $query->param('value_any') || undef,
-$query->param('value_match')   || undef

Much easier to read, right?
Will be done on pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #23 from Jonathan Druart  
---
Please take care of commit messages and author:
  Author: Koha User 
  Bug 19582 - remove use of C4::AuthoritiesMarc

  Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72784|0   |1
is obsolete||

--- Comment #21 from Alex Arnaud  ---
Created attachment 72795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72795=edit
Bug 19582: (follow-up) get params in correct order

We were ordering the values out of sync with the order of the mathclist
param and so causing 'entire record' and 'all headings' to be reversed

Signed-off-by: Nicolas Legrand 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72792|0   |1
is obsolete||

--- Comment #22 from Alex Arnaud  ---
Created attachment 72796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72796=edit
Bug 19582 - remove use of C4::AuthoritiesMarc

Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72783|0   |1
is obsolete||

--- Comment #20 from Alex Arnaud  ---
Created attachment 72794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72794=edit
Bug 19582: Unit tests

Signed-off-by: David Bourgault 

Signed-off-by: Nicolas Legrand 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72782|0   |1
is obsolete||

--- Comment #19 from Alex Arnaud  ---
Created attachment 72793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72793=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

Signed-off-by: David Bourgault 

Signed-off-by: Nicolas Legrand 
Signed-off-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #18 from Alex Arnaud  ---
Created attachment 72792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72792=edit
Bug 19582 - remove use of C4::AuthoritiesMarc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nicolas Legrand  changed:

   What|Removed |Added

 CC||nicolas.legr...@bulac.fr

--- Comment #17 from Nicolas Legrand  ---
with unimarc setting and mapping from 17373

$ perl t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t 
1..2
# Subtest: build_authorities_query_compat() tests
ok 1 - Creating new query builder object for authorities
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
ok 8
ok 9 - Exception thrown on invalid value in the marclist param
1..9
ok 1 - build_authorities_query_compat() tests
# Subtest: build query from form subtests
1..5
ok 1 - Expected search is populated
ok 2 - Only defined search is populated
ok 3 - First index searched as expected
ok 4 - Second index searched when populated
ok 5 - Only defined searches are populated
ok 2 - build query from form subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #72717|0   |1
is obsolete||

--- Comment #16 from Nicolas Legrand  ---
Created attachment 72784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72784=edit
Bug 19582: (follow-up) get params in correct order

We were ordering the values out of sync with the order of the mathclist
param and so causing 'entire record' and 'all headings' to be reversed

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #69032|0   |1
is obsolete||

--- Comment #15 from Nicolas Legrand  ---
Created attachment 72783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72783=edit
Bug 19582: Unit tests

Signed-off-by: David Bourgault 

Signed-off-by: Nicolas Legrand 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #69031|0   |1
is obsolete||

--- Comment #14 from Nicolas Legrand  ---
Created attachment 72782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72782=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

Signed-off-by: David Bourgault 

Signed-off-by: Nicolas Legrand 


Current status: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #13 from Nick Clemens  ---
Created attachment 72717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72717=edit
Bug 19582: (follow-up) get params in correct order

We were ordering the values out of sync with the order of the mathclist
param and so causing 'entire record' and 'all headings' to be reversed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #12 from Alex Arnaud  ---
I'm not sure for value_any by value_all. It could be an issue related to my
unimarc authorities mapping. Can anyone using marc21 confirm this issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #11 from Alex Arnaud  ---
Also, i think that "C4::AuthoritiesMarc;" is no longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 Blocks||20273


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273
[Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use
search_auth_compat
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #10 from Alex Arnaud  ---
Hello Nick,

Searching on entire record doesn't work for me. You may replace all occurences
of "value_any" by "value_all" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 QA Contact||alex.arn...@biblibre.com

--- Comment #9 from Katrin Fischer  ---
Hi Alex, can you please take another look here? Thx!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #8 from Jonathan Druart  
---
(In reply to Alex Arnaud from comment #7)
> Hello Nick,
> 
> I have nothing to say from a QA point of view about the current changes in
> the code but i'm wondering if we should not do the same work for
> autocomplete feature (it still use C4::AuthoritiesMarc::SearchAuthorities)
> or do it in another BZ.

Yes of course, every occurrence of SearchAuthorities must be replaced. Please
open a new bug report and put on QA stamp on this one ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #7 from Alex Arnaud  ---
Hello Nick,

I have nothing to say from a QA point of view about the current changes in the
code but i'm wondering if we should not do the same work for autocomplete
feature (it still use C4::AuthoritiesMarc::SearchAuthorities) or do it in
another BZ.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19604


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604
[Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from David Bourgault  ---
Followed test plan, but it took me a long time you meant the auth search in the
record editor...

Before patch the search would actually straight-up fail for me, with patch I
got the same results as a normal auth search.

QA tools and test passed green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault  changed:

   What|Removed |Added

  Attachment #68993|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 69032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69032=edit
Bug 19582: Unit tests

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

David Bourgault  changed:

   What|Removed |Added

  Attachment #68992|0   |1
is obsolete||

--- Comment #4 from David Bourgault  ---
Created attachment 69031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69031=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68984|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 68992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68992=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disable sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #3 from Nick Clemens  ---
Created attachment 68993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68993=edit
Bug 19582: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
   ||,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #1 from Nick Clemens  ---
Created attachment 68984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68984=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/