[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #71105|0 |1 is obsole

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #41 from Jonathan Druart --- Created attachment 71389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71389&action=edit Bug 19928: Mock delimiter pref in tests -- You are receiving this mail because:

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #40 from Victor Grousset/tuxayo --- Thanks for the clarification. Yay this one finishes just in time as can start bug 20171 :D -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comm

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #38 from Katrin Fischer --- You got me a little confused there. Short form was: - Push only first patch, leave button descriptions alone. If this affects another bug, please change accordingly. -- You are receiving this

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #37 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #31) > The only thing I am not happy about it the length of the buttons > I think Victor had similar thoughts on posting the screenshots. Actua

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #36 from Jonathan Druart --- (In reply to Katrin Fischer from comment #33) > Created attachment 71272 [details] [review] > Bug 19928: Acquisitions: show the precise kind of CSV on export buttons The delimiter for custom

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #35

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added Attachment #71272|0 |1 is obsolete|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #34 from Owen Leonard --- I think "CSV" is commonly understood to include more than just comma-separated values. Is it really necessary to be so specific? For instance, an application like phpMyAdmin offers export in "CSV

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added Attachment #70750|0 |1 is obsolete|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added Attachment #71104|0 |1 is obsolete|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #31 from Katrin Fischer --- Both patches work very nicely, I especially tested for translations. The only thing I am not happy about it the length of the buttons - I think Victor had similar thoughts on posting the screen

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added CC||oleon...@myacpl.org --- Co

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #29 from Victor Grousset/tuxayo --- Created attachment 71105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71105&action=edit Screenshot of new buttons Here are how the new buttons looks. I choose valu

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #28 from Victor Grousset/tuxayo --- Created attachment 71104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71104&action=edit Bug 19928: Acquisitions: show the precise kind of CSV on export buttons Tha

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED QA Conta

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiv

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens changed: What|Removed |Added Attachment #70698|0 |1 is obsolete|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #24 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #21) > (In reply to Katrin Fischer from comment #17) > > It's missing steps. > > > > - you need to update the po files after the patch was appl

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiv

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett changed: What|Removed |Added Attachment #70426|0 |1 is obsolete|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #22

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #21 from Victor Grousset/tuxayo --- (In reply to Katrin Fischer from comment #17) > It's missing steps. > > - you need to update the po files after the patch was applied > - you have to check that the string got not mark

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #20 from Victor Grousset/tuxayo --- Tested also with current master without error. commit 129ffee791da9f8ab4ad85a4473a138fc81ccbef Author: Jonathan Druart Date: Mon Jan 15 10:10:41 2018 -0300 Bug 19968: Add missi

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #19 from Victor Grousset/tuxayo --- (In reply to M. Tompsett from comment #13) > Failed QA test tools. It passed for me. Did I make any mistake? ## kohadev-koha@ko

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #18 from M. Tompsett --- (In reply to Katrin Fischer from comment #17) > It's missing steps. > > - you need to update the po files after the patch was applied > - you have to check that the string got not marked as 'fuzz

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #17 from Katrin Fischer --- It's missing steps. - you need to update the po files after the patch was applied - you have to check that the string got not marked as 'fuzzy' - you have to reinstall the language Only then

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #16 from M. Tompsett --- (In reply to Katrin Fischer from comment #14) > Please check that the translated export still works nicely after this change. That's his test plan in comment #8. -- You are receiving this mail

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #15 from Katrin Fischer --- See bug 18331 - we have broken the translations of the CSV files more times than I can count - should not repeat that. -- You are receiving this mail because: You are watching all bug changes

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 fro

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|Failed QA |Signed Off -- You

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #12 from M. Tompsett --- (In reply to Victor Grousset/tuxayo from comment #11) > I remember removing the post/pre-chomp after having checked that the output > was still correct. Is there another caveat? If you say it is

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #11 from Victor Grousset/tuxayo --- (In reply to M. Tompsett from comment #10) > basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens > are important to the formatting of the file. Please correct.

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA CC|

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|In Discussion |Needs Signoff ---

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #70422|0 |1 is obsole

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |In Discussion --

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #7 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #6) > [...] you do not default to ';', ',' or '\t' if the pref 'delimiter' > does not exist. > > Maybe ',' is better here as it was the value b

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #6 from Jonathan Druart --- About your patches, it should not be needed but it is the behaviour of other occurrences: you do not default to ';', ',' or '\t' if the pref 'delimiter' does not exist. Maybe ',' is better he

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #5 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #4) > Thanks Joubu for this explanation: > http://git.koha-community.org/gitweb/?p=koha.git;a=commit; > h=8403799c7212349bee70090249e3425afd624

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added CC||jonathan.dru...@bug

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Status|NEW |Needs Signoff ---

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #70421|0 |1 is obsole

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 70421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70421&action=edit Bug 19928: Acquisitions' CSV exports now honors syspref "delimiter" Bonus fi

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |victor.grous...@bib

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 --- Comment #1 from Victor Grousset/tuxayo --- Everything come from here: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/intranet-tmpl/prog/en/modules/acqui/csv;hb=94cd27677d8febd2979f9f618f1e8cd1bd2d68d7 3 temp

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-c

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928 Victor Grousset/tuxayo changed: What|Removed |Added Severity|enhancement |normal -- You are