[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Claire Gravely  changed:

   What|Removed |Added

  Attachment #71471|0   |1
is obsolete||

--- Comment #9 from Claire Gravely  ---
Created attachment 71539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71539=edit
Bug 19978: Fix ITEMTYPECAT behaviour

ITEMTYPECAT permits to group and hide item types at the OPAC (see bug
10937 for a complete description).

Since commit 091d6c513bcbee224ff06477e79be48cea7fe825
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
the code assume that they are item types. Before it just assigned undef
to the description.

Test plan:
Create ITEMTYPECAT authorised values
Assign an item type to this authorised value group
Search for a item using this item type at the OPAC
Without this patch applied you get:
Can't call method "translated_description" on an undefined value at
/home/vagrant/kohaclone/opac/opac-search.pl line 231.

With this patch applied the search result is displayed.

Make sure the original feature still works.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #8 from Claire Gravely  ---
(In reply to Jonathan Druart from comment #7)
> Claire, I do not recreate.
> I am not willing to fix all the issues this feature has (from when it has
> been written) anyway :)
> The goal here is to fix regressions with previous versions.

OK I'll sign off as is and see if there is a bug report for the other issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #7 from Jonathan Druart  
---
Claire, I do not recreate.
I am not willing to fix all the issues this feature has (from when it has been
written) anyway :)
The goal here is to fix regressions with previous versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #6 from Claire Gravely  ---
(In reply to Jonathan Druart from comment #5)
> (In reply to Claire Gravely from comment #4)
> > Retested:
> > 
> > I have two ITEMTYPECAT categories. Only one of them is showing a description
> > in the OPAC Adv search. The other is still an empty checkbox. :(
> 
> I guess you forgot to fill the OPAC description field. It should pick the
> staff value, but I would prefer to fix that minor bug somewhere else.

You are right, I had only added an OPAC description for one of the categories.
> 
> > Searching by selecting only one (or both together) of my ITEMTYPECAT
> > checkboxes is still not working.  Selecting a 'Normal' itype (not in a
> > category) performs a search.
> 
> This sounds like it was a bug since the beginning. Fixed.


When 'More options' are displayed in the adv. search the categories work
correctly. It is still broken if 'More Options' hasn't been selected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #5 from Jonathan Druart  
---
(In reply to Claire Gravely from comment #4)
> Retested:
> 
> I have two ITEMTYPECAT categories. Only one of them is showing a description
> in the OPAC Adv search. The other is still an empty checkbox. :(

I guess you forgot to fill the OPAC description field. It should pick the staff
value, but I would prefer to fix that minor bug somewhere else.

> Searching by selecting only one (or both together) of my ITEMTYPECAT
> checkboxes is still not working.  Selecting a 'Normal' itype (not in a
> category) performs a search.

This sounds like it was a bug since the beginning. Fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #4 from Claire Gravely  ---
Retested:

I have two ITEMTYPECAT categories. Only one of them is showing a description in
the OPAC Adv search. The other is still an empty checkbox. :(

Searching by selecting only one (or both together) of my ITEMTYPECAT checkboxes
is still not working.  Selecting a 'Normal' itype (not in a category) performs
a search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70551|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 71471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71471=edit
Bug 19978: Fix ITEMTYPECAT behaviour

ITEMTYPECAT permits to group and hide item types at the OPAC (see bug
10937 for a complete description).

Since commit 091d6c513bcbee224ff06477e79be48cea7fe825
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
the code assume that they are item types. Before it just assigned undef
to the description.

Test plan:
Create ITEMTYPECAT authorised values
Assign an item type to this authorised value group
Search for a item using this item type at the OPAC
Without this patch applied you get:
Can't call method "translated_description" on an undefined value at
/home/vagrant/kohaclone/opac/opac-search.pl line 231.

With this patch applied the search result is displayed.

Make sure the original feature still works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from Claire Gravely  ---
Hiya,

The patch has fixed the error message.

However, in the OPAC advanced search under the Item type tab, there is a
checkbox for my new ITEMTYPECAT but no description (label) is displayed. 

If I select only the new category checkbox to perform a search (no keywords
etc), nothing happens and the advanced search page refreshes. If I check the
new category and also another itype category (eg: music) with no keywords, then
search results are displayed as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19978] ITEMTYPECAT is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19978

--- Comment #1 from Jonathan Druart  
---
Created attachment 70551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70551=edit
Bug 19978: Fix ITEMTYPECAT behaviour

ITEMTYPECAT permits to group and hide item types at the OPAC (see bug
10937 for a complete description).

Since commit 091d6c513bcbee224ff06477e79be48cea7fe825
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
the code assume that they are item types. Before it just assigned undef
to the description.

Test plan:
Create ITEMTYPECAT authorised values
Assign an item type to this authorised value group
Search for a item using this item type at the OPAC
Without this patch applied you get:
Can't call method "translated_description" on an undefined value at
/home/vagrant/kohaclone/opac/opac-search.pl line 231.

With this patch applied the search result is displayed.

Make sure the original feature still works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/