[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||26940 Depends on|

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Depends on||26940 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving th

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||22717 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Oliver Behnke changed: What|Removed |Added Blocks||22461 Referenced Bugs: ht

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Text to go in the|The | release notes|Koha:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Blocks||21596 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Text to go in the|Only the|The release notes|Ko

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Text to go in the||Only the release not

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Keywords||release-notes-needed --

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #44 from Martin Renvoize --- Backported 'Bug 20287: Koha::Object->get_from_storage' patch only (as it's very helpful for bugfix's that create new tests relying upon it) -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||21374 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 M. Tompsett changed: What|Removed |Added CC||amitddng...@gmail.com --- Com

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Owen Leonard changed: What|Removed |Added Blocks||21149 Referenced Bugs: htt

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||21136 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Bug 20287 depends on bug 21022, which changed state. Bug 21022 Summary: Exceptions should skip stringifying if message manually passed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 What|Removed

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #41 from Nick Clemens --- Follow-up patch pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #40 from Nick Clemens --- Created attachment 77221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77221&action=edit Bug 20287: (RM follow-up) Restore use C4::Members -- You are receiving this mail bec

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||21087 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||21085 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||21086 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||20226 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #38 from Jonathan Druart --- Created attachment 76927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76927&action=edit Bug 20287: (follow-up) Test exception DuplicateID for Koha::Patron->store -- You

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #37 from Jonathan Druart --- Created attachment 76924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76924&action=edit Bug 20287: (QA follow-up) Fix warning on undefined Signed-off-by: Tomas Cohen Ara

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #33 from Jonathan Druart --- Created attachment 76920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76920&action=edit Bug 20287: Replace occurrences of ModMember in REST API Signed-off-by: Josef Mora

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #32 from Jonathan Druart --- Created attachment 76919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76919&action=edit Bug 20287: Replace occurrences of AddMember in REST API Signed-off-by: Josef Mora

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #34 from Jonathan Druart --- Created attachment 76921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76921&action=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementatio

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #35 from Jonathan Druart --- Created attachment 76922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76922&action=edit Bug 20287: Use more simple object for Object.t We initially use Koha::Patron to t

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #36 from Jonathan Druart --- Created attachment 76923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76923&action=edit Bug 20287: Test exception DuplicateID for Koha::Patron->store Signed-off-by: Toma

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #31 from Jonathan Druart --- Created attachment 76918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76918&action=edit Bug 20287: generate_userid now set the userid Signed-off-by: Josef Moravec Sign

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #25 from Jonathan Druart --- Created attachment 76912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76912&action=edit Bug 20287: Move ModMember to Koha::Patron Signed-off-by: Josef Moravec Signed-o

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #29 from Jonathan Druart --- Created attachment 76916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76916&action=edit Bug 20287: Replace ModMember in patrons import Signed-off-by: Josef Moravec Sig

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #30 from Jonathan Druart --- Created attachment 76917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76917&action=edit Bug 20287: Fix update of patrons, clean the data before ->store Signed-off-by: Jo

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #26 from Jonathan Druart --- Created attachment 76913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76913&action=edit Bug 20287: ->store new deal with enrolment fee Signed-off-by: Josef Moravec Sig

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #27 from Jonathan Druart --- Created attachment 76914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76914&action=edit Bug 20287: Fix test t/db_dependent/Members.t and prevent regressions Signed-off-b

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #28 from Jonathan Druart --- Created attachment 76915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76915&action=edit Bug 20287: There is a warning, we just want to unset the value here Signed-off-by

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #19 from Jonathan Druart --- Created attachment 76906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76906&action=edit Bug 20287: Fix export issues in tests t/db_dependent/Holds/RevertWaitingStatus.t

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #20 from Jonathan Druart --- Created attachment 76907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76907&action=edit Bug 20287: Remove warning If there are no patrons in DB: Use of uninitialized val

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #21 from Jonathan Druart --- Created attachment 76908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76908&action=edit Bug 20287: New warning in t/db_dependent/Koha/Object.t (?) Signed-off-by: Josef M

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #24 from Jonathan Druart --- Created attachment 76911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76911&action=edit Bug 20287: Add plain_text_password (& Remove AddMember_Opac) But actually we coul

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #22 from Jonathan Druart --- Created attachment 76909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76909&action=edit Bug 20287: Use DBIC transaction instead of AutoCommit=0 Remove error "Already in

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #23 from Jonathan Druart --- Created attachment 76910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76910&action=edit Bug 20287: Remove AddMember_Auto I am not sure I understood the point of this sub

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #18 from Jonathan Druart --- Created attachment 76905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76905&action=edit Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowe

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #16 from Jonathan Druart --- Created attachment 76903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76903&action=edit Bug 20287: Koha::Object->get_from_storage May be part of a separate bug report if

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #17 from Jonathan Druart --- Created attachment 76904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76904&action=edit Bug 20287: Move AddMember to Koha::Patron->store Signed-off-by: Josef Moravec S

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #15 from Jonathan Druart --- Created attachment 76902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76902&action=edit Bug 20287: Move trim values to a method Signed-off-by: Josef Moravec Signed-off

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #14 from Jonathan Druart --- Created attachment 76901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76901&action=edit Bug 20287: Move fixup_cardnumber Signed-off-by: Josef Moravec Signed-off-by: To

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Blocks||21069 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Blocks||21068 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Passed QA

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21022 Referenced Bugs:

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #12 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #11) > Jonathan > > Pattern > === > I'm not sure about the pattern you are using in ->store. Take a look here: > > http://search.cpan.org/dis

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |In Discussion --- Comme

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #10 from Jonathan Druart --- The problem with the tests is that we are using Koha::Patron to test Koha::Object. We should use a more simple object for that, Koha::Patron->store does a lot of things now and so the behavio

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #9 from Jonathan Druart --- I have no idea how to fix this failure correctly, it comes from bug 20590. -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com ---

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 f

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Attachment #73436|0 |1 is obsolete|

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 73436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73436&action=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementatio

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #3 from Jonathan Druart --- Remove branch fixed and rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@li

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #2 from Josef Moravec --- Hi Jonathan, I've read the code and added few comment to commits in gitlab, hope you've received a notice about that ;) Also, there are some issues reported by QA tools: FAIL C4/Members.pm

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com --

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment

[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Jonathan Druart changed: What|Removed |Added Blocks||16846 Referenced Bugs: