https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Eric Phetteplace changed:
What|Removed |Added
CC||ephettepl...@cca.edu
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #57 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.11.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #55 from Nick Clemens ---
Created attachment 93700
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93700=edit
Bug 20334: Move new system preference into right spot in alphabet
Signed-off-by: Séverine
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #54 from Nick Clemens ---
Created attachment 93699
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93699=edit
Bug 20334: Improve syspref description and set more sensible defaults
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Nick Clemens changed:
What|Removed |Added
Attachment #93664|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Nick Clemens changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #51 from sandbo...@biblibre.com ---
Created attachment 93665
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93665=edit
Bug 20334: Improve syspref description and set more sensible defaults
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #52 from sandbo...@biblibre.com ---
Created attachment 93666
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93666=edit
Bug 20334: Move new system preferene into right spot in alphabet
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #50 from sandbo...@biblibre.com ---
Created attachment 93664
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93664=edit
Bug 20334 - Option for escaping slashes in search queries
Add
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #93586|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #93585|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #93584|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #85131|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #85129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #85130|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #85129|1 |0
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #93478|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #45 from David Gustafsson ---
Realized screwed up when attaching the last patch (using an older version, so
mismatch between commits etc). Will restore and rebase again.
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Séverine Queune changed:
What|Removed |Added
CC||severine.que...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Ere Maijala changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #42 from Katrin Fischer ---
Ere and David, are more changes needed?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #41 from David Gustafsson ---
Hi! I have not made any changes to the patch, but I had a more recent rebase of
this branch locally that had not submitted, So patch should at least apply now.
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #85129|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #39 from Ere Maijala ---
David, are you able to work on this? I'd really like to get this in 19.11, so
let my know if you need a hand here.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #38 from Katrin Fischer ---
Is there something we can do to help get this moving again?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Johanna Räisä changed:
What|Removed |Added
CC||johanna.ra...@koha-suomi.fi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Marjorie Barry-Vila changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #36 from Ere Maijala ---
I'm ok with disabling regexp altogether for the time being.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #35 from David Gustafsson ---
Yes, that change would perhaps be pretty trivial. Still not completely obvious
how to try to "autocorrect" the regexps though. The regexps in lucene are
always anchored according to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #34 from Ere Maijala ---
It'd be fine for me to change _truncate_terms to something more general. That'd
be a good place to do any other clean up, escaping or query terms
transformations.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #33 from David Gustafsson ---
Yes, it would be much easier to work on a tokenized search string with regards
to quotes etc. But do we really do this? We do it in _truncate_terms, but
that's only if auto-truncation is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #32 from Ere Maijala ---
That wouldn't be considered a regexp search since the search term doesn't start
and end with a slash. We already split the query to terms, so adding a per-term
check is not that complicated.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #31 from David Gustafsson ---
Hi! I see two major problems with this approach. Firstly, I don't think
librarians generally expect, for example, the search terms "Directive 95/46/EC"
to be interpreted as containing a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #30
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #29 from Ere Maijala ---
I don't really like the fact that a pref may affect how the search terms are
interpreted. I'd rather go without the pref and try to do the right
automatically: if the term looks like a regexp
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #27 from David Gustafsson ---
Rebased against master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #80978|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #81597|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #73222|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #81613|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #22 from David Gustafsson ---
Ops, didn't realize this was already fix. Will remove the latest patch. :)
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Attachment #81517|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #19 from Katrin Fischer ---
Created attachment 81597
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81597=edit
Bug 20334: Move new system preferene into right spot in alphabet
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #18 from Katrin Fischer ---
The file is sorted alphabetically to avoid conflicts ;)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #17 from David Gustafsson ---
Ok! I must have missed that for my previous patches. I hope the release manager
or someone in the QU team has added the entry in those cases.
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #16 from David Gustafsson ---
Created attachment 81517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81517=edit
Bug 20334: Add entry in sysprefs.sql
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #15 from Katrin Fischer ---
Hi David,
>I added an entry in the atomicupdate directory, has there been a change so it
>>should be added in sysprefs.sql instead?
No change, you need both: the atomicupdate is for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #14 from David Gustafsson ---
@Katrin Fischer: And to clarify, right now the default (Escape) is to disable
regular expressions in searches (all "/", which is used as regexp delimiter in
Elasticsearch, will be escaped).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
David Gustafsson changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #13 from David Gustafsson ---
Created attachment 80978
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80978=edit
Bug 20334: Improve syspref description and set more sensible defaults
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
--- Comment #12 from David Gustafsson ---
(In reply to Katrin Fischer from comment #11)
> Hi David,
>
> 1) Can you please add an entry for the new system preference in sysprefs.sql?
I added an entry in the atomicupdate directory,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334
Katrin Fischer changed:
What|Removed |Added
Summary|Option for escaping slashes |Elasticsearch - Option for
59 matches
Mail list logo
