[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536
Bug 20536 depends on bug 7317, which changed state.

Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Fridolin SOMERS  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to Stable|RESOLVED

--- Comment #12 from Fridolin SOMERS  ---
Depends on Bug 7317 not in 17.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Niamh  changed:

   What|Removed |Added

 CC||niamh.walker-headon@it-tall
   ||aght.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Nick Clemens  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Nick Clemens  ---
Pushed to stbale for 17.11.06

Awesome work all!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the|Adds the ability to place   |
  release notes|interlibrary loan requests  |
   |in Koha. 
  |
   |
   |
   |Interlibrary|
   |loan requests are common|
   |especially in academic or   |
   |special libraries where the |
   |enduser or librarian may be |
   |entitled to request a book  |
   |or article from an external |
   |library such as the British |
   |Library (BLDSS) using their |
   |interlibrary loan service.  |
   |
   |
   |This patch set comes with   |
   |3 configured backends - |
   |BLDSS, Freeform and a Dummy |
   |account which is the|
   |default for testing.  The   |
   |BLDSS backend allows users  |
   |to search stock held by the |
   |British Library using their |
   |api, and allows requests to |
   |be placed against it. The   |
   |Freeform backend allows the |
   |creation of Interlibrary|
   |loan requests using a   |
   |manual form.  
 |
   ||
   |Interlibrary loan requests  |
   |can be made from the OPAC   |
   |or from the staff client.   |
   |The enduser can query the   |
   |backend database and place  |
   |requests. Alternatively |
   |they can create requests|
   |using the manual form.
 |
   |From|
   |the OPAC interface endusers |
   |can view and comment on |
   |their requests if enabled.  |
   |In the staff client |
   |librarians can manage   |
   |requests placed on the  |
   |OPAC, processing them   |
   |against a backend (e.g. |
   |British Library).   |
   |Alternatively the system|
   |allows requests to be   |
   |placed with peer libraries. |
   |Peer libraries can be   |
   |identified by an|
   |Organizational patron   |
   |category type and requests  |
   |can be sent to the peer |
   |library by email.
  |
   |Core|
   |request information such as |
   |links to borrowers, branch, |
   |request status, staff and   |
   |customer notes, unique  |
   |identifiers are stored in   |
   |the database and can be |
   |displayed and reported on.  |
   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #73898|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 73917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73917=edit
Bug 20536: (ILL) authnotrequired should be explicitly unset on opac

* koha/opac-illrequest.pl - Added explicit setting of authnotrequired

Signed-off-by: Mark Tompsett 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

M. Tompsett  changed:

   What|Removed |Added

  Attachment #73847|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 73898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73898=edit
Bug 20536 - ILL: authnotrequired should be explicitly unset on opac

* koha/opac-illrequest.pl - Added explicit setting of authnotrequired

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #7 from M. Tompsett  ---
When OpacPublic is Enabled, going directly to
 http://kohadev.mydnsname.org/cgi-bin/koha/opac-illrequests.pl
on a kohadevbox doesn't give the log in, but rather attempts to show the page.
It should always require log in for ILL requests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #6 from M. Tompsett  ---
(In reply to Martin Renvoize from comment #0)
> if a user attempts to navigate
> directly to any of the ILL forms they are faced with an error rather than
> the standard login redirect.

Aaaah! That's the problem... okay, got it. Reproduced. YAY!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #73846|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize  ---
Created attachment 73847
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73847=edit
Bug 20536 - ILL: authnotrequired should be explicitly unset on opac

* koha/opac-illrequest.pl - Added explicit setting of authnotrequired

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #4 from Martin Renvoize  ---
Created attachment 73846
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73846=edit
Bug 20536 - ILL: authnotrequired should be explicitly unset on opac

* koha/opac-illrequest.pl - Added explicit setting of authnotrequired

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #73757|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Status|RESOLVED|REOPENED

--- Comment #3 from Martin Renvoize  ---
Ack, you're totally right.. it's the OPAC side I meant to patch not the staff
client!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from M. Tompsett  ---
I enabled IllModule system preference.
Went to Home -> ILL Requests (didn't get forced log in screen, though I got
configuration warning note)
Copied URL.
Logged out.
Pasted URL into address bar.
Got forced login screen.

It seems like overkill, given that:

 157 sub get_template_and_user {
 158 
 159 my $in = shift;
 160 my ( $user, $cookie, $sessionID, $flags );
 161 
 162 C4::Context->interface( $in->{type} );
 163 
 164 $in->{'authnotrequired'} ||= 0;
 165 

In C4/Auth.pm it expressly gets set if it isn't passed.
So unless you can provide a set of steps as explicit as this which repeats the
problem, I am marking this RESOLVED WORKSFORME.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

--- Comment #1 from Martin Renvoize  ---
Created attachment 73757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73757=edit
Bug 20536 - ILL: authnotrequired not explicitly unset

* ill/illrequest.pl - Added explicity setting of authnotrequired

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|18203, 18588, 18589, 18590, |
   |18591, 18592, 18837, 19587, |
   |19605, 19773, 19810, 19822, |
   |20041, 20284, 20515, 20001  |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18203
[Bug 18203] Add per borrower category restrictions on ILL placement.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18588
[Bug 18588] Integrate ILL generic_emails in notices system.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18590
[Bug 18590] Make it possible to search among ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591
[Bug 18591] Allow an arbitrary number of comments on ILLs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18592
[Bug 18592] Link from bib detail view to ILL module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837
[Bug 18837] Add an unmediated Interlibrary Loans workflow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19587
[Bug 19587] "Place request with partners" button must be hidden if no partners
defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
[Bug 19605] ILL backends should be pluggable through regular Koha plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19773
[Bug 19773] Illrequests.t raises a warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19810
[Bug 19810] ILL: 404 error when activating ILL on a package installation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19822
[Bug 19822] Add system preferences for ILL Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001
[Bug 20001] ILL: Adding a 'new request' from OPAC is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041
[Bug 20041] ILL module missing from more menu in staff when activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20284
[Bug 20284] ILL: Adding a 'new request' from OPAC fails with template error if
text exists in ILLModuleCopyrightClearance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515
[Bug 20515] "ILL Request" menu options displayed when user has no ILL
permissions
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

   Severity|new feature |trivial

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20536] ILL: authnotrequired not explicitly unset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|19588   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588
[Bug 19588] There is no ILL requests history
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/