https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Jonathan Druart changed:
What|Removed |Added
Blocks||28279
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Martin Renvoize changed:
What|Removed |Added
Keywords|release-notes-needed|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
Blocks||25864
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #74 from Martin Renvoize ---
Thanks for the fast followup Nick :) Pushed
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #73 from Nick Clemens ---
(In reply to Martin Renvoize from comment #70)
> Hmm, I think it's this one that causing a fair few breaks in tests on master
> right now..
>
> I've narrowed down some of the issues.. for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #72 from Nick Clemens ---
Created attachment 93624
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93624=edit
Bug 20589: (follow-up) Fix tests
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #71 from Martin Renvoize ---
Created attachment 93590
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93590=edit
Bug 20589: (RM follow-up) Fix Koha::SearchField.t
This patch removes the unit test for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #70 from Martin Renvoize ---
Hmm, I think it's this one that causing a fair few breaks in tests on master
right now..
I've narrowed down some of the issues.. for example I don't think we need the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #69 from David Gustafsson ---
Wonderful, thanks everyone!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Martin Renvoize changed:
What|Removed |Added
Keywords||Manual,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #68 from Martin Renvoize ---
Thanks all, great enhancement
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #67 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Martin Renvoize changed:
What|Removed |Added
Status|Passed QA |Pushed to master
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Katrin Fischer changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
QA Contact||alex.arn...@biblibre.com
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #66
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93352|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93353|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93350|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93348|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93351|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Attachment #93349|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #59 from Nick Clemens ---
Added minor followup
Everything seems to work as expected. The authority searching changes seem to
be an improvement:
previously an 'exact' search matched any term, now it must match the entire
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #58 from Nick Clemens ---
Created attachment 93353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93353=edit
Bug 20589: Remove expanded_facet variable and fix tests
Thi is a rebase from 14419 to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #57 from Nick Clemens ---
Created attachment 93352
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93352=edit
Bug 20589: DO NOT PUSH Schema changes
Signed-off-by: Nick Clemens
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #56 from Nick Clemens ---
Created attachment 93351
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93351=edit
Bug 20589: Add option for searching entire record if record stored as array
Signed-off-by:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #54 from Nick Clemens ---
Created attachment 93349
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93349=edit
Bug 20589: fix QueryBuilder tests
Signed-off-by: Nick Clemens
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #55 from Nick Clemens ---
Created attachment 93350
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93350=edit
Bug 20589: Exclude boolean fields from search fields
Signed-off-by: Nick Clemens
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
Attachment #93247|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #93241|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #93239|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #52 from David Gustafsson ---
Created attachment 93251
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93251=edit
Bug 20589: DO NOT PUSH Schema changes
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #93240|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #93238|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #47 from David Gustafsson ---
(In reply to Nick Clemens from comment #42)
> Rebased and tested, this works excellently, I would love to move this
> forward, but I see a few issues in the patches:
> 1 - You removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #92457|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #92454|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #92456|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #92455|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #40 from Nick Clemens ---
Created attachment 92456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92456=edit
Bug 20589: Exclude boolean fields from search fields
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #41 from Nick Clemens ---
Created attachment 92457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92457=edit
Bug 20589: Add option for searching entire record if record stored as array
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #39 from Nick Clemens ---
Created attachment 92455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92455=edit
Bug 20589: fix QueryBuilder tests
--
You are receiving this mail because:
You are watching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
Attachment #87411|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #37 from David Gustafsson ---
@Alex Arnaud
Thanks for the comments.
Regarding the query "(publisher:autrement OR jean)" I think it should be
written as "publisher:(autrement OR jean)" to get the results you want. Also,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
e.betemps changed:
What|Removed |Added
CC||e.bete...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #36 from Alex Arnaud ---
Hello David,
First: i like this work :).
The idea of targeting only searchable fields instead of systematically fall
back on the entire record make results more consistent (even with boosting).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #35 from David Gustafsson ---
Created attachment 87416
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87416=edit
Bug 20589: Remove QueryWeightFields syspref since no longer in use
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #34 from David Gustafsson ---
Created attachment 87415
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87415=edit
Bug 20589: Exclude boolean fields from search fields
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #87358|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #33 from David Gustafsson ---
Created attachment 87412
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87412=edit
Bug 20589: fix QueryBuilder tests
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Michal Denar changed:
What|Removed |Added
CC||blac...@gmail.com
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #31 from David Gustafsson ---
Not ready for signoff though. One test fails, I know the reason but it's not
trivial to fix (association need to be used in test data and don't know if that
is possible with TestBuilder).
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #83019|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #29 from David Gustafsson ---
Just rebased this, but need to test some more and make sure tests are not
broken. Should have that done by tomorrow.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Björn Nylén changed:
What|Removed |Added
CC||bjorn.ny...@ub.lu.se
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #28 from David Gustafsson ---
Yes, agree. I had forgotten about that. Should be easy to fix. Might be able to
do so Friday or next week.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #27 from Nick Clemens ---
David, one request here would be to include the opac/staff columns to the
mapping yaml file as well - changes that can be lost on a mapping reload are
harder to track and keep in place
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Nick Clemens changed:
What|Removed |Added
CC||ere.maij...@helsinki.fi
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Marjorie Barry-Vila changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #26 from David Gustafsson ---
Fixed incorrectly named is_mapped_biblios to mapped_biblios in mappings.tt.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #83016|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #82544|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Séverine Queune changed:
What|Removed |Added
CC||nicolas.legr...@bulac.fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #22 from David Gustafsson ---
Here is a more verbose explaction of most of the changes:
- Remove syspref QueryWeightFields as this seems not to be used anyway.
- Replace hard coded 'biblios' and 'authorities' in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #82503|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #20 from David Gustafsson ---
I will write a summary of the changes with motivations behind each one as this
can be difficult to understand by just looking at the code. I'm also a little
bit confused my self with regards
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #19 from David Gustafsson ---
*but since removing '_all' also requires adjusting this _part_ such a patch
would probably cause merge conflict with this one. So it could be simple to
bundle theses changes as one patch.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #18 from David Gustafsson ---
This is still work in progress. Have not adjusted tests for the refactored code
for example. There are parts of this patch regarding fixes for authorities
search that could be a separate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Attachment #74419|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Bug 20589 depends on bug 18316, which changed state.
Bug 18316 Summary: Add weighting/relevancy options to ElasticSearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316
What|Removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #16 from David Gustafsson ---
I have started working on this now since 18316 has been merged. Will update
beginning of next week.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Martin Renvoize changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Séverine Queune changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #13 from Katrin Fischer ---
Hi David, if you write bug 18316 instead of bug_18316, bugzilla will
automagically link it. :)
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
David Gustafsson changed:
What|Removed |Added
Depends on|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #12 from David Gustafsson ---
And about the searchable parameter, I think we are going to need this in the
future so included it as did not see a major downside of doing so. The problem
this might
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
--- Comment #11 from David Gustafsson ---
Yes, I think the best option would be to try getting bug_18316 merged, and then
refactor this upon that. I completely missed bug_18316 before starting to work
on this. I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Alex Arnaud changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589
Katrin Fischer changed:
What|Removed |Added
CC|
88 matches
Mail list logo