[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Nick Clemens changed: What|Removed |Added Blocks||22802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22802 [Bug 22802] When ordering form a staged file, if funds are populated per item order level fund should not be required -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Owen Leonard changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #13 from Lucas Gass --- not backporting to 18.05.x . Needs rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00, 18.11.05 released in|| Status|Pushed to Master|Pushed to Stable --- Comment #12 from Martin Renvoize --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Chris Cormack changed: What|Removed |Added Attachment #87285|0 |1 is obsolete|| --- Comment #10 from Chris Cormack --- Created attachment 87967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87967=edit Bug 20830: Make sure a fund is selected when ordering from a stage file Signed-off-by: Martin Renvoize Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Chris Cormack changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|tomasco...@gmail.com|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Assignee|koha-b...@lists.koha-commun |k...@univ-lyon3.fr |ity.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize --- Swapped tabs for spaces to keep the QA script happy. Tested and works as expected, though perhaps we should also be validating we're getting good data on the serverside too.. I didn't check if this was already the case. Signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Attachment #86455|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Martin Renvoize changed: What|Removed |Added Attachment #85911|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #8 from Martin Renvoize --- Created attachment 87285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87285=edit Bug 20830: Make sure a fund is selected when ordering from a stage file Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Koha Team Lyon 3 changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #7 from Koha Team Lyon 3 --- Created attachment 86455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86455=edit Bug 20830 : Make sure a fund is selected (master) patch done for master. previous one apply to 17.11.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Pierre-Marc Thibault changed: What|Removed |Added CC||pierre-marc.thibault@inlibr ||o.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Pierre-Marc Thibault --- When I try to apply, I have this error message : Applying: Bug 20830: Make sure a fund is selected when ordering from staged file Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #5 from Koha Team Lyon 3 --- More precise Test : 1) Add records to a basket from an import batch 2) Select only some of those items in the batch and don't select any fund for them. 3) Save : you get the message "Some budgets are no defined .." 4) Select a fund for each of them 5) click on Save again : you still get the message "Some budgets are no defined .." 6) Apply this patch 7) Redo steps 2,3 and 4 8) Click on Save again : no more message;. The records are imported. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Koha Team Lyon 3 changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #4 from Koha Team Lyon 3 --- Created attachment 85911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85911=edit bug 20830: Make sure a fund is selected when ordering from staged file I simply took again bug 20798 code with a little modification to set the checking only on selected items of "Select to import" tab. Seems to do the trick (patch done on version 17.11.13). Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch and don't select any fund for them. 3) Save : you get the message "Some budgets are no defined .." 4) Apply this patch 5) Select some items and choose a fund for each of them 6) Save : no more message. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #3 from Koha Team Lyon 3 --- Hello, In our Koha (17.11.13 where BZ20798 is applied), we have seen that if no fund is selected when ordering from staged file, it 's fund from inactive budget that are choosen and saved in the order. It's really a big problem. To reply to Kyle : - If MarcItemFieldsToOrder is set and there's a fund found, it will be automatically selected in /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=xxx (I've just tested it on a master version). So, I don't think we need the A step. I don't know how Koha choose the fund to save if there a fund in the "select to import" tab and an another in "Default accounting details". In my opinion, it's the "Default accounting details" that should be taken in account if it's filled. Sonia -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Keywords||RM_priority Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #2 from Kyle M Hall --- So basically, we need to check, in order that a) All checked records with MarcItemFieldsToOrder have a fund selected, OR b) All checked records have a fund selected, OR c) The account tab has a fund selected We also know that C will cascade to B, but does C *or* B cascade to A? If not, I imagine it should! To do otherwise seems like it would be counter-intuitive to librarians. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #1 from Katrin Fischer --- - MarcItemFieldsToOrder also needs to be taken into account -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
