[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Jonathan Druart changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #30 from Jonathan Druart --- 4. Update DB entry needed to prevent regression if syspref contains only \s -my $opachiddenitems = $opac - && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ ); - +my

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #28 from Michal Denar --- Created attachment 96821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96821=edit Bug 20930: (follow-up) Improve formatting of error message This patch makes a few changes

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #27 from Michal Denar --- Created attachment 96820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96820=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #26 from Michal Denar --- Created attachment 96819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96819=edit Bug 20930: Display human readable errors in preferences page Displays human readable error

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #25 from Michal Denar --- Created attachment 96818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96818=edit Bug 20930: First example - Change OpacHiddenItems to type YAML To test: 1. prove

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added Attachment #96108|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #23 from Michal Denar --- Im sorry, my fault. Patched twice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply ---

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #18 from Owen Leonard --- Created attachment 96109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96109=edit Bug 20930: First example - Change OpacHiddenItems to type YAML To test: 1. prove

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #19 from Owen Leonard --- Created attachment 96110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96110=edit Bug 20930: Display human readable errors in preferences page Displays human readable error

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What|Removed |Added Attachment #91861|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #21 from Owen Leonard --- Created attachment 96112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96112=edit Bug 20930: (follow-up) Improve formatting of error message This patch makes a few changes

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #20 from Owen Leonard --- Created attachment 96111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96111=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #16 from Ere Maijala --- Just one minor thing: I'd like to assume we'll never just tell the user that there's invalid syntax without telling the position, so could the two messages be combined into one, like "Error:

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #15 from Lari Taskula --- Created attachment 94413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94413=edit Bug 20930: Make line and column number alert translatable To test: 1. Apply patch 2. Store

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Lari Taskula changed: What|Removed |Added Attachment #91863|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #13 from Lari Taskula --- Would be nice to get this signed-off - it makes both sysadmins' and librarians' life easier as it is very simple to make mistakes in YAML syntax. Validations are usually pretty nice, especially

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #12 from Ere Maijala --- I believe I've managed to make this apply and work... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added Attachment #76384|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added Attachment #76383|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added Attachment #76382|0 |1 is obsolete|

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Michal Denar changed: What|Removed |Added CC||blac...@gmail.com ---

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Josef Moravec changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added Assignee|la...@live.fi |ere.maij...@helsinki.fi ---

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #5 from Lari Taskula --- Also fyi, these patches do not automatically change the functionality for all YAML/JSON type system preferences. The type (systempreferences.type) needs to be YAML before this applies for the

[Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Lari Taskula changed: What|Removed |Added Summary|Handle YAML type system |Validate and cache parsed