[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Hammat wele changed: What|Removed |Added CC||hammat.w...@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Hammat wele --- error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Attachment #117219|0 |1 is obsolete|| --- Comment #14 from Aleisha Amohia --- Created attachment 132278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132278=edit Bug 21266: (follow-up) Remove unnecessary vars passed to template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Attachment #117218|0 |1 is obsolete|| --- Comment #13 from Aleisha Amohia --- Created attachment 132277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132277=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Attachment #117217|0 |1 is obsolete|| --- Comment #12 from Aleisha Amohia --- Created attachment 132276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132276=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: Self issue an item 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #11 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #10) > (In reply to Katrin Fischer from comment #6) > > I feel this needs additional clean-up of the CSS to go with it. The colors > > in the top navigation bar are off on the fonts and mouse overs and not the > > same as on the front page. Overall I think the style doesn't work so well > > here because the sco pages haven't been restyled. At the moment, there are > > also issues with readabillity and contrast beside it not being so pretty - > > so I think we need to fix those at least. (Please compare toolbar on top > > with language switcher before and after change) > > Can you please provide some examples or screenshots of what you mean? I am not sure the comments still apply since then some work probably has been done on the pages. And even back then I might have been missing something. I'd have to check again, but the patches don't apply now :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #10 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #6) > I feel this needs additional clean-up of the CSS to go with it. The colors > in the top navigation bar are off on the fonts and mouse overs and not the > same as on the front page. Overall I think the style doesn't work so well > here because the sco pages haven't been restyled. At the moment, there are > also issues with readabillity and contrast beside it not being so pretty - > so I think we need to fix those at least. (Please compare toolbar on top > with language switcher before and after change) Can you please provide some examples or screenshots of what you mean? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #9 from Aleisha Amohia --- Created attachment 117219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117219=edit Bug 21266: (follow-up) Remove unnecessary vars passed to template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Attachment #85202|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 117218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117218=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Attachment #85201|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 117217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117217=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: Self issue an item 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley changed: What|Removed |Added Assignee|alexbuck...@catalyst.net.nz |alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer --- I feel this needs additional clean-up of the CSS to go with it. The colors in the top navigation bar are off on the fonts and mouse overs and not the same as on the front page. Overall I think the style doesn't work so well here because the sco pages haven't been restyled. At the moment, there are also issues with readabillity and contrast beside it not being so pretty - so I think we need to fix those at least. (Please compare toolbar on top with language switcher before and after change) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Attachment #84860|0 |1 is obsolete|| --- Comment #5 from Charles Farmer --- Created attachment 85202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85202=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Charles Farmer changed: What|Removed |Added Attachment #78103|0 |1 is obsolete|| --- Comment #4 from Charles Farmer --- Created attachment 85201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85201=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: Self issue an item 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #3 from Aleisha Amohia --- Created attachment 84860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84860=edit Bug 21266: (follow-up) Removing duplicate lines and moving code around Removing duplicates lines from sco-main.tt that are already in doc-head-close.inc. Also moving JS code into the jsinclude block and moving CSS code into the cssinclude block. Same fixes applied to sco/help.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- sco-main.tt currently contains a lot of what is in doc-head-close.inc, so we need to make some cuts from the template if we're adding the include. I don't remember off the top of my head why it was done that way, so please double-check that there isn't an unintended effect. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 --- Comment #1 from Alex Buckley --- Created attachment 78103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78103=edit Bug 21266 - Added missing doc-head-close and cssinclude to sco-main.tt Test plan: 1. Add a custom opac theme stylesheet in OpacAdditionalStylesheet syspref 2. Make sure there is a link to self checkout in your customsearch syspref. e.g.: Self issue an item 3. Also ensure you have set the syspref: WebBasedSelfCheck to 'Enable' and use a patron with the self_check_permissions, and enable AutoSelfCheckAllowed syspref and write in the username and password of the aforementioned user into the AutoSelfCheckID and AuoSelfCheckPass sysprefs 4. In the Koha OPAC click on the self issue link and notice the OPAC theme is not being applied to the self check interface. 5. Apply patch 6. Refresh the page and notice the custom theme is being applied. Sponsored-By: Central Agencies (Treasury), New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley changed: What|Removed |Added Assignee|oleon...@myacpl.org |alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
