https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
Attachment #81122|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
Attachment #81120|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Martin Renvoize changed:
What|Removed |Added
Attachment #81121|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #28 from Martin Renvoize ---
OK, my mistake.. splinter review doesn't show file moves!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #27 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #26)
> In the QA followup patch.. we've renamed the package decalaration
>
> package Koha::Util; => package Koha::Util::Navigation;
>
> but the file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #26 from Martin Renvoize ---
In the QA followup patch.. we've renamed the package decalaration
package Koha::Util; => package Koha::Util::Navigation;
but the file Koha/Util.pm was not moved to Koha/Util/Navigation.pm
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #24 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #22)
> Looks like you renamed in the package declaration but didn't rename the file?
ll Koha/Util/
total 28
-rw-r--r-- 1 dev-koha dev-koha 1851 Dec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #23 from Katrin Fischer ---
Back in queue with the follow-up of course.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #22 from Martin Renvoize ---
Looks like you renamed in the package declaration but didn't rename the file?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #21 from Marcel de Rooy ---
(In reply to Josef Moravec from comment #17)
> Koha::Util::Navigation looks best for me, but no strong opinion here.
Great. Good enough for me. Lets pull this out of discussion now..
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Attachment #78618|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Attachment #78334|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Attachment #78335|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Josef Moravec changed:
What|Removed |Added
CC||josef.mora...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #16 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #15)
> We are not stuck, we are discussing about a better name. The patches are not
> blocking another work and are not vital/a priority. Maybe we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #15 from Jonathan Druart
---
We are not stuck, we are discussing about a better name. The patches are not
blocking another work and are not vital/a priority. Maybe we should ask other
QAers?
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #13 from Marcel de Rooy ---
@Nick: This is some sort of QA deadlock about the module name. Can we push this
further now? If we find a better name, it will be trivial to do the rename
operation..
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #12 from Martin Renvoize ---
Hmm.. could it perhaps sit within Koha::I18N or Koha::Template::Utils,
Koha::Language::Utils.. not entirely opinionated about it to be honest.. :0
--
You are receiving this mail because:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #10 from Jonathan Druart
---
I'd like other QA point of views. I already had the need of a Koha::CGI, based
on CGI - https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66045
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #9 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #7)
> Quick comments here:
> 1. localReferer is camelCase
> 2. Koha::Util sounds like a very bad idea (too generic)
Fixed
--
You are receiving this
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #8 from Marcel de Rooy ---
Created attachment 78618
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78618=edit
Bug 21299: (QA follow-up) Rename module and subroutine
See QA request at comment7.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #6 from Marcel de Rooy ---
(In reply to Tomás Cohen Arazi from comment #5)
> Signed-off-by: Tomas Cohen Arazi
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #78325|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #78324|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #3 from Marcel de Rooy ---
Tomas, this begs for your signoff now :) Note that I found some extra argument
for this code in the staff script still allowing external referrals.. And more
consistency.
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Status|NEW |Needs Signoff
Patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #2 from Marcel de Rooy ---
Created attachment 78325
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78325=edit
Bug 21299: Introduce localReferer in [opac-]changelanguage.pl
With the work from the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
--- Comment #1 from Marcel de Rooy ---
Created attachment 78324
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78324=edit
Bug 21299: Add localReferer function to Util module, add test
Before implementing the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21299
Marcel de Rooy changed:
What|Removed |Added
Summary|Move referer code from |Move referer code from
39 matches
Mail list logo
