[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #82192|0 |1 is

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Blocks||21944 Referenced

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #44 from Christopher Brannon --- (In reply to Josef Moravec from comment #43) > (In reply to Josef Moravec from comment #42) > > > > And could you please separate the fix for rerouting wating hold to its own > > bug

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #43 from Josef Moravec --- (In reply to Josef Moravec from comment #42) > > And could you please separate the fix for rerouting wating hold to its own > bug report? And it would be nice to have regression test here...

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #42

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81836|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #82049|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81924|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #81853|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #37 from Christopher Brannon --- *** Bug 18490 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #35 from Christopher Brannon --- Created attachment 82049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82049=edit Bug 21346: Reroute waiting hold from wrong branch To Test: 1) Place a hold on an

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #81921|0 |1 is

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #33 from Christopher Brannon --- Okay, patches for cleanup are set. Now addressing the waiting hold at the wrong location. It must: * Bring up a modal. * Only prompt to send the item to the pickup location. * Update

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #32 from Christopher Brannon --- Created attachment 81921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81921=edit Bug 21346: Convert dialogs to modals This addresses most of the transfer dialogs.

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #31 from Christopher Brannon --- Created attachment 81853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81853=edit Bug 21346: Remove double dialog To Test: 1) Place a hold on an item for pickup at

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #79686|0 |1 is

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #29 from Christopher Brannon --- I am going to revamp this bug, once again. There are some other issues at hand that need to be done to handle this more appropriately: * I will be mapping out hold and transfer

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #28 from Christopher Brannon --- Created attachment 81100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81100=edit Bug 21346: Restore values needed for buttons -- You are receiving this mail

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary.

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Failed QA ---

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Severity|enhancement |major --- Comment

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Failed QA |Needs Signoff ---

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #24 from Christopher Brannon --- Created attachment 80879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80879=edit Bug 21346: Fixes dual modals on waiting hold. -- You are receiving this mail

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Status|Signed Off |Failed QA ---

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #22 from Christopher Brannon --- Fixed typo in plan. We should be good now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #79685|0 |1 is

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #20 from Christopher Brannon --- Resubmitted patch, removing indent changes per request and combined patches. No new code. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Attachment #78942|0 |1 is

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #18 from Christopher Brannon --- (In reply to Christopher Brannon from comment #17) > (In reply to Jonathan Druart from comment #16) > > This is bugfix, not an enhancement, right? > > I would suggest to provide a patch

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #17 from Christopher Brannon --- (In reply to Jonathan Druart from comment #16) > This is bugfix, not an enhancement, right? > I would suggest to provide a patch which would not contain the indentation > changes, that

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #15 from Christopher Brannon --- *** Bug 19720 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added CC|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #78902|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 ByWater Sandboxes changed: What|Removed |Added Attachment #78916|0 |1 is obsolete|

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Fred King changed: What|Removed |Added CC||fred.k...@medstar.net

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Blocks||18490 Referenced

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 --- Comment #11 from Christopher Brannon --- (In reply to ByWater Sandboxes from comment #9) > Created attachment 78916 [details] [review] > Bug 21346: Update buttons on transfer only > > Added a confirm only button and updated

[Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl / Fix waiting holds at wrong location bug

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Christopher Brannon changed: What|Removed |Added Summary|Remove return2 div from |Clean up dialogs in