[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #11 from Fridolin SOMERS --- Pushed to 17.11.x for 17.11.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #10 from Martin Renvoize --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > I tried the label in red but it looked bad, it takes too much visibility. I think you are right, it would be too prominent, when the search is only one valid option on the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #8 from Jonathan Druart --- I tried the label in red but it looked bad, it takes too much visibility. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #7 from Nick Clemens --- (In reply to Katrin Fischer from comment #5) > This works, but looks a bit different than other places we have required > fields (no red label, no *, no red required showing up behind the field - > but maybe it would not look right in this case?) No blocker for me, just > noting. The message when nothing is entered looks good so i think that suffices here -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- This works, but looks a bit different than other places we have required fields (no red label, no *, no red required showing up behind the field - but maybe it would not look right in this case?) No blocker for me, just noting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer changed: What|Removed |Added Attachment #79468|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 79473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79473=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Simple fix, does what it says on the tin. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Martin Renvoize changed: What|Removed |Added Attachment #79265|0 |1 is obsolete|| --- Comment #2 from Martin Renvoize --- Created attachment 79468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79468=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 --- Comment #1 from Jonathan Druart --- Created attachment 79265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79265=edit Bug 21398: Make search field mandatory when adding to a basket from an existing record Test plan: - Create a basket - Click the "Add to basket" button - Click "Search" on the first line => Without this patch you get an ugly screen: https://snag.gy/U8X3ZK.jpg => With this patch applied you will not be able to submit without filling the input in QA note: Yes, we could handle that controller side as well, but much more work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21398] Search term when adding an order from an existing record should be required
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21398 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
